Skip to content

v5.53.1 proposal - #5768

Closed
ghost wants to merge 6 commits into
v5.xfrom
v5.53.1-proposal
Closed

ghost wants to merge 6 commits into
v5.xfrom
v5.53.1-proposal

Conversation

@ghost

@ghost ghost commented May 24, 2025 •

Copy link
Copy Markdown
  • [ef7552b465] - (SEMVER-PATCH) Remove code targeting unsupported Node.js versions (Ruben Bridgewater) #5672
  • [32dd20e0cc] - (SEMVER-PATCH) [DI] Refactor mutex code guarding race condition (Thomas Watson) #5728
  • [91ecb745a5] - (SEMVER-PATCH) [test-optimization] New default value for test session name (breaking change) (Juan Antonio Fernández de Alba) #5409
  • [dc92b29025] - (SEMVER-PATCH) [test-optimization] [SDTEST-1884] Increase minimum supported version of playwright (breaking change) (Mario Vidal Domínguez) #5596
  • [1f3b634ab9] - (SEMVER-PATCH) [test-optimization] Increase minimum supported version of cypress (breaking change) (Juan Antonio Fernández de Alba) #5397

juan-fernandez and others added 6 commits May 24, 2025 05:06
When adding, removing or modifying a breakpoint there can be a race
condtion if two Remove Config configs are received in quick succession.
We already have a mutex to guard against this, but the code was in need
of a refactor because:

1. We had duplicate mutex code in two different files, where only one
   was needed
2. We couldn't easily test the main mutex code in a unit test as it was
   added in the calling file and therefore not isolated to the function
   containing the race condition.
@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.39 MB
Deduped: 103.41 MB
No deduping: 103.93 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented May 24, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@59da1f2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/dd-trace/src/plugins/util/test.js 0.00% 2 Missing ⚠️
...ages/dd-trace/src/service-naming/schemas/v0/web.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5768   +/-   ##
=======================================
  Coverage        ?   79.18%           
=======================================
  Files           ?      521           
  Lines           ?    23672           
  Branches        ?        0           
=======================================
  Hits            ?    18745           
  Misses          ?     4927           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: v5.53.1-proposal
Commit report: 46731e6
Test service: dd-trace-js-integration-tests

❌ 29 Failed (0 Known Flaky), 1006 Passed, 0 Skipped, 19m 18.28s Total Time

❌ Failed Tests (29)

This report shows up to 5 failed tests.

  • playwright@1.18.0 active test span can grab the test span and add spans - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected undefined to exist
    
  • playwright@1.18.0 active test span can grab the test span and add spans - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected undefined to exist
    
  • playwright@1.18.0 active test span can grab the test span and add tags - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected undefined to equal 'this is custom'
    
  • playwright@1.18.0 active test span can grab the test span and add tags - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected undefined to equal 'this is custom'
    
  • playwright@1.18.0 correlation between tests and RUM sessions can correlate tests and RUM sessions - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     true: expected { '_dd.p.dm': '-4', …(46) } to have property 'test.is_rum_active'
    

@pr-commenter

pr-commenter Bot commented May 24, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-24 05:18:36

Comparing candidate commit b3bd734 in PR branch v5.53.1-proposal with baseline commit 59da1f2 in branch v5.x.

Found 22 performance improvements and 0 performance regressions! Performance is the same for 1252 metrics, 49 unstable metrics.

scenario:plugin-graphql-control-18

  • 🟩 cpu_user_time [-34.364ms; -28.328ms] or [-11.577%; -9.543%]
  • 🟩 execution_time [-37.085ms; -35.344ms] or [-10.673%; -10.172%]

scenario:plugin-graphql-control-20

  • 🟩 cpu_user_time [-25.593ms; -19.111ms] or [-8.531%; -6.370%]
  • 🟩 execution_time [-30.555ms; -24.989ms] or [-8.750%; -7.156%]
  • 🟩 instructions [-56.5M instructions; -41.4M instructions] or [-8.419%; -6.170%]

scenario:plugin-graphql-control-22

  • 🟩 cpu_user_time [-24.545ms; -18.210ms] or [-8.847%; -6.564%]
  • 🟩 execution_time [-25.423ms; -22.432ms] or [-7.602%; -6.708%]
  • 🟩 instructions [-55.2M instructions; -40.4M instructions] or [-7.843%; -5.738%]

scenario:plugin-graphql-with-async-hooks-18

  • 🟩 cpu_user_time [-36.100ms; -27.997ms] or [-9.550%; -7.407%]
  • 🟩 execution_time [-38.288ms; -31.525ms] or [-8.822%; -7.264%]
  • 🟩 instructions [-55.7M instructions; -43.7M instructions] or [-6.418%; -5.033%]

scenario:plugin-graphql-with-async-hooks-20

  • 🟩 execution_time [-29.447ms; -22.023ms] or [-7.006%; -5.240%]
  • 🟩 instructions [-66.1M instructions; -51.7M instructions] or [-8.300%; -6.482%]

scenario:plugin-graphql-with-async-hooks-22

  • 🟩 execution_time [-28.068ms; -23.889ms] or [-7.035%; -5.988%]
  • 🟩 instructions [-60.8M instructions; -44.3M instructions] or [-7.513%; -5.477%]

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟩 max_rss_usage [-10.786MB; -9.454MB] or [-6.636%; -5.816%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 cpu_user_time [-86.947ms; -69.026ms] or [-7.755%; -6.157%]
  • 🟩 execution_time [-94.264ms; -78.148ms] or [-7.606%; -6.305%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 cpu_user_time [-94.455ms; -80.360ms] or [-8.250%; -7.019%]
  • 🟩 execution_time [-100.469ms; -86.404ms] or [-7.977%; -6.860%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 cpu_user_time [-89.160ms; -71.770ms] or [-7.945%; -6.395%]
  • 🟩 execution_time [-94.025ms; -77.638ms] or [-7.608%; -6.282%]

@ghost

ghost commented May 27, 2025

Copy link
Copy Markdown
Author

Superseded by #5777.

@ghost ghost closed this May 27, 2025
@ghost
ghost deleted the v5.53.1-proposal branch May 27, 2025 05:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants