Skip to content

convert mysql from asyncresource to runstores #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented May 13, 2025

What does this PR do?

Convert mysql from AsyncResource to runStores.

Motivation

AsyncResource is broken in Node 24.

Copy link

github-actions bot commented May 13, 2025

Overall package size

Self size: 9.48 MB
Deduped: 103.51 MB
No deduping: 104.03 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-05-30 18:02:16

Comparing candidate commit a074f8e in PR branch mysql-run-stores with baseline commit 5320f38 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 1272 metrics, 47 unstable metrics.

scenario:runtime-metrics-with-runtime-metrics-18

  • 🟥 cpu_user_time [+20.272ms; +50.513ms] or [+5.153%; +12.839%]

scenario:runtime-metrics-with-runtime-metrics-20

  • 🟥 cpu_user_time [+30.939ms; +49.195ms] or [+7.679%; +12.210%]
  • 🟥 instructions [+65.8M instructions; +76.7M instructions] or [+7.103%; +8.280%]

scenario:runtime-metrics-with-runtime-metrics-22

  • 🟥 instructions [+56.3M instructions; +72.6M instructions] or [+5.378%; +6.929%]

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 13, 2025

Datadog Report

Branch report: mysql-run-stores
Commit report: 0438e8d
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1147 Passed, 0 Skipped, 12m 56.12s Total Time

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 81.18812% with 19 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (5320f38) to head (a074f8e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-instrumentations/src/mysql.js 66.66% 6 Missing ⚠️
packages/dd-trace/src/plugins/tracing.js 37.50% 5 Missing ⚠️
packages/datadog-instrumentations/src/mariadb.js 85.71% 4 Missing ⚠️
packages/datadog-instrumentations/src/mysql2.js 88.57% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5723      +/-   ##
==========================================
- Coverage   78.99%   76.73%   -2.26%     
==========================================
  Files         503      513      +10     
  Lines       23110    23658     +548     
==========================================
- Hits        18255    18155     -100     
- Misses       4855     5503     +648     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rochdev rochdev force-pushed the mysql-run-stores branch from 4daf4b2 to d5ae99f Compare May 28, 2025 18:27
@rochdev rochdev force-pushed the mysql-run-stores branch from 5541c9b to afb0a31 Compare May 29, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants