-
Notifications
You must be signed in to change notification settings - Fork 311
Migrate products and instrumentations to environment component #9290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code coverage: total 57.10%, base diff 0.00%, patch 32.73% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 3925256 | Docs | Was this helpful? Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (324.744 µs) : 286, 363
. : milestone, 325,
basic (278.294 µs) : 272, 285
. : milestone, 278,
loop (8.962 ms) : 8957, 8966
. : milestone, 8962,
section candidate
noprobe (337.098 µs) : 268, 406
. : milestone, 337,
basic (284.07 µs) : 276, 293
. : milestone, 284,
loop (8.97 ms) : 8965, 8974
. : milestone, 8970,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042021
Total [baseline] (8.599 s) : 0, 8599290
Agent [candidate] (1.047 s) : 0, 1047327
Total [candidate] (8.598 s) : 0, 8598119
section iast
Agent [baseline] (1.175 s) : 0, 1175089
Total [baseline] (9.328 s) : 0, 9328206
Agent [candidate] (1.18 s) : 0, 1179721
Total [candidate] (9.369 s) : 0, 9368895
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (730.725 ms) : 0, 730725
BytebuddyAgent [candidate] (734.367 ms) : 0, 734367
GlobalTracer [baseline] (241.731 ms) : 0, 241731
GlobalTracer [candidate] (242.418 ms) : 0, 242418
AppSec [baseline] (29.962 ms) : 0, 29962
AppSec [candidate] (30.092 ms) : 0, 30092
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (6.07 ms) : 0, 6070
Remote Config [baseline] (651.915 µs) : 0, 652
Remote Config [candidate] (650.239 µs) : 0, 650
Telemetry [baseline] (10.444 ms) : 0, 10444
Telemetry [candidate] (11.195 ms) : 0, 11195
section iast
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (848.386 ms) : 0, 848386
BytebuddyAgent [candidate] (853.264 ms) : 0, 853264
GlobalTracer [baseline] (231.656 ms) : 0, 231656
GlobalTracer [candidate] (231.758 ms) : 0, 231758
IAST [baseline] (27.56 ms) : 0, 27560
IAST [candidate] (29.928 ms) : 0, 29928
AppSec [baseline] (30.314 ms) : 0, 30314
AppSec [candidate] (26.92 ms) : 0, 26920
Debugger [baseline] (5.836 ms) : 0, 5836
Debugger [candidate] (6.739 ms) : 0, 6739
Remote Config [baseline] (599.736 µs) : 0, 600
Remote Config [candidate] (583.196 µs) : 0, 583
Telemetry [baseline] (8.201 ms) : 0, 8201
Telemetry [candidate] (8.108 ms) : 0, 8108
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048759
Total [baseline] (10.66 s) : 0, 10660237
Agent [candidate] (1.037 s) : 0, 1037231
Total [candidate] (10.749 s) : 0, 10748580
section appsec
Agent [baseline] (1.227 s) : 0, 1226503
Total [baseline] (10.782 s) : 0, 10782017
Agent [candidate] (1.22 s) : 0, 1219935
Total [candidate] (10.746 s) : 0, 10746148
section iast
Agent [baseline] (1.177 s) : 0, 1176523
Total [baseline] (10.925 s) : 0, 10924731
Agent [candidate] (1.175 s) : 0, 1174957
Total [candidate] (10.948 s) : 0, 10947572
section profiling
Agent [baseline] (1.21 s) : 0, 1210424
Total [baseline] (11.086 s) : 0, 11085762
Agent [candidate] (1.203 s) : 0, 1203113
Total [candidate] (10.975 s) : 0, 10975146
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (735.451 ms) : 0, 735451
BytebuddyAgent [candidate] (728.877 ms) : 0, 728877
GlobalTracer [baseline] (243.12 ms) : 0, 243120
GlobalTracer [candidate] (241.011 ms) : 0, 241011
AppSec [baseline] (30.236 ms) : 0, 30236
AppSec [candidate] (29.809 ms) : 0, 29809
Debugger [baseline] (6.085 ms) : 0, 6085
Debugger [candidate] (6.006 ms) : 0, 6006
Remote Config [baseline] (660.515 µs) : 0, 661
Remote Config [candidate] (649.305 µs) : 0, 649
Telemetry [baseline] (10.609 ms) : 0, 10609
Telemetry [candidate] (8.397 ms) : 0, 8397
section appsec
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (757.794 ms) : 0, 757794
BytebuddyAgent [candidate] (753.446 ms) : 0, 753446
GlobalTracer [baseline] (235.938 ms) : 0, 235938
GlobalTracer [candidate] (234.814 ms) : 0, 234814
IAST [baseline] (23.771 ms) : 0, 23771
IAST [candidate] (23.595 ms) : 0, 23595
AppSec [baseline] (168.081 ms) : 0, 168081
AppSec [candidate] (168.684 ms) : 0, 168684
Debugger [baseline] (8.722 ms) : 0, 8722
Debugger [candidate] (7.202 ms) : 0, 7202
Remote Config [baseline] (617.553 µs) : 0, 618
Remote Config [candidate] (627.849 µs) : 0, 628
Telemetry [baseline] (9.023 ms) : 0, 9023
Telemetry [candidate] (9.012 ms) : 0, 9012
section iast
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (848.28 ms) : 0, 848280
BytebuddyAgent [candidate] (848.273 ms) : 0, 848273
GlobalTracer [baseline] (232.552 ms) : 0, 232552
GlobalTracer [candidate] (232.714 ms) : 0, 232714
IAST [baseline] (28.721 ms) : 0, 28721
IAST [candidate] (29.102 ms) : 0, 29102
AppSec [baseline] (28.922 ms) : 0, 28922
AppSec [candidate] (26.909 ms) : 0, 26909
Debugger [baseline] (6.635 ms) : 0, 6635
Debugger [candidate] (6.832 ms) : 0, 6832
Remote Config [baseline] (597.376 µs) : 0, 597
Remote Config [candidate] (589.516 µs) : 0, 590
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.146 ms) : 0, 8146
section profiling
crashtracking [baseline] (1.417 ms) : 0, 1417
crashtracking [candidate] (1.407 ms) : 0, 1407
BytebuddyAgent [baseline] (771.019 ms) : 0, 771019
BytebuddyAgent [candidate] (766.768 ms) : 0, 766768
GlobalTracer [baseline] (224.022 ms) : 0, 224022
GlobalTracer [candidate] (222.994 ms) : 0, 222994
AppSec [baseline] (30.662 ms) : 0, 30662
AppSec [candidate] (30.457 ms) : 0, 30457
Debugger [baseline] (6.395 ms) : 0, 6395
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (725.385 µs) : 0, 725
Remote Config [candidate] (682.225 µs) : 0, 682
Telemetry [baseline] (16.025 ms) : 0, 16025
Telemetry [candidate] (15.908 ms) : 0, 15908
ProfilingAgent [baseline] (110.093 ms) : 0, 110093
ProfilingAgent [candidate] (108.938 ms) : 0, 108938
Profiling [baseline] (110.744 ms) : 0, 110744
Profiling [candidate] (109.604 ms) : 0, 109604
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section baseline
no_agent (36.024 ms) : 35735, 36312
. : milestone, 36024,
appsec (44.39 ms) : 43988, 44791
. : milestone, 44390,
code_origins (46.193 ms) : 45771, 46616
. : milestone, 46193,
iast (45.055 ms) : 44665, 45445
. : milestone, 45055,
profiling (48.815 ms) : 48350, 49280
. : milestone, 48815,
tracing (42.615 ms) : 42259, 42971
. : milestone, 42615,
section candidate
no_agent (36.939 ms) : 36644, 37235
. : milestone, 36939,
appsec (47.647 ms) : 47242, 48052
. : milestone, 47647,
code_origins (46.139 ms) : 45737, 46541
. : milestone, 46139,
iast (45.501 ms) : 45108, 45894
. : milestone, 45501,
profiling (48.914 ms) : 48489, 49339
. : milestone, 48914,
tracing (44.546 ms) : 44167, 44925
. : milestone, 44546,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section baseline
no_agent (4.202 ms) : 4155, 4249
. : milestone, 4202,
iast (9.454 ms) : 9299, 9609
. : milestone, 9454,
iast_FULL (13.902 ms) : 13623, 14181
. : milestone, 13902,
iast_GLOBAL (9.987 ms) : 9812, 10161
. : milestone, 9987,
profiling (8.866 ms) : 8712, 9020
. : milestone, 8866,
tracing (7.44 ms) : 7336, 7545
. : milestone, 7440,
section candidate
no_agent (4.291 ms) : 4237, 4344
. : milestone, 4291,
iast (9.361 ms) : 9211, 9511
. : milestone, 9361,
iast_FULL (14.094 ms) : 13815, 14374
. : milestone, 14094,
iast_GLOBAL (10.403 ms) : 10211, 10595
. : milestone, 10403,
profiling (9.554 ms) : 9394, 9714
. : milestone, 9554,
tracing (8.128 ms) : 7992, 8264
. : milestone, 8128,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.66 ms) : 3441, 3879
. : milestone, 3660,
iast (2.194 ms) : 2131, 2257
. : milestone, 2194,
iast_GLOBAL (2.228 ms) : 2165, 2292
. : milestone, 2228,
profiling (2.06 ms) : 2007, 2112
. : milestone, 2060,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.638 ms) : 3422, 3855
. : milestone, 3638,
iast (2.204 ms) : 2140, 2267
. : milestone, 2204,
iast_GLOBAL (2.251 ms) : 2187, 2315
. : milestone, 2251,
profiling (2.062 ms) : 2009, 2114
. : milestone, 2062,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~392525681d, baseline=1.51.1-SNAPSHOT~769f89718b
dateFormat X
axisFormat %s
section baseline
no_agent (15.403 s) : 15403000, 15403000
. : milestone, 15403000,
appsec (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
iast (18.945 s) : 18945000, 18945000
. : milestone, 18945000,
iast_GLOBAL (17.908 s) : 17908000, 17908000
. : milestone, 17908000,
profiling (15.812 s) : 15812000, 15812000
. : milestone, 15812000,
tracing (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
section candidate
no_agent (15.632 s) : 15632000, 15632000
. : milestone, 15632000,
appsec (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
iast (18.444 s) : 18444000, 18444000
. : milestone, 18444000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
. : milestone, 17902000,
profiling (15.646 s) : 15646000, 15646000
. : milestone, 15646000,
tracing (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for debugger
d6e835b
to
c63c1f8
Compare
c63c1f8
to
3925256
Compare
What Does This Do
This PR migrates the various products and instrumentations to the new environment component.
Motivation
This is mainly refactoring to ensure safe access to system properties and environment variables.
Additional Notes
Environment component related stacked PRs:
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: LANGPLAT-458