-
Notifications
You must be signed in to change notification settings - Fork 310
Add dd-octo-sts trust policy #9198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040877
Total [baseline] (8.625 s) : 0, 8624873
Agent [candidate] (1.045 s) : 0, 1044906
Total [candidate] (8.603 s) : 0, 8603406
section iast
Agent [baseline] (1.171 s) : 0, 1170664
Total [baseline] (9.305 s) : 0, 9305332
Agent [candidate] (1.174 s) : 0, 1174211
Total [candidate] (9.262 s) : 0, 9262220
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (730.801 ms) : 0, 730801
BytebuddyAgent [candidate] (734.364 ms) : 0, 734364
GlobalTracer [baseline] (241.624 ms) : 0, 241624
GlobalTracer [candidate] (242.434 ms) : 0, 242434
AppSec [baseline] (30.503 ms) : 0, 30503
AppSec [candidate] (30.672 ms) : 0, 30672
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (6.019 ms) : 0, 6019
Remote Config [baseline] (664.83 µs) : 0, 665
Remote Config [candidate] (655.624 µs) : 0, 656
Telemetry [baseline] (8.987 ms) : 0, 8987
Telemetry [candidate] (8.25 ms) : 0, 8250
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (845.623 ms) : 0, 845623
BytebuddyAgent [candidate] (848.284 ms) : 0, 848284
GlobalTracer [baseline] (230.387 ms) : 0, 230387
GlobalTracer [candidate] (231.167 ms) : 0, 231167
IAST [baseline] (29.773 ms) : 0, 29773
IAST [candidate] (29.996 ms) : 0, 29996
AppSec [baseline] (25.018 ms) : 0, 25018
AppSec [candidate] (27.39 ms) : 0, 27390
Debugger [baseline] (9.215 ms) : 0, 9215
Debugger [candidate] (6.635 ms) : 0, 6635
Remote Config [baseline] (586.187 µs) : 0, 586
Remote Config [candidate] (584.079 µs) : 0, 584
Telemetry [baseline] (7.829 ms) : 0, 7829
Telemetry [candidate] (7.863 ms) : 0, 7863
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041783
Total [baseline] (10.676 s) : 0, 10675591
Agent [candidate] (1.046 s) : 0, 1046398
Total [candidate] (10.675 s) : 0, 10675120
section appsec
Agent [baseline] (1.218 s) : 0, 1217872
Total [baseline] (10.754 s) : 0, 10754353
Agent [candidate] (1.215 s) : 0, 1215325
Total [candidate] (10.754 s) : 0, 10754244
section iast
Agent [baseline] (1.174 s) : 0, 1173607
Total [baseline] (10.919 s) : 0, 10918971
Agent [candidate] (1.17 s) : 0, 1170145
Total [candidate] (10.862 s) : 0, 10861787
section profiling
Agent [baseline] (1.184 s) : 0, 1184340
Total [baseline] (10.938 s) : 0, 10937908
Agent [candidate] (1.185 s) : 0, 1184636
Total [candidate] (10.907 s) : 0, 10906521
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (731.534 ms) : 0, 731534
BytebuddyAgent [candidate] (735.585 ms) : 0, 735585
GlobalTracer [baseline] (242.16 ms) : 0, 242160
GlobalTracer [candidate] (242.536 ms) : 0, 242536
AppSec [baseline] (30.697 ms) : 0, 30697
AppSec [candidate] (30.705 ms) : 0, 30705
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (652.866 µs) : 0, 653
Remote Config [candidate] (664.766 µs) : 0, 665
Telemetry [baseline] (8.256 ms) : 0, 8256
Telemetry [candidate] (8.29 ms) : 0, 8290
section appsec
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (751.786 ms) : 0, 751786
BytebuddyAgent [candidate] (750.326 ms) : 0, 750326
GlobalTracer [baseline] (234.837 ms) : 0, 234837
GlobalTracer [candidate] (233.855 ms) : 0, 233855
IAST [baseline] (23.591 ms) : 0, 23591
IAST [candidate] (23.517 ms) : 0, 23517
AppSec [baseline] (169.274 ms) : 0, 169274
AppSec [candidate] (168.47 ms) : 0, 168470
Debugger [baseline] (6.361 ms) : 0, 6361
Debugger [candidate] (7.143 ms) : 0, 7143
Remote Config [baseline] (592.612 µs) : 0, 593
Remote Config [candidate] (604.492 µs) : 0, 604
Telemetry [baseline] (8.773 ms) : 0, 8773
Telemetry [candidate] (8.833 ms) : 0, 8833
section iast
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (847.339 ms) : 0, 847339
BytebuddyAgent [candidate] (844.764 ms) : 0, 844764
GlobalTracer [baseline] (231.377 ms) : 0, 231377
GlobalTracer [candidate] (230.639 ms) : 0, 230639
IAST [baseline] (28.093 ms) : 0, 28093
IAST [candidate] (27.579 ms) : 0, 27579
AppSec [baseline] (25.044 ms) : 0, 25044
AppSec [candidate] (28.835 ms) : 0, 28835
Debugger [baseline] (10.906 ms) : 0, 10906
Debugger [candidate] (7.49 ms) : 0, 7490
Remote Config [baseline] (587.735 µs) : 0, 588
Remote Config [candidate] (582.418 µs) : 0, 582
Telemetry [baseline] (7.931 ms) : 0, 7931
Telemetry [candidate] (7.959 ms) : 0, 7959
section profiling
crashtracking [baseline] (1.395 ms) : 0, 1395
crashtracking [candidate] (1.394 ms) : 0, 1394
BytebuddyAgent [baseline] (759.768 ms) : 0, 759768
BytebuddyAgent [candidate] (758.912 ms) : 0, 758912
GlobalTracer [baseline] (220.273 ms) : 0, 220273
GlobalTracer [candidate] (220.61 ms) : 0, 220610
AppSec [baseline] (30.449 ms) : 0, 30449
AppSec [candidate] (30.461 ms) : 0, 30461
Debugger [baseline] (6.298 ms) : 0, 6298
Debugger [candidate] (6.305 ms) : 0, 6305
Remote Config [baseline] (701.546 µs) : 0, 702
Remote Config [candidate] (671.521 µs) : 0, 672
Telemetry [baseline] (13.898 ms) : 0, 13898
Telemetry [candidate] (14.213 ms) : 0, 14213
ProfilingAgent [baseline] (103.23 ms) : 0, 103230
ProfilingAgent [candidate] (103.783 ms) : 0, 103783
Profiling [baseline] (103.252 ms) : 0, 103252
Profiling [candidate] (103.806 ms) : 0, 103806
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section baseline
no_agent (4.212 ms) : 4160, 4264
. : milestone, 4212,
iast (9.632 ms) : 9464, 9799
. : milestone, 9632,
iast_FULL (14.227 ms) : 13951, 14503
. : milestone, 14227,
iast_GLOBAL (10.016 ms) : 9842, 10190
. : milestone, 10016,
profiling (8.966 ms) : 8824, 9109
. : milestone, 8966,
tracing (7.497 ms) : 7392, 7602
. : milestone, 7497,
section candidate
no_agent (4.347 ms) : 4293, 4401
. : milestone, 4347,
iast (9.207 ms) : 9057, 9357
. : milestone, 9207,
iast_FULL (14.249 ms) : 13963, 14535
. : milestone, 14249,
iast_GLOBAL (10.53 ms) : 10344, 10715
. : milestone, 10530,
profiling (8.767 ms) : 8632, 8903
. : milestone, 8767,
tracing (7.38 ms) : 7267, 7493
. : milestone, 7380,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section baseline
no_agent (37.274 ms) : 36975, 37573
. : milestone, 37274,
appsec (49.886 ms) : 49442, 50330
. : milestone, 49886,
code_origins (45.074 ms) : 44693, 45454
. : milestone, 45074,
iast (42.589 ms) : 42224, 42953
. : milestone, 42589,
profiling (48.881 ms) : 48453, 49308
. : milestone, 48881,
tracing (43.185 ms) : 42811, 43559
. : milestone, 43185,
section candidate
no_agent (36.503 ms) : 36208, 36799
. : milestone, 36503,
appsec (47.834 ms) : 47396, 48272
. : milestone, 47834,
code_origins (44.73 ms) : 44345, 45114
. : milestone, 44730,
iast (44.695 ms) : 44317, 45072
. : milestone, 44695,
profiling (47.416 ms) : 46963, 47868
. : milestone, 47416,
tracing (43.247 ms) : 42881, 43613
. : milestone, 43247,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.614 ms) : 3400, 3827
. : milestone, 3614,
iast (2.192 ms) : 2129, 2254
. : milestone, 2192,
iast_GLOBAL (2.247 ms) : 2184, 2310
. : milestone, 2247,
profiling (2.039 ms) : 1989, 2089
. : milestone, 2039,
tracing (2.007 ms) : 1958, 2055
. : milestone, 2007,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.642 ms) : 3423, 3860
. : milestone, 3642,
iast (2.206 ms) : 2143, 2268
. : milestone, 2206,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.067 ms) : 2015, 2120
. : milestone, 2067,
tracing (2.021 ms) : 1972, 2069
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~5bc52e6be4, baseline=1.52.0-SNAPSHOT~887ea397cc
dateFormat X
axisFormat %s
section baseline
no_agent (15.456 s) : 15456000, 15456000
. : milestone, 15456000,
appsec (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
iast (18.222 s) : 18222000, 18222000
. : milestone, 18222000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
. : milestone, 18033000,
profiling (15.505 s) : 15505000, 15505000
. : milestone, 15505000,
tracing (14.681 s) : 14681000, 14681000
. : milestone, 14681000,
section candidate
no_agent (15.563 s) : 15563000, 15563000
. : milestone, 15563000,
appsec (14.856 s) : 14856000, 14856000
. : milestone, 14856000,
iast (18.067 s) : 18067000, 18067000
. : milestone, 18067000,
iast_GLOBAL (18.257 s) : 18257000, 18257000
. : milestone, 18257000,
profiling (15.519 s) : 15519000, 15519000
. : milestone, 15519000,
tracing (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
|
What Does This Do
This PR adds the trust policy for
dd-octo-sts
usage.Motivation
We want to use
dd-octo-sts
for github PATs instead of our current fine-grained tokens. Since trust policies must be read from themaster
branch to be valid, the policy needs to be merged in before we can test the token workflow.Additional Notes
The github release token is needed when we tag a release, so the policy is tailored for git tags. The policy is tested to work with this dd-octo-sts-sandbox example run.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-696