Switch to typelevel weaver #9195
Open
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
added
tag: community
daniel-mohedano
requested changes
Jul 17, 2025
There was a problem hiding this comment.
Thanks for opening this PR @majk-p! From what I've gathered by locally testing, I think some additional changes will be necessary in order to support TypeLevel releases too, as currently the instrumentation will break with them. Will get back to you as soon as I take a look 👍
| @@ -3,23 +3,23 @@ apply plugin: 'scala' | |||
|
|
|||
| muzzle { | |||
There was a problem hiding this comment.
We want to also perform muzzle checks in the previous org, to ensure that changes to the instrumentation don't break on those versions too.
Suggested change
| muzzle { | |
| muzzle { | |
| pass { | |
| group = 'com.disneystreaming' | |
| module = 'weaver-cats_3' | |
| versions = '[0.8.4,)' | |
| } |
|
|
||
| testImplementation testFixtures(project(':dd-java-agent:agent-ci-visibility')) | ||
|
|
||
| testImplementation group: 'org.scala-lang', name: 'scala-library', version: '2.12.20' | ||
| testImplementation group: 'com.disneystreaming', name: 'weaver-cats_3', version: '0.8.4' | ||
| testImplementation group: 'org.typelevel', name: 'weaver-cats_3', version: '0.9.2' |
There was a problem hiding this comment.
Suggested change
| testImplementation group: 'org.typelevel', name: 'weaver-cats_3', version: '0.9.2' | |
| testImplementation group: 'org.typelevel', name: 'weaver-cats_3', version: '0.9.0' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates weaver-test and changes the organization following the recent migration
Motivation
Weaver has been migrated (typelevel/governance#114) from disneystreaming (https://github.com/disneystreaming/weaver-test) to typelevel (https://github.com/typelevel/weaver-test) organization. It has also got version updates in the meantime.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]