-
Notifications
You must be signed in to change notification settings - Fork 311
Add JDK 25-EA testing to CI #9140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4d56262
5d0fa98
33dc1bb
06e3d00
b9e074d
bafac24
0e1da3e
6c321d5
eb324be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,7 @@ workflow: | |
- "11" | ||
- "17" | ||
- "21" | ||
- "25" | ||
- "stable" | ||
- "semeru11" | ||
- "oracle8" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,17 @@ | ||
package datadog.trace.instrumentation.java.lang | ||
|
||
import datadog.environment.JavaVirtualMachine | ||
import datadog.trace.agent.test.AgentTestRunner | ||
import datadog.trace.api.iast.InstrumentationBridge | ||
import datadog.trace.api.iast.sink.CommandInjectionModule | ||
import foo.bar.TestRuntimeSuite | ||
import groovy.transform.CompileDynamic | ||
import spock.lang.IgnoreIf | ||
|
||
@CompileDynamic | ||
@IgnoreIf(reason = "TODO: Fix for Java 25.", value = { | ||
JavaVirtualMachine.isJavaVersionAtLeast(25) | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
class RuntimeCallSiteTest extends AgentTestRunner { | ||
|
||
@Override | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,15 @@ | ||
import datadog.environment.JavaVirtualMachine | ||
import datadog.trace.agent.test.AgentTestRunner | ||
import org.apache.log4j.Category | ||
import org.apache.log4j.MDC | ||
import org.apache.log4j.Priority | ||
import org.apache.log4j.spi.LoggingEvent | ||
import spock.lang.IgnoreIf | ||
|
||
class MdcTest extends AgentTestRunner { | ||
@IgnoreIf(reason = "TODO: Fix for Java 25.", value = { | ||
JavaVirtualMachine.isJavaVersionAtLeast(25) | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
def "should preserve mdc when logging injection is #injectionEnabled"() { | ||
setup: | ||
injectSysConfig("logs.injection", injectionEnabled) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,9 @@ import spock.lang.TempDir | |
import java.nio.file.Files | ||
import java.nio.file.Path | ||
|
||
@IgnoreIf(reason = "TODO: Fix for Java 25. Gradle does not support Java 25 yet: https://docs.gradle.org/current/userguide/compatibility.html#java_runtime", value = { | ||
JavaVirtualMachine.isJavaVersionAtLeast(25) | ||
}) | ||
Comment on lines
+26
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
class GradleDaemonSmokeTest extends AbstractGradleTest { | ||
|
||
private static final String TEST_SERVICE_NAME = "test-gradle-service" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,11 @@ plugins { | |
id 'com.gradleup.shadow' | ||
} | ||
|
||
ext { | ||
// TODO: Fix for Java 25. Gradle Test Executor failed. Update givenGradleVersionIsCompatibleWithCurrentJvm() when Gradle releases Java 25 support: https://docs.gradle.org/current/userguide/compatibility.html#java_runtime | ||
maxJavaVersionForTests = JavaVersion.VERSION_24 | ||
} | ||
Comment on lines
+7
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
apply from: "$rootDir/gradle/java.gradle" | ||
description = 'Log injection Smoke Tests.' | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
package datadog.smoketest | ||
|
||
import datadog.environment.JavaVirtualMachine | ||
import datadog.trace.api.Config | ||
import datadog.trace.api.civisibility.CIConstants | ||
import datadog.trace.api.config.CiVisibilityConfig | ||
import datadog.trace.api.config.GeneralConfig | ||
import datadog.trace.civisibility.CiVisibilitySmokeTest | ||
import datadog.trace.util.Strings | ||
import spock.lang.IgnoreIf | ||
|
||
import java.nio.file.FileVisitResult | ||
import java.nio.file.Files | ||
import java.nio.file.Path | ||
|
@@ -57,6 +60,9 @@ class MavenSmokeTest extends CiVisibilitySmokeTest { | |
mockBackend.reset() | ||
} | ||
|
||
@IgnoreIf(reason = "TODO: Fix for Java 25. test_successful_maven_run_junit_platform_runner jacoco coverage is failing, possibly due to lack of jacoco support for Java 25. Recommended fix is to update DEFAULT_CIVISIBILITY_JACOCO_PLUGIN_VERSION when support is added: https://github.com/jacoco/jacoco/releases", value = { | ||
JavaVirtualMachine.isJavaVersionAtLeast(25) | ||
}) | ||
Comment on lines
+63
to
+65
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
def "test #projectName, v#mavenVersion"() { | ||
println "Starting: ${projectName} ${mavenVersion}" | ||
Assumptions.assumeTrue(Jvm.current.isJavaVersionCompatible(minSupportedJavaVersion), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a task to follow-up on this https://datadoghq.atlassian.net/browse/LANGPLAT-702