-
Notifications
You must be signed in to change notification settings - Fork 323
Fix exceptions raised from Collection values #10322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some RuntimeException thrown by collection values (ListValue, MapValue or SetValue) may not be caught correctly and handled as EvaluationError leading to exception bubbling up to catches into instrumented code but lost and only reported as telemetry logs. All exceptions in collection values are now either IllegalArgumentException or UnsupportedOperationException and handled as such in collection expressions and index expression. As a a safety net, all expression evaluations are wrapped with a catch all exceptions to be wrapped as an EvaluationError with the full expression string.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (320.796 µs) : 282, 360
. : milestone, 321,
basic (276.83 µs) : 271, 282
. : milestone, 277,
loop (8.963 ms) : 8958, 8967
. : milestone, 8963,
section candidate
noprobe (333.657 µs) : 262, 405
. : milestone, 334,
basic (273.651 µs) : 268, 279
. : milestone, 274,
loop (8.967 ms) : 8962, 8972
. : milestone, 8967,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082689
Total [baseline] (10.782 s) : 0, 10782300
Agent [candidate] (1.086 s) : 0, 1086091
Total [candidate] (10.836 s) : 0, 10836272
section appsec
Agent [baseline] (1.267 s) : 0, 1267373
Total [baseline] (10.911 s) : 0, 10911367
Agent [candidate] (1.268 s) : 0, 1268135
Total [candidate] (11.035 s) : 0, 11034823
section iast
Agent [baseline] (1.226 s) : 0, 1226063
Total [baseline] (11.19 s) : 0, 11189565
Agent [candidate] (1.237 s) : 0, 1236683
Total [candidate] (11.152 s) : 0, 11151672
section profiling
Agent [baseline] (1.206 s) : 0, 1205802
Total [baseline] (10.947 s) : 0, 10947093
Agent [candidate] (1.21 s) : 0, 1209926
Total [candidate] (10.956 s) : 0, 10956193
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (650.012 ms) : 0, 650012
BytebuddyAgent [candidate] (652.319 ms) : 0, 652319
GlobalTracer [baseline] (281.74 ms) : 0, 281740
GlobalTracer [candidate] (282.463 ms) : 0, 282463
AppSec [baseline] (32.578 ms) : 0, 32578
AppSec [candidate] (32.668 ms) : 0, 32668
Debugger [baseline] (68.274 ms) : 0, 68274
Debugger [candidate] (68.492 ms) : 0, 68492
Remote Config [baseline] (610.296 µs) : 0, 610
Remote Config [candidate] (613.13 µs) : 0, 613
Telemetry [baseline] (8.998 ms) : 0, 8998
Telemetry [candidate] (9.123 ms) : 0, 9123
Flare Poller [baseline] (3.78 ms) : 0, 3780
Flare Poller [candidate] (3.777 ms) : 0, 3777
section appsec
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (692.386 ms) : 0, 692386
BytebuddyAgent [candidate] (692.434 ms) : 0, 692434
GlobalTracer [baseline] (258.183 ms) : 0, 258183
GlobalTracer [candidate] (258.924 ms) : 0, 258924
AppSec [baseline] (173.446 ms) : 0, 173446
AppSec [candidate] (173.772 ms) : 0, 173772
Debugger [baseline] (68.325 ms) : 0, 68325
Debugger [candidate] (67.952 ms) : 0, 67952
Remote Config [baseline] (749.339 µs) : 0, 749
Remote Config [candidate] (750.4 µs) : 0, 750
Telemetry [baseline] (9.344 ms) : 0, 9344
Telemetry [candidate] (9.532 ms) : 0, 9532
Flare Poller [baseline] (3.816 ms) : 0, 3816
Flare Poller [candidate] (3.815 ms) : 0, 3815
IAST [baseline] (24.543 ms) : 0, 24543
IAST [candidate] (24.48 ms) : 0, 24480
section iast
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (792.444 ms) : 0, 792444
BytebuddyAgent [candidate] (800.306 ms) : 0, 800306
GlobalTracer [baseline] (256.584 ms) : 0, 256584
GlobalTracer [candidate] (257.793 ms) : 0, 257793
AppSec [baseline] (31.856 ms) : 0, 31856
AppSec [candidate] (34.905 ms) : 0, 34905
Debugger [baseline] (68.999 ms) : 0, 68999
Debugger [candidate] (66.677 ms) : 0, 66677
Remote Config [baseline] (565.437 µs) : 0, 565
Remote Config [candidate] (570.791 µs) : 0, 571
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (8.528 ms) : 0, 8528
Flare Poller [baseline] (3.517 ms) : 0, 3517
Flare Poller [candidate] (3.517 ms) : 0, 3517
IAST [baseline] (27.134 ms) : 0, 27134
IAST [candidate] (27.503 ms) : 0, 27503
section profiling
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (703.847 ms) : 0, 703847
BytebuddyAgent [candidate] (706.914 ms) : 0, 706914
GlobalTracer [baseline] (220.785 ms) : 0, 220785
GlobalTracer [candidate] (221.393 ms) : 0, 221393
AppSec [baseline] (32.092 ms) : 0, 32092
AppSec [candidate] (32.157 ms) : 0, 32157
Debugger [baseline] (67.762 ms) : 0, 67762
Debugger [candidate] (68.151 ms) : 0, 68151
Remote Config [baseline] (634.056 µs) : 0, 634
Remote Config [candidate] (635.285 µs) : 0, 635
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.72 ms) : 0, 8720
Flare Poller [baseline] (3.694 ms) : 0, 3694
Flare Poller [candidate] (3.641 ms) : 0, 3641
ProfilingAgent [baseline] (97.204 ms) : 0, 97204
ProfilingAgent [candidate] (97.07 ms) : 0, 97070
Profiling [baseline] (97.778 ms) : 0, 97778
Profiling [candidate] (97.646 ms) : 0, 97646
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083347
Total [baseline] (8.781 s) : 0, 8780622
Agent [candidate] (1.087 s) : 0, 1087217
Total [candidate] (8.768 s) : 0, 8768433
section iast
Agent [baseline] (1.219 s) : 0, 1218963
Total [baseline] (9.324 s) : 0, 9323770
Agent [candidate] (1.236 s) : 0, 1236496
Total [candidate] (9.349 s) : 0, 9349249
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (650.966 ms) : 0, 650966
BytebuddyAgent [candidate] (652.359 ms) : 0, 652359
GlobalTracer [baseline] (282.147 ms) : 0, 282147
GlobalTracer [candidate] (283.839 ms) : 0, 283839
AppSec [baseline] (32.73 ms) : 0, 32730
AppSec [candidate] (32.994 ms) : 0, 32994
Debugger [baseline] (67.463 ms) : 0, 67463
Debugger [candidate] (67.946 ms) : 0, 67946
Remote Config [baseline] (613.902 µs) : 0, 614
Remote Config [candidate] (611.894 µs) : 0, 612
Telemetry [baseline] (9.046 ms) : 0, 9046
Telemetry [candidate] (8.991 ms) : 0, 8991
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.774 ms) : 0, 3774
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (788.87 ms) : 0, 788870
BytebuddyAgent [candidate] (800.398 ms) : 0, 800398
GlobalTracer [baseline] (255.061 ms) : 0, 255061
GlobalTracer [candidate] (258.876 ms) : 0, 258876
AppSec [baseline] (32.777 ms) : 0, 32777
AppSec [candidate] (32.144 ms) : 0, 32144
Debugger [baseline] (66.301 ms) : 0, 66301
Debugger [candidate] (68.228 ms) : 0, 68228
Remote Config [baseline] (598.845 µs) : 0, 599
Remote Config [candidate] (596.763 µs) : 0, 597
Telemetry [baseline] (8.411 ms) : 0, 8411
Telemetry [candidate] (8.529 ms) : 0, 8529
Flare Poller [baseline] (3.522 ms) : 0, 3522
Flare Poller [candidate] (3.581 ms) : 0, 3581
IAST [baseline] (26.915 ms) : 0, 26915
IAST [candidate] (27.472 ms) : 0, 27472
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1194, 1217
. : milestone, 1205,
iast (3.191 ms) : 3149, 3233
. : milestone, 3191,
iast_FULL (5.903 ms) : 5842, 5963
. : milestone, 5903,
iast_GLOBAL (3.708 ms) : 3646, 3770
. : milestone, 3708,
profiling (1.881 ms) : 1865, 1897
. : milestone, 1881,
tracing (1.754 ms) : 1739, 1769
. : milestone, 1754,
section candidate
no_agent (1.201 ms) : 1188, 1213
. : milestone, 1201,
iast (3.201 ms) : 3160, 3242
. : milestone, 3201,
iast_FULL (5.784 ms) : 5727, 5842
. : milestone, 5784,
iast_GLOBAL (3.528 ms) : 3476, 3580
. : milestone, 3528,
profiling (1.968 ms) : 1952, 1985
. : milestone, 1968,
tracing (1.784 ms) : 1769, 1798
. : milestone, 1784,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (18.587 ms) : 18388, 18785
. : milestone, 18587,
appsec (18.928 ms) : 18738, 19118
. : milestone, 18928,
code_origins (17.838 ms) : 17663, 18014
. : milestone, 17838,
iast (18.25 ms) : 18063, 18438
. : milestone, 18250,
profiling (18.915 ms) : 18725, 19104
. : milestone, 18915,
tracing (17.779 ms) : 17605, 17953
. : milestone, 17779,
section candidate
no_agent (19.264 ms) : 19065, 19464
. : milestone, 19264,
appsec (18.708 ms) : 18521, 18894
. : milestone, 18708,
code_origins (17.884 ms) : 17704, 18065
. : milestone, 17884,
iast (17.798 ms) : 17620, 17976
. : milestone, 17798,
profiling (18.568 ms) : 18381, 18755
. : milestone, 18568,
tracing (17.874 ms) : 17700, 18049
. : milestone, 17874,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
appsec (14.487 s) : 14487000, 14487000
. : milestone, 14487000,
iast (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
iast_GLOBAL (17.609 s) : 17609000, 17609000
. : milestone, 17609000,
profiling (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
tracing (14.811 s) : 14811000, 14811000
. : milestone, 14811000,
section candidate
no_agent (15.148 s) : 15148000, 15148000
. : milestone, 15148000,
appsec (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
iast (18.45 s) : 18450000, 18450000
. : milestone, 18450000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.465 s) : 15465000, 15465000
. : milestone, 15465000,
tracing (14.557 s) : 14557000, 14557000
. : milestone, 14557000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~5063c9c568, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.654 ms) : 3438, 3871
. : milestone, 3654,
iast (2.212 ms) : 2147, 2277
. : milestone, 2212,
iast_GLOBAL (2.25 ms) : 2184, 2315
. : milestone, 2250,
profiling (2.071 ms) : 2017, 2125
. : milestone, 2071,
tracing (2.045 ms) : 1994, 2096
. : milestone, 2045,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.651 ms) : 3436, 3866
. : milestone, 3651,
iast (2.21 ms) : 2145, 2274
. : milestone, 2210,
iast_GLOBAL (2.256 ms) : 2191, 2321
. : milestone, 2256,
profiling (2.057 ms) : 2005, 2110
. : milestone, 2057,
tracing (2.039 ms) : 1988, 2090
. : milestone, 2039,
|
tylfin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
What Does This Do
Some RuntimeException thrown by collection values (ListValue, MapValue
or SetValue) may not be caught correctly and handled as
EvaluationError leading to exception bubbling up to catches into instrumented code but lost and only reported as telemetry logs. All exceptions in collection values are now either IllegalArgumentException or UnsupportedOperationException and handled as such in collection expressions and index expression.
As a a safety net, all expression evaluations are wrapped with a catch
all exceptions to be wrapped as an EvaluationError with the full expression string.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4938