-
Notifications
You must be signed in to change notification settings - Fork 324
Avoid null store put on Ignite instrumentation #10291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c2087b to
5b77c73
Compare
vandonr
approved these changes
Jan 6, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084142
Total [baseline] (8.762 s) : 0, 8762500
Agent [candidate] (1.089 s) : 0, 1088589
Total [candidate] (8.721 s) : 0, 8721481
section iast
Agent [baseline] (1.23 s) : 0, 1229606
Total [baseline] (9.291 s) : 0, 9291356
Agent [candidate] (1.225 s) : 0, 1225306
Total [candidate] (9.316 s) : 0, 9316495
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (652.291 ms) : 0, 652291
BytebuddyAgent [candidate] (653.56 ms) : 0, 653560
GlobalTracer [baseline] (281.702 ms) : 0, 281702
GlobalTracer [candidate] (284.094 ms) : 0, 284094
AppSec [baseline] (32.6 ms) : 0, 32600
AppSec [candidate] (32.826 ms) : 0, 32826
Debugger [baseline] (67.463 ms) : 0, 67463
Debugger [candidate] (67.986 ms) : 0, 67986
Remote Config [baseline] (616.793 µs) : 0, 617
Remote Config [candidate] (605.373 µs) : 0, 605
Telemetry [baseline] (8.996 ms) : 0, 8996
Telemetry [candidate] (8.975 ms) : 0, 8975
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.74 ms) : 0, 3740
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (796.528 ms) : 0, 796528
BytebuddyAgent [candidate] (792.176 ms) : 0, 792176
GlobalTracer [baseline] (256.913 ms) : 0, 256913
GlobalTracer [candidate] (257.301 ms) : 0, 257301
IAST [baseline] (27.36 ms) : 0, 27360
IAST [candidate] (27.315 ms) : 0, 27315
AppSec [baseline] (35.312 ms) : 0, 35312
AppSec [candidate] (34.348 ms) : 0, 34348
Debugger [baseline] (64.26 ms) : 0, 64260
Debugger [candidate] (65.007 ms) : 0, 65007
Remote Config [baseline] (569.524 µs) : 0, 570
Remote Config [candidate] (613.485 µs) : 0, 613
Telemetry [baseline] (8.497 ms) : 0, 8497
Telemetry [candidate] (8.472 ms) : 0, 8472
Flare Poller [baseline] (3.576 ms) : 0, 3576
Flare Poller [candidate] (3.585 ms) : 0, 3585
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079717
Total [baseline] (10.809 s) : 0, 10809256
Agent [candidate] (1.083 s) : 0, 1083200
Total [candidate] (10.805 s) : 0, 10804751
section appsec
Agent [baseline] (1.264 s) : 0, 1263658
Total [baseline] (10.94 s) : 0, 10939832
Agent [candidate] (1.263 s) : 0, 1263458
Total [candidate] (11.009 s) : 0, 11009228
section iast
Agent [baseline] (1.222 s) : 0, 1222246
Total [baseline] (11.07 s) : 0, 11070035
Agent [candidate] (1.228 s) : 0, 1228147
Total [candidate] (11.212 s) : 0, 11212443
section profiling
Agent [baseline] (1.202 s) : 0, 1202353
Total [baseline] (10.874 s) : 0, 10874253
Agent [candidate] (1.212 s) : 0, 1211857
Total [candidate] (10.881 s) : 0, 10881184
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (647.684 ms) : 0, 647684
BytebuddyAgent [candidate] (650.334 ms) : 0, 650334
GlobalTracer [baseline] (281.483 ms) : 0, 281483
GlobalTracer [candidate] (282.118 ms) : 0, 282118
AppSec [baseline] (32.469 ms) : 0, 32469
AppSec [candidate] (32.62 ms) : 0, 32620
Debugger [baseline] (68.301 ms) : 0, 68301
Debugger [candidate] (68.157 ms) : 0, 68157
Remote Config [baseline] (617.526 µs) : 0, 618
Remote Config [candidate] (598.681 µs) : 0, 599
Telemetry [baseline] (8.946 ms) : 0, 8946
Telemetry [candidate] (9.014 ms) : 0, 9014
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.778 ms) : 0, 3778
section appsec
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (689.778 ms) : 0, 689778
BytebuddyAgent [candidate] (689.638 ms) : 0, 689638
GlobalTracer [baseline] (257.955 ms) : 0, 257955
GlobalTracer [candidate] (257.938 ms) : 0, 257938
IAST [baseline] (24.53 ms) : 0, 24530
IAST [candidate] (24.62 ms) : 0, 24620
AppSec [baseline] (172.445 ms) : 0, 172445
AppSec [candidate] (172.66 ms) : 0, 172660
Debugger [baseline] (68.297 ms) : 0, 68297
Debugger [candidate] (68.213 ms) : 0, 68213
Remote Config [baseline] (759.28 µs) : 0, 759
Remote Config [candidate] (754.234 µs) : 0, 754
Telemetry [baseline] (9.504 ms) : 0, 9504
Telemetry [candidate] (9.282 ms) : 0, 9282
Flare Poller [baseline] (3.897 ms) : 0, 3897
Flare Poller [candidate] (3.821 ms) : 0, 3821
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (791.671 ms) : 0, 791671
BytebuddyAgent [candidate] (794.25 ms) : 0, 794250
GlobalTracer [baseline] (255.187 ms) : 0, 255187
GlobalTracer [candidate] (257.604 ms) : 0, 257604
IAST [baseline] (26.776 ms) : 0, 26776
IAST [candidate] (27.233 ms) : 0, 27233
AppSec [baseline] (33.837 ms) : 0, 33837
AppSec [candidate] (33.531 ms) : 0, 33531
Debugger [baseline] (65.623 ms) : 0, 65623
Debugger [candidate] (66.392 ms) : 0, 66392
Remote Config [baseline] (592.498 µs) : 0, 592
Remote Config [candidate] (580.284 µs) : 0, 580
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (3.549 ms) : 0, 3549
Flare Poller [candidate] (3.566 ms) : 0, 3566
section profiling
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (701.557 ms) : 0, 701557
BytebuddyAgent [candidate] (707.054 ms) : 0, 707054
GlobalTracer [baseline] (220.018 ms) : 0, 220018
GlobalTracer [candidate] (222.549 ms) : 0, 222549
AppSec [baseline] (32.172 ms) : 0, 32172
AppSec [candidate] (32.414 ms) : 0, 32414
Debugger [baseline] (67.823 ms) : 0, 67823
Debugger [candidate] (68.396 ms) : 0, 68396
Remote Config [baseline] (639.11 µs) : 0, 639
Remote Config [candidate] (631.861 µs) : 0, 632
Telemetry [baseline] (8.823 ms) : 0, 8823
Telemetry [candidate] (8.937 ms) : 0, 8937
Flare Poller [baseline] (3.705 ms) : 0, 3705
Flare Poller [candidate] (3.758 ms) : 0, 3758
ProfilingAgent [baseline] (96.754 ms) : 0, 96754
ProfilingAgent [candidate] (96.629 ms) : 0, 96629
Profiling [baseline] (97.33 ms) : 0, 97330
Profiling [candidate] (97.199 ms) : 0, 97199
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (19.302 ms) : 19099, 19504
. : milestone, 19302,
appsec (18.657 ms) : 18465, 18849
. : milestone, 18657,
code_origins (17.461 ms) : 17286, 17636
. : milestone, 17461,
iast (17.856 ms) : 17675, 18036
. : milestone, 17856,
profiling (19.467 ms) : 19272, 19663
. : milestone, 19467,
tracing (17.698 ms) : 17519, 17876
. : milestone, 17698,
section candidate
no_agent (19.48 ms) : 19281, 19680
. : milestone, 19480,
appsec (18.663 ms) : 18473, 18852
. : milestone, 18663,
code_origins (18.129 ms) : 17952, 18306
. : milestone, 18129,
iast (17.774 ms) : 17598, 17949
. : milestone, 17774,
profiling (18.617 ms) : 18431, 18804
. : milestone, 18617,
tracing (17.519 ms) : 17345, 17694
. : milestone, 17519,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1170, 1193
. : milestone, 1181,
iast (3.107 ms) : 3068, 3146
. : milestone, 3107,
iast_FULL (5.531 ms) : 5475, 5586
. : milestone, 5531,
iast_GLOBAL (3.624 ms) : 3567, 3681
. : milestone, 3624,
profiling (1.929 ms) : 1913, 1945
. : milestone, 1929,
tracing (1.779 ms) : 1765, 1794
. : milestone, 1779,
section candidate
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.192 ms) : 3154, 3230
. : milestone, 3192,
iast_FULL (6.66 ms) : 6586, 6733
. : milestone, 6660,
iast_GLOBAL (3.482 ms) : 3430, 3535
. : milestone, 3482,
profiling (1.979 ms) : 1961, 1996
. : milestone, 1979,
tracing (1.835 ms) : 1819, 1850
. : milestone, 1835,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (15.423 s) : 15423000, 15423000
. : milestone, 15423000,
appsec (14.547 s) : 14547000, 14547000
. : milestone, 14547000,
iast (18.057 s) : 18057000, 18057000
. : milestone, 18057000,
iast_GLOBAL (17.932 s) : 17932000, 17932000
. : milestone, 17932000,
profiling (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
tracing (14.58 s) : 14580000, 14580000
. : milestone, 14580000,
section candidate
no_agent (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
appsec (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
iast (18.449 s) : 18449000, 18449000
. : milestone, 18449000,
iast_GLOBAL (17.826 s) : 17826000, 17826000
. : milestone, 17826000,
profiling (14.712 s) : 14712000, 14712000
. : milestone, 14712000,
tracing (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~5b77c73366, baseline=1.58.0-SNAPSHOT~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.669 ms) : 3454, 3885
. : milestone, 3669,
iast (2.22 ms) : 2155, 2284
. : milestone, 2220,
iast_GLOBAL (2.268 ms) : 2203, 2333
. : milestone, 2268,
profiling (2.508 ms) : 2345, 2671
. : milestone, 2508,
tracing (2.058 ms) : 2007, 2109
. : milestone, 2058,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.654 ms) : 3439, 3869
. : milestone, 3654,
iast (2.224 ms) : 2159, 2289
. : milestone, 2224,
iast_GLOBAL (2.269 ms) : 2204, 2334
. : milestone, 2269,
profiling (2.083 ms) : 2029, 2137
. : milestone, 2083,
tracing (2.059 ms) : 2008, 2111
. : milestone, 2059,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: telemetry error reported
Reported by error telemetry
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
The exitValue oft this advice might be null if an exception is thrown. This PR avoid having a NPE because we try to store a null value.
Fixes:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]