output supported versions #3058
Draft
+353
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| # note: This will only run when there *are* changes to integration versions | ||
| - name: Create Pull Request | ||
| id: pr | ||
| uses: peter-evans/create-pull-request@v6 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| if: ${{ github.event.workflow_run.conclusion == 'success' }} | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| @@ -0,0 +1,44 @@ | |||
| name: Supported Versions | |||
| on: | |||
| workflow_run: | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
Dangerous GitHub actions trigger (...read more)
Datadog ReportBranch report: ✅ 0 Failed, 5121 Passed, 70 Skipped, 2m 27.75s Total Time |
BenchmarksBenchmark execution time: 2024-12-26 23:54:51 Comparing candidate commit 827f52f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
quinna-h
commented
Dec 27, 2024
| func main() { | ||
| goModPath := "integration_go.mod" // path to integration_go.mod | ||
| outputPath := "supported_versions.md" | ||
| instrumentedSet := map[string]struct{}{ |
There was a problem hiding this comment.
quinna-h
commented
Jan 2, 2025
| @@ -42,15 +42,13 @@ require ( | |||
| github.com/gocql/gocql v1.6.0 | |||
| github.com/gofiber/fiber/v2 v2.52.5 | |||
| github.com/gomodule/redigo v1.8.9 | |||
| github.com/google/pprof v0.0.0-20230817174616-7a8ec2ada47b | |||
There was a problem hiding this comment.
Probably put these changes in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
.github/workflows/apps/output_integration_versions.gointegration_go.mod, and the maximum fromgo list -m -versions <package>Supported Versionsworkflow which runs only afterSmoke Testssuccessfully passes on mainSmoke Teststests thatddtraceworks with the latest versions of the packages. So if Smoke Tests passed, we can safely assume thatlatestworks.TODO:
Motivation
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!