Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/opentelemetry: fix flaky TestSpanResourceNameDefault #2509

Closed

Conversation

darccio
Copy link
Member

@darccio darccio commented Jan 16, 2024

What does this PR do?

(Tries to) fix TestSpanResourceNameDefault. A different take from #2503.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio changed the title ddtrace/opentelemetry: return empty JSON on GET request to httpmem se… ddtrace/opentelemetry: fix flaky TestSpanResourceNameDefault Jan 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2024

Benchmarks

Benchmark execution time: 2024-01-16 15:42:03

Comparing candidate commit c514e40 in PR branch dario.castane/fix-flaky-testspanresourcenamedefault with baseline commit 83844d4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@darccio darccio closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant