[Profiler] Add DD_PROFILING_HTTP_ENABLED env var configuration #6993

chrisnas · 2025-05-21T11:34:53Z

Summary of changes

Support DD_PROFILING_HTTP_ENABLED environment variable for configuration

Reason for change

Avoid making public internal environment variables such as DD_INTERNAL_PROFILING_HTTP_ENABLED

Implementation details

Take the new env var into account as an override of the internal one

Test coverage

Tests added

Other details

datadog-datadog-prod-us1 · 2025-05-21T12:08:01Z

Datadog Report

All test runs 364f8ba 🔗

❌ 2 Total Test Services: 1 Failed, 1 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
`dd-trace-dotnet`	1	0	0	245792	2918	17h 1m 53.37s	Link
`exploration_tests`	0	0	0	22085	3	2m 15.68s	Link

❌ Failed Tests (1)

NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.ServiceBusMinimalRebusTest - Details

Expand for error

 Expected exit code: 0, actual exit code: 134. Message: Unhandled exception. System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 35 - An internal exception was caught)
  ---> System.Net.Sockets.SocketException (00000001, 11): Resource temporarily unavailable
    at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily, Nullable\`1 startingTimestamp)
    at System.Net.Dns.GetHostAddresses(String hostNameOrAddress, AddressFamily family)
    at System.Data.SqlClient.SNI.SNITCPHandle.Connect(String serverName, Int32 port, TimeSpan timeout)
    at System.Data.SqlClient.SNI.SNITCPHandle..ctor(String serverName, Int32 port, Int64 timerExpire, Object callbackObject, Boolean parallel)
    at System.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, Object providerInfo, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling)
    at System.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
    at System.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
    at System.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
 ...

andrewlock · 2025-05-21T12:08:53Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6993) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6993) - mean (1,005ms)  : 988, 1023
     .   : milestone, 1005,
    master - mean (1,003ms)  : 976, 1030
     .   : milestone, 1003,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6993) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6993) - mean (693ms)  : 676, 710
     .   : milestone, 693,
    master - mean (695ms)  : 678, 712
     .   : milestone, 695,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6993) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6993) - mean (657ms)  : 634, 679
     .   : milestone, 657,
    master - mean (654ms)  : 634, 673
     .   : milestone, 654,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6993) - mean (190ms)  : 185, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6993) - mean (1,113ms)  : 1083, 1143
     .   : milestone, 1113,
    master - mean (1,113ms)  : 1087, 1140
     .   : milestone, 1113,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6993) - mean (269ms)  : 265, 273
     .   : milestone, 269,
    master - mean (269ms)  : 266, 272
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6993) - mean (880ms)  : 847, 912
     .   : milestone, 880,
    master - mean (878ms)  : 849, 906
     .   : milestone, 878,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6993) - mean (261ms)  : 258, 264
     .   : milestone, 261,
    master - mean (261ms)  : 258, 264
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6993) - mean (871ms)  : 835, 907
     .   : milestone, 871,
    master - mean (866ms)  : 832, 900
     .   : milestone, 866,

pr-commenter · 2025-05-21T12:25:53Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #6993 compared to master:

All benchmarks have the same speed
5 benchmarks have fewer allocations
4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6993

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	5.69 KB	5.75 KB	54 B	0.95%

Fewer allocations 🎉 in #6993

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.18 KB	6.1 KB	-82 B	-1.33%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	10.9μs	59ns	344ns	0	0	0	5.56 KB
master	`StartStopWithChild`	netcoreapp3.1	14.2μs	52.9ns	205ns	0	0	0	5.69 KB
master	`StartStopWithChild`	net472	21.7μs	120ns	699ns	0.896	0.224	0	6.18 KB
#6993	`StartStopWithChild`	net6.0	11μs	57.4ns	275ns	0	0	0	5.57 KB
#6993	`StartStopWithChild`	netcoreapp3.1	13.4μs	68.3ns	327ns	0	0	0	5.75 KB
#6993	`StartStopWithChild`	net472	22.7μs	123ns	748ns	1.06	0.422	0.106	6.1 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6993

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.33 KB	3.31 KB	-23 B	-0.69%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	934μs	69.1ns	239ns	2.71 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.03ms	43.8ns	170ns	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.26ms	727ns	2.81μs	3.33 KB
#6993	`WriteAndFlushEnrichedTraces`	net6.0	930μs	128ns	462ns	2.7 KB
#6993	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.03ms	529ns	2.05μs	2.7 KB
#6993	`WriteAndFlushEnrichedTraces`	net472	1.24ms	43.3ns	162ns	3.31 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	332μs	1.67μs	7.46μs	0	0	197.06 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	509μs	1.47μs	5.68μs	0	0	204.77 KB
master	`AllCycleSimpleBody`	net472	437μs	132ns	494ns	36.6	2.16	236.35 KB
master	`AllCycleMoreComplexBody`	net6.0	341μs	569ns	2.2μs	0	0	200.57 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	483μs	779ns	3.02μs	0	0	208.18 KB
master	`AllCycleMoreComplexBody`	net472	445μs	129ns	500ns	37.9	2.23	239.88 KB
master	`ObjectExtractorSimpleBody`	net6.0	309ns	0.101ns	0.38ns	0	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	406ns	2.24ns	13ns	0	0	272 B
master	`ObjectExtractorSimpleBody`	net472	302ns	0.0188ns	0.0652ns	0.044	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.33μs	28.9ns	116ns	0	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.65μs	38ns	161ns	0	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.79μs	1.09ns	4.24ns	0.578	0	3.8 KB
#6993	`AllCycleSimpleBody`	net6.0	332μs	1.33μs	4.98μs	0	0	197.06 KB
#6993	`AllCycleSimpleBody`	netcoreapp3.1	501μs	1.66μs	5.99μs	0	0	204.77 KB
#6993	`AllCycleSimpleBody`	net472	435μs	74.9ns	280ns	36.6	2.16	236.35 KB
#6993	`AllCycleMoreComplexBody`	net6.0	334μs	961ns	3.6μs	0	0	200.56 KB
#6993	`AllCycleMoreComplexBody`	netcoreapp3.1	486μs	2.31μs	8.93μs	0	0	208.18 KB
#6993	`AllCycleMoreComplexBody`	net472	445μs	95ns	368ns	36.6	2.16	239.87 KB
#6993	`ObjectExtractorSimpleBody`	net6.0	314ns	1.6ns	7.16ns	0	0	280 B
#6993	`ObjectExtractorSimpleBody`	netcoreapp3.1	392ns	2.1ns	10.7ns	0	0	272 B
#6993	`ObjectExtractorSimpleBody`	net472	305ns	0.0222ns	0.0859ns	0.044	0	281 B
#6993	`ObjectExtractorMoreComplexBody`	net6.0	6.26μs	3.42ns	12.8ns	0	0	3.78 KB
#6993	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.78μs	37.2ns	144ns	0	0	3.69 KB
#6993	`ObjectExtractorMoreComplexBody`	net472	6.66μs	1.53ns	5.71ns	0.601	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2
master	`EncodeArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`EncodeArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`EncodeArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`EncodeArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`EncodeLegacyArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`EncodeLegacyArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`EncodeLegacyArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN

Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2
master	`RunWafRealisticBenchmark`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmark`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmark`	net472	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`RunWafRealisticBenchmark`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`RunWafRealisticBenchmark`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`RunWafRealisticBenchmark`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`RunWafRealisticBenchmarkWithAttack`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#6993	`RunWafRealisticBenchmarkWithAttack`	net472	N/A	N/A	N/A	NaN	NaN	NaN

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	61.2μs	32.2ns	125ns	14.53 KB
master	`SendRequest`	netcoreapp3.1	70.4μs	114ns	426ns	17.42 KB
master	`SendRequest`	net472	0.00615ns	0.00198ns	0.00765ns	0 b
#6993	`SendRequest`	net6.0	61.2μs	59.6ns	231ns	14.53 KB
#6993	`SendRequest`	netcoreapp3.1	71.2μs	299ns	1.04μs	17.42 KB
#6993	`SendRequest`	net472	0.0132ns	0.0018ns	0.00698ns	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6993

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.75 KB	42.65 KB	895 B	2.14%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.8 KB	42.06 KB	261 B	0.62%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	653μs	3.14μs	12.2μs	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	726μs	3.89μs	28.3μs	0	41.8 KB
master	`WriteAndFlushEnrichedTraces`	net472	986μs	5.72μs	50.2μs	4.81	56.09 KB
#6993	`WriteAndFlushEnrichedTraces`	net6.0	671μs	3.57μs	18.2μs	0	42.65 KB
#6993	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	3.27μs	14.2μs	0	42.06 KB
#6993	`WriteAndFlushEnrichedTraces`	net472	988μs	5.58μs	37.8μs	4.46	55.97 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.95μs	1.32ns	4.94ns	0	0	1.03 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.41μs	10.2ns	38ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.66μs	2.6ns	10.1ns	0.146	0.0133	995 B
#6993	`ExecuteNonQuery`	net6.0	1.83μs	9.57ns	46.9ns	0	0	1.03 KB
#6993	`ExecuteNonQuery`	netcoreapp3.1	2.5μs	11.5ns	44.4ns	0	0	1.02 KB
#6993	`ExecuteNonQuery`	net472	2.72μs	2.65ns	10.3ns	0.149	0.0136	995 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.84μs	0.912ns	3.41ns	0	1.04 KB
master	`CallElasticsearch`	netcoreapp3.1	2.48μs	1.87ns	7ns	0	1.04 KB
master	`CallElasticsearch`	net472	3.59μs	1.95ns	7.54ns	0.162	1.05 KB
master	`CallElasticsearchAsync`	net6.0	1.83μs	5.79ns	22.4ns	0	1.02 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.39μs	2.71ns	10.5ns	0	1.09 KB
master	`CallElasticsearchAsync`	net472	3.81μs	2.73ns	10.6ns	0.175	1.11 KB
#6993	`CallElasticsearch`	net6.0	1.67μs	7.63ns	29.6ns	0	1.04 KB
#6993	`CallElasticsearch`	netcoreapp3.1	2.25μs	11.3ns	52.9ns	0	1.04 KB
#6993	`CallElasticsearch`	net472	3.52μs	4.52ns	17.5ns	0.161	1.05 KB
#6993	`CallElasticsearchAsync`	net6.0	1.91μs	3.76ns	14.1ns	0	1.02 KB
#6993	`CallElasticsearchAsync`	netcoreapp3.1	2.54μs	2.62ns	10.2ns	0	1.09 KB
#6993	`CallElasticsearchAsync`	net472	3.67μs	5.47ns	20.5ns	0.165	1.11 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.85μs	7.41ns	28.7ns	0	960 B
master	`ExecuteAsync`	netcoreapp3.1	2.35μs	7.17ns	27.8ns	0	960 B
master	`ExecuteAsync`	net472	2.77μs	7.52ns	29.1ns	0.14	923 B
#6993	`ExecuteAsync`	net6.0	1.79μs	5.49ns	21.3ns	0	960 B
#6993	`ExecuteAsync`	netcoreapp3.1	2.37μs	8.69ns	33.7ns	0	960 B
#6993	`ExecuteAsync`	net472	2.77μs	1.46ns	5.67ns	0.138	923 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	6.91μs	8.79ns	32.9ns	0	2.37 KB
master	`SendAsync`	netcoreapp3.1	8.46μs	18.7ns	72.6ns	0	2.9 KB
master	`SendAsync`	net472	12.3μs	10ns	37.6ns	0.489	3.19 KB
#6993	`SendAsync`	net6.0	7μs	11.5ns	44.6ns	0	2.37 KB
#6993	`SendAsync`	netcoreapp3.1	8.39μs	30.3ns	117ns	0	2.9 KB
#6993	`SendAsync`	net472	12μs	6.53ns	25.3ns	0.475	3.19 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6993

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	259.18 KB	274.53 KB	15.35 KB	5.92%

Fewer allocations 🎉 in #6993

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	43.25 KB	42.79 KB	-456 B	-1.05%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	44.76 KB	44.06 KB	-696 B	-1.55%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472	286.72 KB	278.53 KB	-8.19 KB	-2.86%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	44μs	478ns	4.51μs	44.76 KB
master	`StringConcatBenchmark`	netcoreapp3.1	50μs	291ns	2.38μs	43.25 KB
master	`StringConcatBenchmark`	net472	57.1μs	247ns	1.02μs	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	455μs	2.13μs	7.97μs	259.18 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	544μs	2.19μs	8.19μs	273.74 KB
master	`StringConcatAspectBenchmark`	net472	405μs	1.54μs	5.76μs	286.72 KB
#6993	`StringConcatBenchmark`	net6.0	44.9μs	261ns	2.13μs	44.06 KB
#6993	`StringConcatBenchmark`	netcoreapp3.1	49.1μs	271ns	1.58μs	42.79 KB
#6993	`StringConcatBenchmark`	net472	57.7μs	282ns	1.19μs	57.34 KB
#6993	`StringConcatAspectBenchmark`	net6.0	500μs	1.83μs	6.6μs	274.53 KB
#6993	`StringConcatAspectBenchmark`	netcoreapp3.1	529μs	2.52μs	10.7μs	273.42 KB
#6993	`StringConcatAspectBenchmark`	net472	405μs	2.18μs	11.5μs	278.53 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.59μs	13.4ns	62.9ns	0	1.76 KB
master	`EnrichedLog`	netcoreapp3.1	3.54μs	18.4ns	84.2ns	0	1.76 KB
master	`EnrichedLog`	net472	4.08μs	3.06ns	11.8ns	0.265	1.69 KB
#6993	`EnrichedLog`	net6.0	2.54μs	11.4ns	44.3ns	0	1.76 KB
#6993	`EnrichedLog`	netcoreapp3.1	3.49μs	12.4ns	47.9ns	0	1.76 KB
#6993	`EnrichedLog`	net472	4.1μs	3.59ns	13.9ns	0.267	1.69 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	124μs	133ns	499ns	4.37 KB
master	`EnrichedLog`	netcoreapp3.1	126μs	24.7ns	85.6ns	4.37 KB
master	`EnrichedLog`	net472	167μs	75.1ns	281ns	4.57 KB
#6993	`EnrichedLog`	net6.0	122μs	64.1ns	231ns	4.37 KB
#6993	`EnrichedLog`	netcoreapp3.1	127μs	48.7ns	176ns	4.37 KB
#6993	`EnrichedLog`	net472	166μs	150ns	563ns	4.57 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.9μs	4.18ns	16.2ns	0	2.32 KB
master	`EnrichedLog`	netcoreapp3.1	6.55μs	10.4ns	40.1ns	0	2.32 KB
master	`EnrichedLog`	net472	7.45μs	7.31ns	28.3ns	0.335	2.14 KB
#6993	`EnrichedLog`	net6.0	4.97μs	4.95ns	17.1ns	0	2.32 KB
#6993	`EnrichedLog`	netcoreapp3.1	6.68μs	13.7ns	52.9ns	0	2.32 KB
#6993	`EnrichedLog`	net472	7.56μs	6.15ns	23.8ns	0.339	2.14 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	2.02μs	9.2ns	36.8ns	0	1.21 KB
master	`SendReceive`	netcoreapp3.1	2.62μs	9.83ns	38.1ns	0	1.21 KB
master	`SendReceive`	net472	3.1μs	4.22ns	16.4ns	0.183	1.21 KB
#6993	`SendReceive`	net6.0	2.12μs	10.8ns	47ns	0	1.21 KB
#6993	`SendReceive`	netcoreapp3.1	2.59μs	11.2ns	38.7ns	0	1.21 KB
#6993	`SendReceive`	net472	3.11μs	3.39ns	12.2ns	0.184	1.21 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.1μs	11.8ns	44.1ns	0	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	5.65μs	21.3ns	82.3ns	0	1.69 KB
master	`EnrichedLog`	net472	6.71μs	5.05ns	18.9ns	0.302	2.08 KB
#6993	`EnrichedLog`	net6.0	4.16μs	10.1ns	39.1ns	0	1.64 KB
#6993	`EnrichedLog`	netcoreapp3.1	5.57μs	17ns	65.9ns	0	1.69 KB
#6993	`EnrichedLog`	net472	6.48μs	8.03ns	31.1ns	0.323	2.08 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	777ns	3.81ns	15.7ns	0	584 B
master	`StartFinishSpan`	netcoreapp3.1	951ns	0.333ns	1.29ns	0	584 B
master	`StartFinishSpan`	net472	926ns	0.193ns	0.723ns	0.0928	586 B
master	`StartFinishScope`	net6.0	892ns	0.425ns	1.59ns	0	704 B
master	`StartFinishScope`	netcoreapp3.1	1.17μs	5.63ns	22.5ns	0	704 B
master	`StartFinishScope`	net472	1.11μs	0.273ns	0.985ns	0.106	666 B
#6993	`StartFinishSpan`	net6.0	753ns	0.375ns	1.4ns	0	584 B
#6993	`StartFinishSpan`	netcoreapp3.1	919ns	5.11ns	28ns	0	584 B
#6993	`StartFinishSpan`	net472	907ns	0.236ns	0.85ns	0.0908	586 B
#6993	`StartFinishScope`	net6.0	901ns	4.88ns	22.3ns	0	704 B
#6993	`StartFinishScope`	netcoreapp3.1	1.1μs	5.66ns	27.1ns	0	704 B
#6993	`StartFinishScope`	net472	1.07μs	0.077ns	0.288ns	0.102	666 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.03μs	0.477ns	1.85ns	0	704 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.36μs	0.838ns	3.24ns	0	704 B
master	`RunOnMethodBegin`	net472	1.42μs	0.932ns	3.61ns	0.0991	666 B
#6993	`RunOnMethodBegin`	net6.0	1.04μs	5.04ns	21.4ns	0	704 B
#6993	`RunOnMethodBegin`	netcoreapp3.1	1.35μs	6.77ns	28.7ns	0	704 B
#6993	`RunOnMethodBegin`	net472	1.38μs	1.11ns	4.28ns	0.104	666 B

…nfig

Add DD_PROFILING_HTTP_ENABLED env var configuration

444f3b2

chrisnas requested a review from a team as a code owner May 21, 2025 11:34

github-actions bot added the area:profiler Issues related to the continous-profiler label May 21, 2025

Merge remote-tracking branch 'origin' into chrisnas/http_profiling_co…

364f8ba

…nfig

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Profiler] Add DD_PROFILING_HTTP_ENABLED env var configuration #6993

[Profiler] Add DD_PROFILING_HTTP_ENABLED env var configuration #6993

chrisnas commented May 21, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented May 21, 2025 •

edited

Loading

Uh oh!

andrewlock commented May 21, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented May 21, 2025 •

edited

Loading

More allocations ⚠️ in #6993

Fewer allocations 🎉 in #6993

Raw results

Fewer allocations 🎉 in #6993

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #6993

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #6993

Fewer allocations 🎉 in #6993

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

Uh oh!

[Profiler] Add DD_PROFILING_HTTP_ENABLED env var configuration #6993

Are you sure you want to change the base?

[Profiler] Add DD_PROFILING_HTTP_ENABLED env var configuration #6993

Conversation

chrisnas commented May 21, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-datadog-prod-us1 bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

❌ Failed Tests (1)

Uh oh!

andrewlock commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

pr-commenter bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

More allocations ⚠️ in #6993

Fewer allocations 🎉 in #6993

Raw results

Fewer allocations 🎉 in #6993

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #6993

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #6993

Fewer allocations 🎉 in #6993

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented May 21, 2025 •

edited

Loading

andrewlock commented May 21, 2025 •

edited

Loading

pr-commenter bot commented May 21, 2025 •

edited

Loading