Skip to content

[Test Package Versions Bump] Updating package versions #6988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Test Package Versions Bump] Updating package versions #6988

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners May 18, 2025 00:29
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 18, 2025 •
edited
Loading

Datadog Report

All test runs 2457f4e 🔗

❌ 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 72 0 0 250041 2256 16h 57m 14.6s Link
exploration_tests 0 0 0 22085 3 2m 12.95s Link

❌ Failed Tests (72)

This report shows up to 5 failed tests.

  • DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests - Details

    Expand for error 
     Expected logs to contain at least 7 item(s), but found 0: {empty}.
 Expected logs to contain only items matching (x.Service == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests)._serviceName), but the collection is empty.
 Expected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerTestsBase+<>c__DisplayClass4_0).hostName), but the collection is empty.
 Expected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
 Expected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
 Expected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
 Expected logs to contain only items matching (x.Exception == null), but the collection is empty.
 Expected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
 Expected logs to contain only items matching x.TryGetProperty("Category").Item1, but the collection is empty.
 Expected logs.Where(x => !x.Message.Contains("Waiting for app started handling requests")) to contain 7 item(s), but found 0: {empty}.
 ...

  • DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests - Details

    Expand for error 
     Expected logs to contain at least 12 item(s), but found 0: {empty}.
 Expected logs to contain only items matching (x.Service == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests)._serviceName), but the collection is empty.
 Expected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerTestsBase+<>c__DisplayClass4_0).hostName), but the collection is empty.
 Expected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
 Expected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
 Expected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
 Expected logs to contain only items matching (x.Exception == null), but the collection is empty.
 Expected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
 Expected logs to contain only items matching x.TryGetProperty("Category").Item1, but the collection is empty.
 Expected logs {empty} to have an item matching x.Message.Contains("Building pipeline").
 ...

  • DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests - Details

    Expand for error 
     Expected logs to contain at least 12 item(s), but found 0: {empty}.
 Expected logs to contain only items matching (x.Service == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests)._serviceName), but the collection is empty.
 Expected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerTestsBase+<>c__DisplayClass4_0).hostName), but the collection is empty.
 Expected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
 Expected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
 Expected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
 Expected logs to contain only items matching (x.Exception == null), but the collection is empty.
 Expected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
 Expected logs to contain only items matching x.TryGetProperty("Category").Item1, but the collection is empty.
 Expected logs {empty} to have an item matching x.Message.Contains("Building pipeline").
 ...

  • DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests - Details

    Expand for error 
     Expected logs to contain at least 7 item(s), but found 0: {empty}.
 Expected logs to contain only items matching (x.Service == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests)._serviceName), but the collection is empty.
 Expected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerTestsBase+<>c__DisplayClass4_0).hostName), but the collection is empty.
 Expected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
 Expected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
 Expected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
 Expected logs to contain only items matching (x.Exception == null), but the collection is empty.
 Expected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
 Expected logs to contain only items matching x.TryGetProperty("Category").Item1, but the collection is empty.
 Expected logs.Where(x => !x.Message.Contains("Waiting for app started handling requests")) to contain 7 item(s), but found 0: {empty}.
 ...

  • DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests - Details

    Expand for error 
     Expected logs to contain at least 12 item(s), but found 0: {empty}.
 Expected logs to contain only items matching (x.Service == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests)._serviceName), but the collection is empty.
 Expected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerTestsBase+<>c__DisplayClass4_0).hostName), but the collection is empty.
 Expected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
 Expected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
 Expected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
 Expected logs to contain only items matching (x.Exception == null), but the collection is empty.
 Expected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
 Expected logs to contain only items matching x.TryGetProperty("Category").Item1, but the collection is empty.
 Expected logs {empty} to have an item matching x.Message.Contains("Building pipeline").
 ...

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6988) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (72ms)  : 66, 78
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6988) - mean (1,010ms)  : 988, 1032
     .   : milestone, 1010,
    master - mean (1,030ms)  : 1000, 1061
     .   : milestone, 1030,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6988) - mean (103ms)  : 101, 105
     .   : milestone, 103,
    master - mean (110ms)  : 104, 116
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6988) - mean (693ms)  : 675, 711
     .   : milestone, 693,
    master - mean (722ms)  : 695, 749
     .   : milestone, 722,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6988) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (96ms)  : 91, 101
     .   : milestone, 96,

    section CallTarget+Inlining+NGEN
    This PR (6988) - mean (656ms)  : 639, 673
     .   : milestone, 656,
    master - mean (682ms)  : 650, 714
     .   : milestone, 682,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6988) - mean (189ms)  : 185, 193
     .   : milestone, 189,
    master - mean (188ms)  : 185, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (6988) - mean (1,109ms)  : 1083, 1135
     .   : milestone, 1109,
    master - mean (1,106ms)  : 1080, 1133
     .   : milestone, 1106,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6988) - mean (268ms)  : 265, 272
     .   : milestone, 268,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6988) - mean (876ms)  : 838, 913
     .   : milestone, 876,
    master - mean (878ms)  : 848, 907
     .   : milestone, 878,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6988) - mean (261ms)  : 256, 266
     .   : milestone, 261,
    master - mean (260ms)  : 257, 264
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (6988) - mean (864ms)  : 840, 889
     .   : milestone, 864,
    master - mean (868ms)  : 838, 897
     .   : milestone, 868,
Loading

andrewlock
andrewlock reviewed May 19, 2025
View reviewed changes
tracer/dependabot/Datadog.Dependabot.Integrations.csproj
Comment on lines +218 to +219
<!-- Latest package https://www.nuget.org/packages/Microsoft.Extensions.Telemetry/9.5.0 -->
<PackageReference Include="Microsoft.Extensions.Telemetry" Version="9.5.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has broken the current integration based on failing integration tests? Needs looking into

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New params in constructor: https://github.com/dotnet/extensions/pull/5635/files#diff-fe41c81f934acba2a6833c4ea862466b39858fc5e559ccf82263d57ce920a597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouwkast bouwkast bouwkast left review comments

@andrewlock andrewlock andrewlock left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @bouwkast