Skip to content

Merge debugger tests Windows. #6987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Merge debugger tests Windows. #6987

wants to merge 2 commits into from
+30 −18

Conversation

NachoEchevarria
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 16, 2025 •
edited
Loading

Datadog Report

All test runs 7b0ebb6 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
⌛ 1 with Regressions

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Performance Regressions Test Service View
dd-trace-dotnet 0 0 0 257995 3432 30h 51m 44.27s 2 Link
exploration_tests 0 0 0 7433 0 12m 8.51s 0 Link

⌛ Performance Regressions vs Default Branch (2)

  • Baseline_exception - scenarios 3.45s (+112.06ms, +3%) - Details
  • Profiler_exceptions - scenarios 3.4s (+69.08ms, +2%) - Details

@andrewlock
Copy link
Member

andrewlock commented May 16, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6987) - mean (68ms)  : 65, 70
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6987) - mean (1,008ms)  : 979, 1036
     .   : milestone, 1008,
    master - mean (1,006ms)  : 982, 1031
     .   : milestone, 1006,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6987) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6987) - mean (697ms)  : 675, 718
     .   : milestone, 697,
    master - mean (692ms)  : 676, 709
     .   : milestone, 692,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6987) - mean (89ms)  : 87, 92
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6987) - mean (655ms)  : 634, 676
     .   : milestone, 655,
    master - mean (652ms)  : 632, 672
     .   : milestone, 652,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6987) - mean (189ms)  : 186, 193
     .   : milestone, 189,
    master - mean (190ms)  : 186, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6987) - mean (1,107ms)  : 1085, 1128
     .   : milestone, 1107,
    master - mean (1,109ms)  : 1083, 1135
     .   : milestone, 1109,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6987) - mean (269ms)  : 265, 273
     .   : milestone, 269,
    master - mean (269ms)  : 264, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6987) - mean (878ms)  : 844, 912
     .   : milestone, 878,
    master - mean (877ms)  : 849, 905
     .   : milestone, 877,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6987) - mean (263ms)  : 256, 270
     .   : milestone, 263,
    master - mean (260ms)  : 257, 264
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (6987) - mean (868ms)  : 833, 903
     .   : milestone, 868,
    master - mean (869ms)  : 832, 906
     .   : milestone, 869,
Loading

@pr-commenter
Copy link

pr-commenter bot commented May 19, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #6987 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.209
  • 2 benchmarks are slower, with geometric mean 1.175
  • 1 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11μs 58.8ns 322ns 0 0 0 5.54 KB
master StartStopWithChild netcoreapp3.1 13.9μs 50.3ns 195ns 0 0 0 5.74 KB
master StartStopWithChild net472 22μs 90.9ns 328ns 1.01 0.336 0.112 6.14 KB
#6987 StartStopWithChild net6.0 10.3μs 58.4ns 378ns 0 0 0 5.57 KB
#6987 StartStopWithChild netcoreapp3.1 13.5μs 68.8ns 300ns 0 0 0 5.75 KB
#6987 StartStopWithChild net472 21.8μs 116ns 625ns 0.883 0.221 0 6.15 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6987

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.35 KB 46 B 1.39%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 937μs 113ns 423ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 108ns 373ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.24ms 45.9ns 172ns 0 0 0 3.31 KB
#6987 WriteAndFlushEnrichedTraces net6.0 933μs 60.1ns 225ns 0 0 0 2.71 KB
#6987 WriteAndFlushEnrichedTraces netcoreapp3.1 1.08ms 1.63μs 6.32μs 0 0 0 2.7 KB
#6987 WriteAndFlushEnrichedTraces net472 1.22ms 49.9ns 187ns 0 0 0 3.35 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 327μs 1.43μs 5.53μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 486μs 277ns 1.04μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 435μs 103ns 397ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 333μs 790ns 3.06μs 0 0 0 200.57 KB
master AllCycleMoreComplexBody netcoreapp3.1 492μs 1.12μs 4.33μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 445μs 117ns 438ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 312ns 0.0985ns 0.369ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 398ns 2.15ns 10.9ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 310ns 0.147ns 0.569ns 0.0437 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.31μs 30.6ns 133ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 32.1ns 124ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.79μs 8.01ns 31ns 0.574 0 0 3.8 KB
#6987 AllCycleSimpleBody net6.0 330μs 1.08μs 4.04μs 0 0 0 197.06 KB
#6987 AllCycleSimpleBody netcoreapp3.1 481μs 537ns 2.08μs 0 0 0 204.77 KB
#6987 AllCycleSimpleBody net472 439μs 532ns 2.06μs 36.6 2.16 0 236.35 KB
#6987 AllCycleMoreComplexBody net6.0 335μs 1.16μs 4.51μs 0 0 0 200.56 KB
#6987 AllCycleMoreComplexBody netcoreapp3.1 513μs 1.19μs 4.62μs 0 0 0 208.18 KB
#6987 AllCycleMoreComplexBody net472 444μs 126ns 456ns 36.6 2.16 0 239.87 KB
#6987 ObjectExtractorSimpleBody net6.0 311ns 1.48ns 6.12ns 0 0 0 280 B
#6987 ObjectExtractorSimpleBody netcoreapp3.1 401ns 1.99ns 8.23ns 0 0 0 272 B
#6987 ObjectExtractorSimpleBody net472 302ns 0.0216ns 0.0835ns 0.0441 0 0 281 B
#6987 ObjectExtractorMoreComplexBody net6.0 6.42μs 28.8ns 112ns 0 0 0 3.78 KB
#6987 ObjectExtractorMoreComplexBody netcoreapp3.1 7.81μs 9.8ns 38ns 0 0 0 3.69 KB
#6987 ObjectExtractorMoreComplexBody net472 6.69μs 3.54ns 13.7ns 0.571 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6987 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6987 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6987 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6987 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6987 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6987 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#6987 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6987 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6987 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#6987 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6987 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6987 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.4μs 36.2ns 135ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 71.8μs 351ns 1.45μs 0 0 0 17.51 KB
master SendRequest net472 0.0268ns 0.00138ns 0.00533ns 0 0 0 0 b
#6987 SendRequest net6.0 61.2μs 24.4ns 91.4ns 0 0 0 14.53 KB
#6987 SendRequest netcoreapp3.1 71.9μs 45.4ns 157ns 0 0 0 17.42 KB
#6987 SendRequest net472 0.0097ns 0.002ns 0.00773ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #6987

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.171 616,201.64 721,416.67

Faster 🎉 in #6987

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.209 700,309.01 579,094.42 bimodal

Fewer allocations 🎉 in #6987

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.56 KB 56.12 KB -442 B -0.78%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 616μs 1.5μs 5.83μs 0 0 0 41.67 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 694μs 4.06μs 37.2μs 0 0 0 41.97 KB
master WriteAndFlushEnrichedTraces net472 898μs 4.67μs 22.4μs 8.33 0 0 56.56 KB
#6987 WriteAndFlushEnrichedTraces net6.0 720μs 1.03μs 3.85μs 0 0 0 41.66 KB
#6987 WriteAndFlushEnrichedTraces netcoreapp3.1 579μs 744ns 2.68μs 0 0 0 42.03 KB
#6987 WriteAndFlushEnrichedTraces net472 846μs 3.26μs 12.2μs 8.33 0 0 56.12 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.96μs 1.93ns 7.24ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.46μs 5.6ns 21.7ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.71μs 2.91ns 11.3ns 0.149 0.0135 0 995 B
#6987 ExecuteNonQuery net6.0 1.98μs 9.19ns 36.8ns 0 0 0 1.03 KB
#6987 ExecuteNonQuery netcoreapp3.1 2.47μs 8.29ns 32.1ns 0 0 0 1.02 KB
#6987 ExecuteNonQuery net472 2.82μs 4.75ns 18.4ns 0.154 0.014 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.75μs 1.57ns 6.09ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.37μs 4.07ns 15.7ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.64μs 2.64ns 10.2ns 0.165 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.85μs 8.46ns 32.8ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 9.06ns 35.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.78μs 3.35ns 12.1ns 0.17 0 0 1.11 KB
#6987 CallElasticsearch net6.0 1.81μs 0.869ns 3.25ns 0 0 0 1.04 KB
#6987 CallElasticsearch netcoreapp3.1 2.31μs 3.49ns 13.1ns 0 0 0 1.04 KB
#6987 CallElasticsearch net472 3.58μs 8.1ns 31.4ns 0.16 0 0 1.05 KB
#6987 CallElasticsearchAsync net6.0 1.83μs 2.55ns 9.88ns 0 0 0 1.02 KB
#6987 CallElasticsearchAsync netcoreapp3.1 2.39μs 12.3ns 54.9ns 0 0 0 1.09 KB
#6987 CallElasticsearchAsync net472 3.74μs 4.57ns 17.1ns 0.17 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.85μs 0.824ns 3.19ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.31μs 6.5ns 24.3ns 0 0 0 960 B
master ExecuteAsync net472 2.57μs 1.62ns 6.26ns 0.142 0 0 923 B
#6987 ExecuteAsync net6.0 1.82μs 0.972ns 3.51ns 0 0 0 960 B
#6987 ExecuteAsync netcoreapp3.1 2.35μs 1.51ns 5.86ns 0 0 0 960 B
#6987 ExecuteAsync net472 2.69μs 1.12ns 4.36ns 0.135 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.97μs 15.3ns 59.1ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.4μs 10.5ns 40.6ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 7.47ns 28ns 0.492 0 0 3.19 KB
#6987 SendAsync net6.0 6.88μs 3.05ns 11.8ns 0 0 0 2.37 KB
#6987 SendAsync netcoreapp3.1 8.48μs 12.6ns 47.1ns 0 0 0 2.9 KB
#6987 SendAsync net472 12.3μs 11.5ns 43ns 0.489 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #6987

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.180 436,850.00 515,400.00

More allocations ⚠️ in #6987

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 279.91 KB 360.5 KB 80.58 KB 28.79%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 247.42 KB 283.58 KB 36.17 KB 14.62%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 272.74 KB 274.15 KB 1.42 KB 0.52%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.5μs 223ns 1.92μs 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 48.6μs 231ns 1.41μs 0 0 0 42.68 KB
master StringConcatBenchmark net472 56.8μs 103ns 373ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 437μs 2.18μs 9.26μs 0 0 0 247.42 KB
master StringConcatAspectBenchmark netcoreapp3.1 532μs 2.41μs 9.02μs 0 0 0 272.74 KB
master StringConcatAspectBenchmark net472 402μs 2.32μs 18.3μs 0 0 0 279.91 KB
#6987 StringConcatBenchmark net6.0 44.5μs 227ns 1.38μs 0 0 0 43.93 KB
#6987 StringConcatBenchmark netcoreapp3.1 48.7μs 272ns 1.65μs 0 0 0 42.68 KB
#6987 StringConcatBenchmark net472 57.3μs 262ns 1.01μs 0 0 0 57.34 KB
#6987 StringConcatAspectBenchmark net6.0 517μs 2.08μs 7.22μs 0 0 0 283.58 KB
#6987 StringConcatAspectBenchmark netcoreapp3.1 557μs 2.49μs 9.64μs 0 0 0 274.15 KB
#6987 StringConcatAspectBenchmark net472 407μs 2.15μs 10.9μs 0 0 0 360.5 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 5.8ns 22.5ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.48μs 11.3ns 43.6ns 0 0 0 1.76 KB
master EnrichedLog net472 3.91μs 2.7ns 10.1ns 0.254 0 0 1.69 KB
#6987 EnrichedLog net6.0 2.55μs 13.6ns 70.7ns 0 0 0 1.76 KB
#6987 EnrichedLog netcoreapp3.1 3.47μs 4.44ns 17.2ns 0 0 0 1.76 KB
#6987 EnrichedLog net472 3.87μs 1.68ns 6.28ns 0.254 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 93.5ns 350ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 128μs 540ns 1.95μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 90.7ns 351ns 0 0 0 4.57 KB
#6987 EnrichedLog net6.0 122μs 171ns 640ns 0 0 0 4.37 KB
#6987 EnrichedLog netcoreapp3.1 127μs 160ns 620ns 0 0 0 4.37 KB
#6987 EnrichedLog net472 168μs 136ns 526ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.06μs 3.52ns 13.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.68μs 16.1ns 62.3ns 0 0 0 2.32 KB
master EnrichedLog net472 7.43μs 5.66ns 21.2ns 0.336 0 0 2.14 KB
#6987 EnrichedLog net6.0 5.04μs 7.36ns 28.5ns 0 0 0 2.32 KB
#6987 EnrichedLog netcoreapp3.1 6.81μs 25.2ns 97.5ns 0 0 0 2.32 KB
#6987 EnrichedLog net472 7.26μs 8.38ns 32.4ns 0.327 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.01μs 10.1ns 42.7ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.59μs 9.98ns 38.7ns 0 0 0 1.21 KB
master SendReceive net472 3.13μs 2.23ns 8.62ns 0.188 0 0 1.21 KB
#6987 SendReceive net6.0 2μs 10.7ns 56.7ns 0 0 0 1.21 KB
#6987 SendReceive netcoreapp3.1 2.63μs 3.34ns 12.9ns 0 0 0 1.21 KB
#6987 SendReceive net472 3.1μs 2.87ns 11.1ns 0.184 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.26μs 3.63ns 13.6ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.66μs 10.6ns 40.9ns 0 0 0 1.69 KB
master EnrichedLog net472 6.58μs 5.09ns 19.7ns 0.327 0 0 2.08 KB
#6987 EnrichedLog net6.0 4.23μs 3.18ns 11.9ns 0 0 0 1.64 KB
#6987 EnrichedLog netcoreapp3.1 5.55μs 16.3ns 63.1ns 0 0 0 1.69 KB
#6987 EnrichedLog net472 6.56μs 8.28ns 32.1ns 0.328 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 746ns 3.28ns 12.7ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 945ns 1ns 3.88ns 0 0 0 584 B
master StartFinishSpan net472 941ns 0.51ns 1.98ns 0.0897 0 0 586 B
master StartFinishScope net6.0 896ns 0.334ns 1.25ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.16μs 5.55ns 22.2ns 0 0 0 704 B
master StartFinishScope net472 1.19μs 0.357ns 1.29ns 0.101 0 0 666 B
#6987 StartFinishSpan net6.0 753ns 3.91ns 21.4ns 0 0 0 584 B
#6987 StartFinishSpan netcoreapp3.1 923ns 4.82ns 24.1ns 0 0 0 584 B
#6987 StartFinishSpan net472 926ns 2.8ns 10.8ns 0.0913 0 0 586 B
#6987 StartFinishScope net6.0 930ns 0.497ns 1.86ns 0 0 0 704 B
#6987 StartFinishScope netcoreapp3.1 1.21μs 5.89ns 25.7ns 0 0 0 704 B
#6987 StartFinishScope net472 1.1μs 0.116ns 0.433ns 0.105 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 4.9ns 20.2ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.41μs 6.94ns 28.6ns 0 0 0 704 B
master RunOnMethodBegin net472 1.39μs 1.47ns 5.7ns 0.105 0 0 666 B
#6987 RunOnMethodBegin net6.0 1.04μs 5.65ns 22.6ns 0 0 0 704 B
#6987 RunOnMethodBegin netcoreapp3.1 1.44μs 1.81ns 7.01ns 0 0 0 704 B
#6987 RunOnMethodBegin net472 1.36μs 0.732ns 2.83ns 0.102 0 0 666 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoEchevarria @andrewlock