Skip to content

Add net8.0 and net9.0 to trimming nuspec #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Add net8.0 and net9.0 to trimming nuspec #6983

merged 1 commit into from
May 29, 2025

Conversation

bouwkast
Copy link
Collaborator

Summary of changes

Adds net8.0 and net9.0 to trimming nuspec file.

Reason for change

Seems strange to have the others declared and was asked if we support those later ones which we do.

Implementation details

Test coverage

Other details

I'm actually unsure why we have a nuspec for this

@bouwkast bouwkast requested a review from a team as a code owner May 16, 2025 12:42
@pr-commenter
Copy link

pr-commenter bot commented May 16, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #99 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.137
  • 1 benchmarks are slower, with geometric mean 1.177
  • 2 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.6μs 58.6ns 375ns 0 0 0 5.54 KB
master StartStopWithChild netcoreapp3.1 13.5μs 63.2ns 261ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.3μs 119ns 604ns 0.966 0.215 0 6.19 KB
#99 StartStopWithChild net6.0 11.1μs 59.3ns 340ns 0 0 0 5.53 KB
#99 StartStopWithChild netcoreapp3.1 14.1μs 67.4ns 270ns 0 0 0 5.74 KB
#99 StartStopWithChild net472 22.3μs 102ns 381ns 1.06 0.319 0.106 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 942μs 390ns 1.51μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 422ns 1.63μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.23ms 76.7ns 287ns 0 0 0 3.31 KB
#99 WriteAndFlushEnrichedTraces net6.0 927μs 217ns 841ns 0 0 0 2.71 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 37.8ns 136ns 0 0 0 2.7 KB
#99 WriteAndFlushEnrichedTraces net472 1.23ms 44.6ns 167ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 309ns 1.2μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 513μs 1.58μs 5.91μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 441μs 130ns 488ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.7μs 7.22μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 505μs 992ns 3.84μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 451μs 132ns 511ns 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 327ns 0.119ns 0.429ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 398ns 2.12ns 10.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 301ns 0.0316ns 0.118ns 0.0445 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.26μs 30.1ns 131ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.8μs 33.3ns 129ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.67μs 3.49ns 13.5ns 0.601 0 0 3.8 KB
#99 AllCycleSimpleBody net6.0 338μs 224ns 837ns 0 0 0 197.06 KB
#99 AllCycleSimpleBody netcoreapp3.1 515μs 2.15μs 8.31μs 0 0 0 204.77 KB
#99 AllCycleSimpleBody net472 436μs 208ns 805ns 36.6 2.16 0 236.35 KB
#99 AllCycleMoreComplexBody net6.0 341μs 655ns 2.54μs 0 0 0 200.56 KB
#99 AllCycleMoreComplexBody netcoreapp3.1 497μs 1.52μs 5.9μs 0 0 0 208.18 KB
#99 AllCycleMoreComplexBody net472 445μs 154ns 554ns 37.9 2.23 0 239.88 KB
#99 ObjectExtractorSimpleBody net6.0 313ns 1.59ns 7.44ns 0 0 0 280 B
#99 ObjectExtractorSimpleBody netcoreapp3.1 396ns 2.15ns 12.6ns 0 0 0 272 B
#99 ObjectExtractorSimpleBody net472 302ns 0.05ns 0.194ns 0.0441 0 0 281 B
#99 ObjectExtractorMoreComplexBody net6.0 6.25μs 31.9ns 156ns 0 0 0 3.78 KB
#99 ObjectExtractorMoreComplexBody netcoreapp3.1 7.81μs 26.7ns 103ns 0 0 0 3.69 KB
#99 ObjectExtractorMoreComplexBody net472 6.75μs 3.11ns 12ns 0.576 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.3μs 54.3ns 203ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 72.2μs 164ns 615ns 0 0 0 17.42 KB
master SendRequest net472 0.0164ns 0.00183ns 0.0071ns 0 0 0 0 b
#99 SendRequest net6.0 61.4μs 152ns 589ns 0 0 0 14.53 KB
#99 SendRequest netcoreapp3.1 71μs 79.5ns 308ns 0 0 0 17.42 KB
#99 SendRequest net472 0.00523ns 0.00135ns 0.00524ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #99

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.177 709,219.20 834,883.55

Faster 🎉 in #99

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.143 1,066,622.08 933,033.04
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.130 740,434.72 655,002.08

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.88 KB 42.61 KB 730 B 1.74%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 733μs 3.56μs 14.7μs 0 0 0 41.76 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 709μs 564ns 2.18μs 0 0 0 41.88 KB
master WriteAndFlushEnrichedTraces net472 1.07ms 5.44μs 24.9μs 8.33 0 0 56.29 KB
#99 WriteAndFlushEnrichedTraces net6.0 655μs 727ns 2.82μs 0 0 0 41.64 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 785μs 9.2μs 89.2μs 0 0 0 42.61 KB
#99 WriteAndFlushEnrichedTraces net472 916μs 5.33μs 47.1μs 4.46 0 0 56.12 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.95μs 7.22ns 28ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.51μs 10.7ns 37ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.72μs 3.15ns 12.2ns 0.15 0.0136 0 995 B
#99 ExecuteNonQuery net6.0 1.99μs 8.55ns 32ns 0 0 0 1.03 KB
#99 ExecuteNonQuery netcoreapp3.1 2.54μs 12.2ns 48.8ns 0 0 0 1.02 KB
#99 ExecuteNonQuery net472 2.72μs 2.83ns 11ns 0.151 0.0137 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.71μs 7.74ns 30ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.39μs 6.99ns 27.1ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.61μs 6.75ns 26.1ns 0.161 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.77μs 9.07ns 41.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.39μs 11.2ns 44.8ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.81μs 5.68ns 22ns 0.17 0 0 1.11 KB
#99 CallElasticsearch net6.0 1.87μs 8.14ns 31.5ns 0 0 0 1.04 KB
#99 CallElasticsearch netcoreapp3.1 2.34μs 3ns 11.2ns 0 0 0 1.04 KB
#99 CallElasticsearch net472 3.54μs 3.09ns 12ns 0.16 0 0 1.05 KB
#99 CallElasticsearchAsync net6.0 1.76μs 9.4ns 47ns 0 0 0 1.02 KB
#99 CallElasticsearchAsync netcoreapp3.1 2.41μs 12ns 52.5ns 0 0 0 1.09 KB
#99 CallElasticsearchAsync net472 3.6μs 4.31ns 16.1ns 0.161 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.79μs 8.84ns 38.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.37μs 9.06ns 35.1ns 0 0 0 960 B
master ExecuteAsync net472 2.61μs 8.2ns 31.7ns 0.139 0 0 923 B
#99 ExecuteAsync net6.0 1.83μs 8.29ns 32.1ns 0 0 0 960 B
#99 ExecuteAsync netcoreapp3.1 2.36μs 6ns 22.5ns 0 0 0 960 B
#99 ExecuteAsync net472 2.64μs 4.44ns 17.2ns 0.146 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.94μs 7.01ns 26.2ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.74μs 35.9ns 139ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 13.7ns 52.9ns 0.489 0 0 3.19 KB
#99 SendAsync net6.0 7.01μs 6.71ns 24.2ns 0 0 0 2.37 KB
#99 SendAsync netcoreapp3.1 8.6μs 23.3ns 87ns 0 0 0 2.9 KB
#99 SendAsync net472 12.1μs 16.6ns 64.3ns 0.483 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 255.13 KB 277.46 KB 22.34 KB 8.75%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.6 KB 44.13 KB 528 B 1.21%

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 51.5μs 676ns 6.76μs 0 0 0 43.6 KB
master StringConcatBenchmark netcoreapp3.1 52.2μs 515ns 4.94μs 0 0 0 42.84 KB
master StringConcatBenchmark net472 57μs 192ns 719ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 443μs 1.34μs 4.65μs 0 0 0 256.3 KB
master StringConcatAspectBenchmark netcoreapp3.1 493μs 2.46μs 10.7μs 0 0 0 255.13 KB
master StringConcatAspectBenchmark net472 412μs 1.36μs 5.26μs 0 0 0 286.72 KB
#99 StringConcatBenchmark net6.0 49.6μs 607ns 5.98μs 0 0 0 44.13 KB
#99 StringConcatBenchmark netcoreapp3.1 49.6μs 291ns 2.67μs 0 0 0 42.92 KB
#99 StringConcatBenchmark net472 57μs 247ns 957ns 0 0 0 57.34 KB
#99 StringConcatAspectBenchmark net6.0 448μs 1.17μs 4.23μs 0 0 0 256 KB
#99 StringConcatAspectBenchmark netcoreapp3.1 538μs 2.26μs 8.14μs 0 0 0 277.46 KB
#99 StringConcatAspectBenchmark net472 406μs 2.32μs 17.7μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.54μs 13ns 62.3ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.39μs 17.2ns 82.5ns 0 0 0 1.76 KB
master EnrichedLog net472 3.9μs 2.07ns 7.16ns 0.255 0 0 1.69 KB
#99 EnrichedLog net6.0 2.65μs 5.93ns 23ns 0 0 0 1.76 KB
#99 EnrichedLog netcoreapp3.1 3.53μs 15.6ns 60.4ns 0 0 0 1.76 KB
#99 EnrichedLog net472 3.9μs 3.37ns 13.1ns 0.253 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 59.4ns 206ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 222ns 830ns 0 0 0 4.37 KB
master EnrichedLog net472 165μs 136ns 526ns 0 0 0 4.57 KB
#99 EnrichedLog net6.0 123μs 140ns 522ns 0 0 0 4.37 KB
#99 EnrichedLog netcoreapp3.1 127μs 247ns 925ns 0 0 0 4.37 KB
#99 EnrichedLog net472 167μs 166ns 645ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.03μs 4.04ns 15.1ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.56μs 22.3ns 86.3ns 0 0 0 2.32 KB
master EnrichedLog net472 7.52μs 7.63ns 29.5ns 0.339 0 0 2.14 KB
#99 EnrichedLog net6.0 5.12μs 3.69ns 14.3ns 0 0 0 2.32 KB
#99 EnrichedLog netcoreapp3.1 6.84μs 21ns 81.3ns 0 0 0 2.32 KB
#99 EnrichedLog net472 7.4μs 8.11ns 31.4ns 0.33 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.94μs 9.87ns 50.3ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.56μs 12.5ns 54.7ns 0 0 0 1.21 KB
master SendReceive net472 3.05μs 3.72ns 13.9ns 0.183 0 0 1.21 KB
#99 SendReceive net6.0 1.99μs 10.1ns 47.5ns 0 0 0 1.21 KB
#99 SendReceive netcoreapp3.1 2.67μs 3.6ns 13ns 0 0 0 1.21 KB
#99 SendReceive net472 3.05μs 2.31ns 8.64ns 0.182 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.17μs 11.9ns 46.2ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.82μs 5.38ns 20.8ns 0 0 0 1.69 KB
master EnrichedLog net472 6.57μs 5.55ns 21.5ns 0.327 0 0 2.08 KB
#99 EnrichedLog net6.0 4.15μs 12.2ns 47.1ns 0 0 0 1.64 KB
#99 EnrichedLog netcoreapp3.1 5.86μs 14ns 54.4ns 0 0 0 1.69 KB
#99 EnrichedLog net472 6.48μs 4.42ns 17.1ns 0.322 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 739ns 3.16ns 12.2ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 939ns 0.37ns 1.43ns 0 0 0 584 B
master StartFinishSpan net472 930ns 0.266ns 0.96ns 0.0926 0 0 586 B
master StartFinishScope net6.0 902ns 0.578ns 2.24ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.21μs 4.52ns 17.5ns 0 0 0 704 B
master StartFinishScope net472 1.14μs 0.457ns 1.77ns 0.102 0 0 666 B
#99 StartFinishSpan net6.0 743ns 2.41ns 9.33ns 0 0 0 584 B
#99 StartFinishSpan netcoreapp3.1 952ns 4.95ns 23.7ns 0 0 0 584 B
#99 StartFinishSpan net472 912ns 0.294ns 1.1ns 0.0923 0 0 586 B
#99 StartFinishScope net6.0 883ns 0.344ns 1.33ns 0 0 0 704 B
#99 StartFinishScope netcoreapp3.1 1.26μs 6.29ns 28.1ns 0 0 0 704 B
#99 StartFinishScope net472 1.12μs 0.275ns 1.06ns 0.102 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.01μs 5.51ns 30.2ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.36μs 5.89ns 22.8ns 0 0 0 704 B
master RunOnMethodBegin net472 1.39μs 3.81ns 14.8ns 0.102 0 0 666 B
#99 RunOnMethodBegin net6.0 1.03μs 1.06ns 4.1ns 0 0 0 704 B
#99 RunOnMethodBegin netcoreapp3.1 1.35μs 5.7ns 22.1ns 0 0 0 704 B
#99 RunOnMethodBegin net472 1.38μs 0.802ns 3.11ns 0.104 0 0 666 B

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 16, 2025 •
edited
Loading

Datadog Report

All test runs 944e816 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 252336 2323 17h 49m 43.4s Link
exploration_tests 0 0 0 22085 3 2m 8.55s Link

andrewlock
andrewlock approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Interesting. This definitely looks like something we need to keep an eye out for in the future... I wonder if it just means trimming wasn't working for .NET 8/9 🤔 but we have tests for that so.... 🤷‍♂️

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6983) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 64, 72
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6983) - mean (1,008ms)  : 980, 1036
     .   : milestone, 1008,
    master - mean (1,007ms)  : 977, 1037
     .   : milestone, 1007,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6983) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 99, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6983) - mean (694ms)  : 678, 710
     .   : milestone, 694,
    master - mean (690ms)  : 667, 713
     .   : milestone, 690,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6983) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6983) - mean (650ms)  : 632, 669
     .   : milestone, 650,
    master - mean (657ms)  : 636, 678
     .   : milestone, 657,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6983) - mean (189ms)  : 185, 193
     .   : milestone, 189,
    master - mean (188ms)  : 184, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (6983) - mean (1,109ms)  : 1081, 1137
     .   : milestone, 1109,
    master - mean (1,107ms)  : 1086, 1128
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6983) - mean (268ms)  : 263, 273
     .   : milestone, 268,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6983) - mean (873ms)  : 847, 899
     .   : milestone, 873,
    master - mean (877ms)  : 838, 916
     .   : milestone, 877,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6983) - mean (261ms)  : 257, 264
     .   : milestone, 261,
    master - mean (260ms)  : 258, 263
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (6983) - mean (862ms)  : 830, 895
     .   : milestone, 862,
    master - mean (865ms)  : 838, 892
     .   : milestone, 865,
Loading

@bouwkast bouwkast merged commit 559cb26 into master May 29, 2025
66 of 69 checks passed
@bouwkast bouwkast deleted the steven/nuspec branch May 29, 2025 13:39
@github-actions github-actions bot added this to the vNext-v3 milestone May 29, 2025
lucaspimentel
lucaspimentel reviewed May 29, 2025
View reviewed changes
tracer/src/Datadog.Trace.Trimming/Datadog.Trace.Trimming.nuspec
@@ -19,6 +19,8 @@
<tags>Datadog APM tracing profiling instrumentation trimming</tags>
<repository type="git" url="https://github.com/DataDog/dd-trace-dotnet.git" />
<dependencies>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need the <dependencies> element at all, since we have no dependencies (they are all empty).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel left review comments

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bouwkast @andrewlock @lucaspimentel