Skip to content

Pin shared pipeline #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pin shared pipeline #6965

wants to merge 1 commit into from

Conversation

TonyCTHsu
Copy link
Contributor

Summary of changes

Pin a version to shared pipeline to provide consistent result.

Reason for change

Use project and ref for explicity

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner May 13, 2025 11:08
andrewlock
andrewlock approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 I'll take your word for it, but this also bumps the ref, shouldn't we stick to what we have already?

@andrewlock
Copy link
Member

andrewlock commented May 13, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6965) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6965) - mean (1,007ms)  : 981, 1033
     .   : milestone, 1007,
    master - mean (1,008ms)  : 982, 1034
     .   : milestone, 1008,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6965) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6965) - mean (690ms)  : 670, 710
     .   : milestone, 690,
    master - mean (693ms)  : 673, 714
     .   : milestone, 693,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6965) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6965) - mean (653ms)  : 633, 673
     .   : milestone, 653,
    master - mean (658ms)  : 632, 683
     .   : milestone, 658,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6965) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (189ms)  : 185, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6965) - mean (1,110ms)  : 1088, 1131
     .   : milestone, 1110,
    master - mean (1,107ms)  : 1080, 1133
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6965) - mean (268ms)  : 264, 272
     .   : milestone, 268,
    master - mean (268ms)  : 264, 271
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6965) - mean (872ms)  : 841, 904
     .   : milestone, 872,
    master - mean (873ms)  : 840, 905
     .   : milestone, 873,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6965) - mean (261ms)  : 257, 265
     .   : milestone, 261,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6965) - mean (867ms)  : 838, 896
     .   : milestone, 867,
    master - mean (868ms)  : 834, 902
     .   : milestone, 868,
Loading

@andrewlock andrewlock self-requested a review May 13, 2025 16:05
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/pin-shared-pipeline branch from c3252e8 to 9313c80 Compare May 16, 2025 10:22
andrewlock
andrewlock approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 16, 2025 •
edited
Loading

Datadog Report

Branch report: tonycthsu/pin-shared-pipeline
Commit report: 9313c80
Test service: dd-trace-dotnet

❌ 1 Failed (0 Known Flaky), 249247 Passed, 2325 Skipped, 17h 40m 37.16s Total Time

❌ Failed Tests (1)

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.Elasticsearch7Tests - Details

    Expand for error 
     Expected exit code: 0, actual exit code: 139.

@pr-commenter
Copy link

pr-commenter bot commented May 16, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #6965 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.193
  • 2 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6965

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.19 KB 6.1 KB -90 B -1.46%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.6μs 58.6ns 375ns 0 0 0 5.54 KB
master StartStopWithChild netcoreapp3.1 13.5μs 63.2ns 261ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.3μs 119ns 604ns 0.966 0.215 0 6.19 KB
#6965 StartStopWithChild net6.0 10.8μs 59.9ns 365ns 0 0 0 5.56 KB
#6965 StartStopWithChild netcoreapp3.1 13.3μs 71ns 355ns 0 0 0 5.75 KB
#6965 StartStopWithChild net472 21.9μs 121ns 737ns 0.992 0.298 0.0992 6.1 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 942μs 390ns 1.51μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 422ns 1.63μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.23ms 76.7ns 287ns 0 0 0 3.31 KB
#6965 WriteAndFlushEnrichedTraces net6.0 938μs 60.1ns 225ns 0 0 0 2.7 KB
#6965 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 343ns 1.29μs 0 0 0 2.7 KB
#6965 WriteAndFlushEnrichedTraces net472 1.23ms 44.4ns 166ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 309ns 1.2μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 513μs 1.58μs 5.91μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 441μs 130ns 488ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.7μs 7.22μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 505μs 992ns 3.84μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 451μs 132ns 511ns 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 327ns 0.119ns 0.429ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 398ns 2.12ns 10.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 301ns 0.0316ns 0.118ns 0.0445 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.26μs 30.1ns 131ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.8μs 33.3ns 129ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.67μs 3.49ns 13.5ns 0.601 0 0 3.8 KB
#6965 AllCycleSimpleBody net6.0 327μs 946ns 3.41μs 0 0 0 197.06 KB
#6965 AllCycleSimpleBody netcoreapp3.1 520μs 1.63μs 6.31μs 0 0 0 204.77 KB
#6965 AllCycleSimpleBody net472 437μs 130ns 469ns 36.6 2.16 0 236.35 KB
#6965 AllCycleMoreComplexBody net6.0 342μs 1.43μs 5.36μs 0 0 0 200.57 KB
#6965 AllCycleMoreComplexBody netcoreapp3.1 480μs 1.03μs 3.99μs 0 0 0 208.18 KB
#6965 AllCycleMoreComplexBody net472 446μs 169ns 654ns 37.9 2.23 0 239.88 KB
#6965 ObjectExtractorSimpleBody net6.0 317ns 1.7ns 8.98ns 0 0 0 280 B
#6965 ObjectExtractorSimpleBody netcoreapp3.1 402ns 1.9ns 7.83ns 0 0 0 272 B
#6965 ObjectExtractorSimpleBody net472 303ns 0.0584ns 0.219ns 0.0433 0 0 281 B
#6965 ObjectExtractorMoreComplexBody net6.0 6.31μs 28.2ns 109ns 0 0 0 3.78 KB
#6965 ObjectExtractorMoreComplexBody netcoreapp3.1 7.77μs 29.3ns 114ns 0 0 0 3.69 KB
#6965 ObjectExtractorMoreComplexBody net472 6.7μs 8.44ns 32.7ns 0.602 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6965 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6965 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6965 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6965 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6965 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6965 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#6965 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6965 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6965 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#6965 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6965 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6965 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.3μs 54.3ns 203ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 72.2μs 164ns 615ns 0 0 0 17.42 KB
master SendRequest net472 0.0164ns 0.00183ns 0.0071ns 0 0 0 0 b
#6965 SendRequest net6.0 60.7μs 48.4ns 168ns 0 0 0 14.53 KB
#6965 SendRequest netcoreapp3.1 72.5μs 393ns 2.15μs 0 0 0 17.42 KB
#6965 SendRequest net472 0.0178ns 0.00132ns 0.00494ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #6965

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.216 1,066,622.08 877,455.42
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.170 740,434.72 632,641.72

More allocations ⚠️ in #6965

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.88 KB 42.11 KB 225 B 0.54%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 733μs 3.56μs 14.7μs 0 0 0 41.76 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 709μs 564ns 2.18μs 0 0 0 41.88 KB
master WriteAndFlushEnrichedTraces net472 1.07ms 5.44μs 24.9μs 8.33 0 0 56.29 KB
#6965 WriteAndFlushEnrichedTraces net6.0 634μs 1.52μs 5.67μs 0 0 0 41.86 KB
#6965 WriteAndFlushEnrichedTraces netcoreapp3.1 674μs 805ns 3.12μs 0 0 0 42.11 KB
#6965 WriteAndFlushEnrichedTraces net472 878μs 2.13μs 8.25μs 8.33 0 0 56.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.95μs 7.22ns 28ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.51μs 10.7ns 37ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.72μs 3.15ns 12.2ns 0.15 0.0136 0 995 B
#6965 ExecuteNonQuery net6.0 1.95μs 2.64ns 10.2ns 0 0 0 1.03 KB
#6965 ExecuteNonQuery netcoreapp3.1 2.42μs 2.13ns 8.23ns 0 0 0 1.02 KB
#6965 ExecuteNonQuery net472 2.74μs 2.22ns 8.6ns 0.15 0.0136 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.71μs 7.74ns 30ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.39μs 6.99ns 27.1ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.61μs 6.75ns 26.1ns 0.161 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.77μs 9.07ns 41.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.39μs 11.2ns 44.8ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.81μs 5.68ns 22ns 0.17 0 0 1.11 KB
#6965 CallElasticsearch net6.0 1.74μs 7.82ns 30.3ns 0 0 0 1.04 KB
#6965 CallElasticsearch netcoreapp3.1 2.47μs 2.2ns 8.25ns 0 0 0 1.04 KB
#6965 CallElasticsearch net472 3.6μs 1.64ns 6.35ns 0.162 0 0 1.05 KB
#6965 CallElasticsearchAsync net6.0 1.75μs 8.82ns 37.4ns 0 0 0 1.02 KB
#6965 CallElasticsearchAsync netcoreapp3.1 2.51μs 2.51ns 9.71ns 0 0 0 1.09 KB
#6965 CallElasticsearchAsync net472 3.72μs 0.807ns 2.91ns 0.168 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.79μs 8.84ns 38.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.37μs 9.06ns 35.1ns 0 0 0 960 B
master ExecuteAsync net472 2.61μs 8.2ns 31.7ns 0.139 0 0 923 B
#6965 ExecuteAsync net6.0 1.76μs 0.772ns 2.78ns 0 0 0 960 B
#6965 ExecuteAsync netcoreapp3.1 2.38μs 7.62ns 28.5ns 0 0 0 960 B
#6965 ExecuteAsync net472 2.61μs 1.82ns 7.03ns 0.144 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.94μs 7.01ns 26.2ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.74μs 35.9ns 139ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 13.7ns 52.9ns 0.489 0 0 3.19 KB
#6965 SendAsync net6.0 7.03μs 5.59ns 20.2ns 0 0 0 2.37 KB
#6965 SendAsync netcoreapp3.1 8.63μs 22.1ns 85.5ns 0 0 0 2.9 KB
#6965 SendAsync net472 12.6μs 10.3ns 39.8ns 0.506 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6965

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 256.3 KB 279.87 KB 23.57 KB 9.20%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 255.13 KB 257.66 KB 2.54 KB 0.99%

Fewer allocations 🎉 in #6965

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 51.5μs 676ns 6.76μs 0 0 0 43.6 KB
master StringConcatBenchmark netcoreapp3.1 52.2μs 515ns 4.94μs 0 0 0 42.84 KB
master StringConcatBenchmark net472 57μs 192ns 719ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 443μs 1.34μs 4.65μs 0 0 0 256.3 KB
master StringConcatAspectBenchmark netcoreapp3.1 493μs 2.46μs 10.7μs 0 0 0 255.13 KB
master StringConcatAspectBenchmark net472 412μs 1.36μs 5.26μs 0 0 0 286.72 KB
#6965 StringConcatBenchmark net6.0 42.1μs 175ns 629ns 0 0 0 43.53 KB
#6965 StringConcatBenchmark netcoreapp3.1 49.5μs 285ns 2.11μs 0 0 0 42.8 KB
#6965 StringConcatBenchmark net472 57μs 230ns 831ns 0 0 0 65.54 KB
#6965 StringConcatAspectBenchmark net6.0 478μs 1.2μs 4.15μs 0 0 0 279.87 KB
#6965 StringConcatAspectBenchmark netcoreapp3.1 477μs 6.45μs 63.9μs 0 0 0 257.66 KB
#6965 StringConcatAspectBenchmark net472 405μs 2.1μs 16.6μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.54μs 13ns 62.3ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.39μs 17.2ns 82.5ns 0 0 0 1.76 KB
master EnrichedLog net472 3.9μs 2.07ns 7.16ns 0.255 0 0 1.69 KB
#6965 EnrichedLog net6.0 2.6μs 1.93ns 6.97ns 0 0 0 1.76 KB
#6965 EnrichedLog netcoreapp3.1 3.47μs 15ns 58.2ns 0 0 0 1.76 KB
#6965 EnrichedLog net472 4μs 5.72ns 22.1ns 0.258 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 59.4ns 206ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 222ns 830ns 0 0 0 4.37 KB
master EnrichedLog net472 165μs 136ns 526ns 0 0 0 4.57 KB
#6965 EnrichedLog net6.0 123μs 142ns 531ns 0 0 0 4.37 KB
#6965 EnrichedLog netcoreapp3.1 128μs 196ns 759ns 0 0 0 4.37 KB
#6965 EnrichedLog net472 166μs 53.4ns 207ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.03μs 4.04ns 15.1ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.56μs 22.3ns 86.3ns 0 0 0 2.32 KB
master EnrichedLog net472 7.52μs 7.63ns 29.5ns 0.339 0 0 2.14 KB
#6965 EnrichedLog net6.0 5.04μs 11.8ns 45.5ns 0 0 0 2.32 KB
#6965 EnrichedLog netcoreapp3.1 6.62μs 22.7ns 88ns 0 0 0 2.32 KB
#6965 EnrichedLog net472 7.36μs 4.06ns 15.7ns 0.334 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.94μs 9.87ns 50.3ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.56μs 12.5ns 54.7ns 0 0 0 1.21 KB
master SendReceive net472 3.05μs 3.72ns 13.9ns 0.183 0 0 1.21 KB
#6965 SendReceive net6.0 1.98μs 9.68ns 38.7ns 0 0 0 1.21 KB
#6965 SendReceive netcoreapp3.1 2.64μs 2.16ns 8.08ns 0 0 0 1.21 KB
#6965 SendReceive net472 3.13μs 3.9ns 14.6ns 0.188 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.17μs 11.9ns 46.2ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.82μs 5.38ns 20.8ns 0 0 0 1.69 KB
master EnrichedLog net472 6.57μs 5.55ns 21.5ns 0.327 0 0 2.08 KB
#6965 EnrichedLog net6.0 4.18μs 10.3ns 39.9ns 0 0 0 1.64 KB
#6965 EnrichedLog netcoreapp3.1 5.74μs 12.4ns 47.9ns 0 0 0 1.69 KB
#6965 EnrichedLog net472 6.84μs 7.97ns 30.9ns 0.307 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 739ns 3.16ns 12.2ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 939ns 0.37ns 1.43ns 0 0 0 584 B
master StartFinishSpan net472 930ns 0.266ns 0.96ns 0.0926 0 0 586 B
master StartFinishScope net6.0 902ns 0.578ns 2.24ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.21μs 4.52ns 17.5ns 0 0 0 704 B
master StartFinishScope net472 1.14μs 0.457ns 1.77ns 0.102 0 0 666 B
#6965 StartFinishSpan net6.0 751ns 3.94ns 19.7ns 0 0 0 584 B
#6965 StartFinishSpan netcoreapp3.1 922ns 4.9ns 24ns 0 0 0 584 B
#6965 StartFinishSpan net472 915ns 0.415ns 1.55ns 0.0916 0 0 586 B
#6965 StartFinishScope net6.0 895ns 1.17ns 4.38ns 0 0 0 704 B
#6965 StartFinishScope netcoreapp3.1 1.16μs 1.79ns 6.92ns 0 0 0 704 B
#6965 StartFinishScope net472 1.09μs 0.141ns 0.51ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.01μs 5.51ns 30.2ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.36μs 5.89ns 22.8ns 0 0 0 704 B
master RunOnMethodBegin net472 1.39μs 3.81ns 14.8ns 0.102 0 0 666 B
#6965 RunOnMethodBegin net6.0 1.01μs 4.7ns 19.4ns 0 0 0 704 B
#6965 RunOnMethodBegin netcoreapp3.1 1.37μs 7.03ns 32.2ns 0 0 0 704 B
#6965 RunOnMethodBegin net472 1.4μs 0.693ns 2.4ns 0.105 0 0 666 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyCTHsu @andrewlock