Skip to content

chore(telemetry): track whether tracing was enabled via ssi #6938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

chore(telemetry): track whether tracing was enabled via ssi #6938

wants to merge 6 commits into from

Conversation

mabdinur
Copy link

@mabdinur mabdinur commented May 7, 2025 •
edited
Loading

Summary of changes

Submits instrumentation_source configuration to the instrumentation telemetry platform to track the source of ddtrace instrumentations.

Reason for change

We need to know whether ssi was successful.

Implementation details

Emit instrumentation_source configuration with the value ssi to the instrumentation telemetry platform if a process was instrumented via Single Step Instrumentation. Otherwise report unknown.

Next Steps [p1]: Detect whether ddtool or environments variables were used to "manually" instrument an application.

Test coverage

Validated by: DataDog/system-tests#4543

Other details

This is a first attempt. It only tracks if ssi is used to configure tracing. Profiling is out of scope for now.

@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label May 7, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 7, 2025 •
edited
Loading

Datadog Report

All test runs 33ec31d 🔗

❌ 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 13 0 0 193784 2209 17h 38m 24.42s Link
exploration_tests 0 0 0 22085 3 2m 9.26s Link

❌ Failed Tests (13)

This report shows up to 5 failed tests.

  • ConfigurationDataShouldReportSSIValues - Datadog.Trace.Tests.Telemetry.ConfigurationTelemetryCollectorTests - Details

    Expand for error 
     Expected GetLatestValueFromConfig(data, "ssi_injection_enabled", ConfigurationOrigins.Default) to be "tracer", but found <null>.

  • ConfigurationDataShouldReportSSIValues - Datadog.Trace.Tests.Telemetry.ConfigurationTelemetryCollectorTests - Details

    Expand for error 
     Expected GetLatestValueFromConfig(data, "ssi_injection_enabled", ConfigurationOrigins.Default) to be "tracer", but found <null>.

  • ConfigurationDataShouldReportSSIValues - Datadog.Trace.Tests.Telemetry.ConfigurationTelemetryCollectorTests - Details

    Expand for error 
     Expected GetLatestValueFromConfig(data, "instrumentation_source", ConfigurationOrigins.Default) to be "tracer", but found <null>.

  • ConfigurationDataShouldReportSSIValues - Datadog.Trace.Tests.Telemetry.ConfigurationTelemetryCollectorTests - Details

    Expand for error 
     Expected GetLatestValueFromConfig(data, "ssi_injection_enabled", ConfigurationOrigins.Default) to be "tracer", but found <null>.

  • ConfigurationDataShouldReportSSIValues - Datadog.Trace.Tests.Telemetry.ConfigurationTelemetryCollectorTests - Details

    Expand for error 
     Expected GetLatestValueFromConfig(data, "instrumentation_source", ConfigurationOrigins.Default) to be "tracer", but found <null>.

@mabdinur mabdinur force-pushed the munir/track-instrumentation-source-dotnet branch from 34df49a to 7ad66f6 Compare May 7, 2025 23:50
andrewlock
andrewlock reviewed May 8, 2025
View reviewed changes
tracer/src/Datadog.Trace/Configuration/TracerSettings.cs Outdated
}
else
{
string? value = EnvironmentHelpers.GetEnvironmentVariable("DD_INSTRUMENTATION_INSTALL_TYPE");
Copy link
Member

@andrewlock andrewlock May 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this value is already tracked separately by telemetry - it's explicitly part of the app-started payload 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I changed this a little bit. The accepted values for instrumentation_source will be ssi, cmd_line (which should detect if ddtool was used), and env_var.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 12, 2025 •
edited
Loading

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Test Optimization Report

All test runs c5d0559 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 252088 2300 17h 27m 40.32s Link
exploration_tests 0 0 0 22085 3 2m 9.48s Link

Was this helpful? Give us feedback!

@andrewlock
Copy link
Member

andrewlock commented May 12, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (1,009ms)  : 983, 1035
     .   : milestone, 1009,
    master - mean (1,006ms)  : 984, 1028
     .   : milestone, 1006,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (103ms)  : 100, 105
     .   : milestone, 103,
    master - mean (102ms)  : 101, 103
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (691ms)  : 667, 715
     .   : milestone, 691,
    master - mean (693ms)  : 678, 708
     .   : milestone, 693,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (653ms)  : 632, 674
     .   : milestone, 653,
    master - mean (651ms)  : 631, 671
     .   : milestone, 651,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (189ms)  : 185, 193
     .   : milestone, 189,
    master - mean (189ms)  : 185, 194
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (1,107ms)  : 1076, 1138
     .   : milestone, 1107,
    master - mean (1,107ms)  : 1077, 1136
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (270ms)  : 264, 275
     .   : milestone, 270,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (886ms)  : 857, 915
     .   : milestone, 886,
    master - mean (880ms)  : 851, 910
     .   : milestone, 880,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (261ms)  : 257, 266
     .   : milestone, 261,
    master - mean (261ms)  : 257, 266
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (876ms)  : 840, 913
     .   : milestone, 876,
    master - mean (871ms)  : 836, 906
     .   : milestone, 871,
Loading

@mabdinur mabdinur marked this pull request as ready for review May 12, 2025 23:12
@mabdinur mabdinur requested a review from a team as a code owner May 12, 2025 23:12
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #6938 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.274
  • 4 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6938

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6.16 KB 76 B 1.25%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11μs 61.2ns 377ns 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 12.8μs 64.8ns 304ns 0 0 0 5.74 KB
master StartStopWithChild net472 22.3μs 102ns 469ns 0.89 0.111 0 6.09 KB
#6938 StartStopWithChild net6.0 11.2μs 52.3ns 222ns 0 0 0 5.55 KB
#6938 StartStopWithChild netcoreapp3.1 13.6μs 65.2ns 269ns 0 0 0 5.76 KB
#6938 StartStopWithChild net472 21.7μs 89.3ns 322ns 1.06 0.352 0.117 6.16 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 934μs 68.2ns 255ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 77ns 278ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.21ms 71.9ns 278ns 0 0 0 3.31 KB
#6938 WriteAndFlushEnrichedTraces net6.0 936μs 338ns 1.31μs 0 0 0 2.7 KB
#6938 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 158ns 613ns 0 0 0 2.7 KB
#6938 WriteAndFlushEnrichedTraces net472 1.23ms 72.7ns 272ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6938

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 237.73 KB 1.38 KB 0.58%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.88 KB 241.25 KB 1.37 KB 0.57%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 334μs 347ns 1.34μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 507μs 819ns 3.17μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 443μs 401ns 1.55μs 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 341μs 256ns 991ns 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 522μs 2.59μs 10.7μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 447μs 172ns 644ns 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 312ns 1.64ns 8.52ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 0.114ns 0.44ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 305ns 0.0309ns 0.116ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.38μs 2.17ns 8.41ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.85μs 36.2ns 145ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.76μs 8.24ns 31.9ns 0.573 0 0 3.8 KB
#6938 AllCycleSimpleBody net6.0 332μs 1.6μs 6.39μs 0 0 0 197.24 KB
#6938 AllCycleSimpleBody netcoreapp3.1 502μs 1.65μs 6.38μs 0 0 0 204.94 KB
#6938 AllCycleSimpleBody net472 438μs 125ns 483ns 36.6 2.16 0 237.73 KB
#6938 AllCycleMoreComplexBody net6.0 343μs 1.66μs 6.85μs 0 0 0 200.74 KB
#6938 AllCycleMoreComplexBody netcoreapp3.1 480μs 1.29μs 4.99μs 0 0 0 208.36 KB
#6938 AllCycleMoreComplexBody net472 452μs 167ns 623ns 37.9 2.23 0 241.25 KB
#6938 ObjectExtractorSimpleBody net6.0 310ns 1.72ns 10.2ns 0 0 0 280 B
#6938 ObjectExtractorSimpleBody netcoreapp3.1 396ns 1.97ns 8.14ns 0 0 0 272 B
#6938 ObjectExtractorSimpleBody net472 302ns 0.0311ns 0.12ns 0.044 0 0 281 B
#6938 ObjectExtractorMoreComplexBody net6.0 6.3μs 31.8ns 149ns 0 0 0 3.78 KB
#6938 ObjectExtractorMoreComplexBody netcoreapp3.1 7.66μs 34.1ns 132ns 0 0 0 3.69 KB
#6938 ObjectExtractorMoreComplexBody net472 6.69μs 2.51ns 9.71ns 0.603 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6938 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6938 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6938 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6938 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6938 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6938 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#6938 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6938 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6938 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#6938 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6938 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6938 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61μs 68.7ns 257ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 72.1μs 251ns 972ns 0 0 0 17.42 KB
master SendRequest net472 0.0118ns 0.0028ns 0.0108ns 0 0 0 0 b
#6938 SendRequest net6.0 59.8μs 71.7ns 258ns 0 0 0 14.53 KB
#6938 SendRequest netcoreapp3.1 71.4μs 279ns 1.34μs 0 0 0 17.42 KB
#6938 SendRequest net472 0.00964ns 0.00196ns 0.0076ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #6938

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.274 622,100.00 792,536.67

Fewer allocations 🎉 in #6938

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.15 KB 41.85 KB -298 B -0.71%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 667μs 1.46μs 5.06μs 0 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 621μs 1.29μs 4.65μs 0 0 0 42.15 KB
master WriteAndFlushEnrichedTraces net472 890μs 2.09μs 8.1μs 4.46 0 0 55.89 KB
#6938 WriteAndFlushEnrichedTraces net6.0 671μs 887ns 3.43μs 0 0 0 41.68 KB
#6938 WriteAndFlushEnrichedTraces netcoreapp3.1 790μs 3.85μs 15.4μs 0 0 0 41.85 KB
#6938 WriteAndFlushEnrichedTraces net472 918μs 3.16μs 12.2μs 4.46 0 0 56.14 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 2.01μs 3.29ns 12.7ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.46μs 6.6ns 25.6ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.82μs 5.09ns 19.7ns 0.154 0.014 0 995 B
#6938 ExecuteNonQuery net6.0 1.95μs 7.47ns 28.9ns 0 0 0 1.03 KB
#6938 ExecuteNonQuery netcoreapp3.1 2.43μs 12.4ns 55.6ns 0 0 0 1.02 KB
#6938 ExecuteNonQuery net472 2.72μs 7.07ns 27.4ns 0.149 0.0136 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.77μs 2.56ns 9.93ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 10.1ns 39.3ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.51μs 3.29ns 12.3ns 0.158 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.86μs 9.24ns 42.4ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.47μs 9.63ns 37.3ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.86μs 2.55ns 9.88ns 0.173 0 0 1.11 KB
#6938 CallElasticsearch net6.0 1.77μs 8.81ns 38.4ns 0 0 0 1.04 KB
#6938 CallElasticsearch netcoreapp3.1 2.32μs 7.03ns 27.2ns 0 0 0 1.04 KB
#6938 CallElasticsearch net472 3.49μs 2.21ns 8.57ns 0.158 0 0 1.05 KB
#6938 CallElasticsearchAsync net6.0 1.9μs 9.05ns 38.4ns 0 0 0 1.02 KB
#6938 CallElasticsearchAsync netcoreapp3.1 2.38μs 10.8ns 38.8ns 0 0 0 1.09 KB
#6938 CallElasticsearchAsync net472 3.87μs 2.87ns 11.1ns 0.174 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.81μs 8.63ns 33.4ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.35μs 9.92ns 38.4ns 0 0 0 960 B
master ExecuteAsync net472 2.6μs 2.55ns 9.87ns 0.144 0 0 923 B
#6938 ExecuteAsync net6.0 1.85μs 8.57ns 34.3ns 0 0 0 960 B
#6938 ExecuteAsync netcoreapp3.1 2.31μs 9.73ns 36.4ns 0 0 0 960 B
#6938 ExecuteAsync net472 2.62μs 2.27ns 8.2ns 0.144 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.9μs 6.08ns 21.1ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.93μs 14.9ns 57.7ns 0 0 0 2.9 KB
master SendAsync net472 12.4μs 8.34ns 31.2ns 0.498 0 0 3.19 KB
#6938 SendAsync net6.0 6.86μs 5.1ns 19.1ns 0 0 0 2.37 KB
#6938 SendAsync netcoreapp3.1 8.32μs 7.57ns 29.3ns 0 0 0 2.9 KB
#6938 SendAsync net472 12.4μs 11.7ns 45.4ns 0.495 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6938

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 257.1 KB 260.97 KB 3.86 KB 1.50%

Fewer allocations 🎉 in #6938

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 258.53 KB 257.06 KB -1.47 KB -0.57%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 44.74 KB 43.44 KB -1.3 KB -2.91%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 86.15 KB 43.22 KB -42.94 KB -49.84%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 40.7μs 186ns 643ns 0 0 0 44.74 KB
master StringConcatBenchmark netcoreapp3.1 49.5μs 293ns 2.66μs 0 0 0 86.15 KB
master StringConcatBenchmark net472 57.3μs 195ns 730ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 476μs 1.35μs 4.66μs 0 0 0 257.1 KB
master StringConcatAspectBenchmark netcoreapp3.1 515μs 1.47μs 5.48μs 0 0 0 258.53 KB
master StringConcatAspectBenchmark net472 407μs 2.3μs 16.9μs 0 0 0 278.53 KB
#6938 StringConcatBenchmark net6.0 45.4μs 250ns 2.09μs 0 0 0 43.44 KB
#6938 StringConcatBenchmark netcoreapp3.1 47.1μs 201ns 1.12μs 0 0 0 43.22 KB
#6938 StringConcatBenchmark net472 57.5μs 246ns 921ns 0 0 0 65.54 KB
#6938 StringConcatAspectBenchmark net6.0 472μs 1.31μs 4.71μs 0 0 0 260.97 KB
#6938 StringConcatAspectBenchmark netcoreapp3.1 512μs 2.11μs 7.62μs 0 0 0 257.06 KB
#6938 StringConcatAspectBenchmark net472 406μs 2.09μs 10μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 6.65ns 24.9ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.56μs 13.6ns 51ns 0 0 0 1.76 KB
master EnrichedLog net472 3.87μs 1.8ns 6.97ns 0.252 0 0 1.69 KB
#6938 EnrichedLog net6.0 2.58μs 12.6ns 56.4ns 0 0 0 1.76 KB
#6938 EnrichedLog netcoreapp3.1 3.46μs 17ns 67.8ns 0 0 0 1.76 KB
#6938 EnrichedLog net472 3.9μs 2.25ns 8.41ns 0.252 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 57ns 198ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 127μs 277ns 1.07μs 0 0 0 4.37 KB
master EnrichedLog net472 166μs 107ns 414ns 0 0 0 4.57 KB
#6938 EnrichedLog net6.0 122μs 142ns 532ns 0 0 0 4.37 KB
#6938 EnrichedLog netcoreapp3.1 129μs 412ns 1.48μs 0 0 0 4.37 KB
#6938 EnrichedLog net472 166μs 136ns 525ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.13μs 7.42ns 28.8ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.85μs 11.7ns 45.3ns 0 0 0 2.32 KB
master EnrichedLog net472 7.28μs 6.14ns 23.8ns 0.33 0 0 2.14 KB
#6938 EnrichedLog net6.0 4.99μs 17.4ns 67.4ns 0 0 0 2.32 KB
#6938 EnrichedLog netcoreapp3.1 6.79μs 20.9ns 81ns 0 0 0 2.32 KB
#6938 EnrichedLog net472 7.27μs 8.66ns 33.5ns 0.329 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.07μs 5.61ns 21.7ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.62μs 2.42ns 9.39ns 0 0 0 1.21 KB
master SendReceive net472 3.03μs 2.07ns 8.02ns 0.179 0 0 1.21 KB
#6938 SendReceive net6.0 1.97μs 9.04ns 36.2ns 0 0 0 1.21 KB
#6938 SendReceive netcoreapp3.1 2.51μs 11.5ns 43.1ns 0 0 0 1.21 KB
#6938 SendReceive net472 3.17μs 0.992ns 3.71ns 0.19 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.21μs 10.6ns 41.1ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.8μs 7.01ns 26.2ns 0 0 0 1.69 KB
master EnrichedLog net472 7.03μs 10.9ns 42.3ns 0.316 0 0 2.08 KB
#6938 EnrichedLog net6.0 4.11μs 2.45ns 8.49ns 0 0 0 1.64 KB
#6938 EnrichedLog netcoreapp3.1 5.62μs 20.7ns 80.2ns 0 0 0 1.69 KB
#6938 EnrichedLog net472 6.99μs 10.5ns 40.8ns 0.312 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 733ns 4.13ns 28.3ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 930ns 4.77ns 23.8ns 0 0 0 584 B
master StartFinishSpan net472 931ns 0.31ns 1.2ns 0.0892 0 0 586 B
master StartFinishScope net6.0 889ns 4.41ns 19.2ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 1.42ns 5.51ns 0 0 0 704 B
master StartFinishScope net472 1.17μs 1.55ns 6.01ns 0.106 0 0 666 B
#6938 StartFinishSpan net6.0 753ns 0.424ns 1.64ns 0 0 0 584 B
#6938 StartFinishSpan netcoreapp3.1 942ns 0.531ns 2.06ns 0 0 0 584 B
#6938 StartFinishSpan net472 916ns 0.392ns 1.41ns 0.0922 0 0 586 B
#6938 StartFinishScope net6.0 899ns 4.26ns 18.6ns 0 0 0 704 B
#6938 StartFinishScope netcoreapp3.1 1.14μs 5.97ns 29.2ns 0 0 0 704 B
#6938 StartFinishScope net472 1.17μs 1.32ns 5.1ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1μs 5.05ns 23.2ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.36μs 4.28ns 16.6ns 0 0 0 704 B
master RunOnMethodBegin net472 1.39μs 0.695ns 2.51ns 0.105 0 0 666 B
#6938 RunOnMethodBegin net6.0 1.02μs 4.02ns 15.6ns 0 0 0 704 B
#6938 RunOnMethodBegin netcoreapp3.1 1.35μs 5.51ns 21.3ns 0 0 0 704 B
#6938 RunOnMethodBegin net472 1.42μs 1.53ns 5.91ns 0.0997 0 0 666 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya left review comments

@andrewlock andrewlock andrewlock left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabdinur @andrewlock @zacharycmontoya