Skip to content

Add DOCKER_BUILDKIT. #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add DOCKER_BUILDKIT. #6934

wants to merge 4 commits into from

Conversation

NachoEchevarria
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label May 7, 2025
@andrewlock
Copy link
Member

andrewlock commented May 7, 2025 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6934 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.444
  • 1 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6934

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.11 KB 6.19 KB 78 B 1.28%

Fewer allocations 🎉 in #6934

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.74 KB 5.71 KB -31 B -0.54%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.95μs 141ns 1.41μs 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 8.98μs 32.1ns 116ns 0 0 0 5.74 KB
master StartStopWithChild net472 15.1μs 78.4ns 400ns 1.08 0.432 0.144 6.11 KB
#6934 StartStopWithChild net6.0 7.2μs 78.8ns 730ns 0 0 0 5.56 KB
#6934 StartStopWithChild netcoreapp3.1 10.7μs 123ns 1.22μs 0 0 0 5.71 KB
#6934 StartStopWithChild net472 15μs 78.7ns 385ns 0.979 0.21 0 6.19 KB
Benchmarks.Trace.AgentWriterBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #6934

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 2.058 1,049,792.19 510,151.75

More allocations ⚠️ in #6934

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.35 KB 34 B 1.03%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 1.04ms 4.78μs 18.5μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 561ns 2.17μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 858μs 650ns 2.52μs 0 0 0 3.31 KB
#6934 WriteAndFlushEnrichedTraces net6.0 511μs 465ns 1.74μs 0 0 0 2.7 KB
#6934 WriteAndFlushEnrichedTraces netcoreapp3.1 679μs 436ns 1.51μs 0 0 0 2.7 KB
#6934 WriteAndFlushEnrichedTraces net472 851μs 219ns 788ns 0 0 0 3.35 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 135μs 784ns 6.74μs 0 0 0 14.48 KB
master SendRequest netcoreapp3.1 150μs 720ns 2.79μs 0 0 0 17.28 KB
master SendRequest net472 0.00117ns 0.000629ns 0.00244ns 0 0 0 0 b
#6934 SendRequest net6.0 135μs 681ns 3.04μs 0 0 0 14.48 KB
#6934 SendRequest netcoreapp3.1 155μs 787ns 3.6μs 0 0 0 17.28 KB
#6934 SendRequest net472 0.00412ns 0.00116ns 0.00448ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 548μs 2.52μs 9.75μs 0 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 648μs 2.11μs 7.59μs 0 0 0 41.77 KB
master WriteAndFlushEnrichedTraces net472 879μs 6.29μs 62.9μs 7.81 0 0 53.44 KB
#6934 WriteAndFlushEnrichedTraces net6.0 569μs 3.29μs 29μs 0 0 0 41.71 KB
#6934 WriteAndFlushEnrichedTraces netcoreapp3.1 682μs 3.73μs 21.4μs 0 0 0 41.76 KB
#6934 WriteAndFlushEnrichedTraces net472 885μs 5.13μs 43.3μs 8.33 4.17 0 53.35 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6934

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.668 2,907.66 1,742.72

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.41μs 7.58ns 46.1ns 0.00923 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.91μs 3.89ns 13.5ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.1μs 3.9ns 15.1ns 0.148 0.0106 0 995 B
#6934 ExecuteNonQuery net6.0 1.25μs 3.93ns 15.2ns 0.0126 0 0 1.03 KB
#6934 ExecuteNonQuery netcoreapp3.1 1.75μs 3.2ns 11.5ns 0.00873 0 0 1.02 KB
#6934 ExecuteNonQuery net472 2.06μs 2.85ns 10.6ns 0.157 0.0105 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6934

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.129 1,387.37 1,229.08

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.849ns 3.29ns 0.0122 0 0 984 B
master CallElasticsearch netcoreapp3.1 1.56μs 0.675ns 2.43ns 0.00793 0 0 984 B
master CallElasticsearch net472 2.41μs 1.16ns 4.48ns 0.159 0 0 1 KB
master CallElasticsearchAsync net6.0 1.39μs 0.847ns 3.28ns 0.0137 0 0 960 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 2.3ns 8.61ns 0.00806 0 0 1.03 KB
master CallElasticsearchAsync net472 2.67μs 1.09ns 4.08ns 0.161 0 0 1.06 KB
#6934 CallElasticsearch net6.0 1.19μs 1.3ns 5.05ns 0.0119 0 0 984 B
#6934 CallElasticsearch netcoreapp3.1 1.6μs 2.44ns 9.13ns 0.00815 0 0 984 B
#6934 CallElasticsearch net472 2.49μs 1.86ns 7.21ns 0.15 0 0 1 KB
#6934 CallElasticsearchAsync net6.0 1.23μs 0.334ns 1.2ns 0.0123 0 0 960 B
#6934 CallElasticsearchAsync netcoreapp3.1 1.68μs 1.63ns 5.89ns 0.00848 0 0 1.03 KB
#6934 CallElasticsearchAsync net472 2.71μs 1.51ns 5.64ns 0.163 0 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.35μs 1.41ns 5.46ns 0.0134 0 0 960 B
master ExecuteAsync netcoreapp3.1 1.64μs 8.7ns 45.2ns 0.00813 0 0 960 B
master ExecuteAsync net472 1.77μs 1.02ns 3.83ns 0.142 0 0 923 B
#6934 ExecuteAsync net6.0 1.24μs 0.685ns 2.56ns 0.0124 0 0 960 B
#6934 ExecuteAsync netcoreapp3.1 1.67μs 2.11ns 7.89ns 0.00821 0 0 960 B
#6934 ExecuteAsync net472 1.88μs 0.804ns 3.12ns 0.143 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.39μs 3.18ns 12.3ns 0.022 0 0 2.32 KB
master SendAsync netcoreapp3.1 5.2μs 5.02ns 18.1ns 0.0259 0 0 2.86 KB
master SendAsync net472 7.42μs 2.74ns 10.3ns 0.482 0 0 3.13 KB
#6934 SendAsync net6.0 4.32μs 3.13ns 12.1ns 0.0216 0 0 2.32 KB
#6934 SendAsync netcoreapp3.1 5.38μs 4.98ns 18ns 0.0269 0 0 2.86 KB
#6934 SendAsync net472 7.38μs 7.39ns 26.6ns 0.482 0 0 3.13 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.56μs 1.45ns 5.01ns 0.0236 0 0 1.71 KB
master EnrichedLog netcoreapp3.1 2.41μs 4.06ns 14ns 0.012 0 0 1.71 KB
master EnrichedLog net472 2.66μs 2.48ns 9.26ns 0.251 0 0 1.64 KB
#6934 EnrichedLog net6.0 1.49μs 1.17ns 4.22ns 0.0223 0 0 1.71 KB
#6934 EnrichedLog netcoreapp3.1 2.23μs 3.59ns 13.9ns 0.0224 0 0 1.71 KB
#6934 EnrichedLog net472 2.6μs 1.65ns 6.19ns 0.248 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 575ns 2.64μs 0 0 0 4.32 KB
master EnrichedLog netcoreapp3.1 119μs 364ns 1.41μs 0 0 0 4.32 KB
master EnrichedLog net472 153μs 226ns 875ns 0 0 0 4.51 KB
#6934 EnrichedLog net6.0 110μs 207ns 803ns 0 0 0 4.32 KB
#6934 EnrichedLog netcoreapp3.1 115μs 321ns 1.24μs 0 0 0 4.32 KB
#6934 EnrichedLog net472 150μs 415ns 1.61μs 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 2.92ns 11.3ns 0.0303 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 4.35μs 3.58ns 13.4ns 0 0 0 2.26 KB
master EnrichedLog net472 4.82μs 2.86ns 10.7ns 0.312 0 0 2.09 KB
#6934 EnrichedLog net6.0 3.22μs 6.53ns 23.5ns 0.0322 0 0 2.26 KB
#6934 EnrichedLog netcoreapp3.1 4.23μs 2.67ns 9.98ns 0.0211 0 0 2.26 KB
#6934 EnrichedLog net472 5.14μs 2.74ns 10.6ns 0.309 0 0 2.09 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.41μs 1.13ns 4.24ns 0.0143 0 0 1.15 KB
master SendReceive netcoreapp3.1 1.82μs 3.01ns 11.7ns 0.00885 0 0 1.15 KB
master SendReceive net472 2.1μs 1.9ns 7.35ns 0.176 0 0 1.16 KB
#6934 SendReceive net6.0 1.31μs 0.888ns 3.32ns 0.0132 0 0 1.15 KB
#6934 SendReceive netcoreapp3.1 1.74μs 1.57ns 6.1ns 0.00868 0 0 1.15 KB
#6934 SendReceive net472 2.1μs 0.88ns 3.41ns 0.178 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 1.95ns 7.55ns 0.0139 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 3.91μs 4.34ns 16.8ns 0.0197 0 0 1.69 KB
master EnrichedLog net472 4.45μs 4.87ns 18.2ns 0.31 0 0 2.08 KB
#6934 EnrichedLog net6.0 2.79μs 2.35ns 9.11ns 0.0138 0 0 1.64 KB
#6934 EnrichedLog netcoreapp3.1 3.91μs 4.2ns 15.7ns 0.0196 0 0 1.69 KB
#6934 EnrichedLog net472 4.51μs 2.82ns 10.6ns 0.314 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6934

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.122 462.98 412.79

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 463ns 0.23ns 0.83ns 0.00687 0 0 584 B
master StartFinishSpan netcoreapp3.1 569ns 0.309ns 1.15ns 0.00569 0 0 584 B
master StartFinishSpan net472 656ns 0.434ns 1.68ns 0.0922 0 0 586 B
master StartFinishScope net6.0 508ns 0.461ns 1.79ns 0.0101 0 0 704 B
master StartFinishScope netcoreapp3.1 681ns 0.641ns 2.4ns 0.00682 0 0 704 B
master StartFinishScope net472 779ns 0.282ns 1.09ns 0.105 0 0 666 B
#6934 StartFinishSpan net6.0 412ns 0.427ns 1.54ns 0.00822 0 0 584 B
#6934 StartFinishSpan netcoreapp3.1 570ns 0.674ns 2.61ns 0.00563 0 0 584 B
#6934 StartFinishSpan net472 656ns 0.251ns 0.938ns 0.0901 0 0 586 B
#6934 StartFinishScope net6.0 488ns 0.392ns 1.47ns 0.00965 0 0 704 B
#6934 StartFinishScope netcoreapp3.1 741ns 0.642ns 2.4ns 0.00731 0 0 704 B
#6934 StartFinishScope net472 857ns 0.653ns 2.53ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 674ns 0.586ns 2.27ns 0.0101 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 951ns 0.877ns 3.28ns 0.00948 0 0 704 B
master RunOnMethodBegin net472 1.04μs 0.588ns 2.28ns 0.104 0 0 666 B
#6934 RunOnMethodBegin net6.0 660ns 0.431ns 1.67ns 0.00993 0 0 704 B
#6934 RunOnMethodBegin netcoreapp3.1 982ns 0.693ns 2.4ns 0.00495 0 0 704 B
#6934 RunOnMethodBegin net472 1.1μs 0.321ns 1.2ns 0.105 0 0 666 B

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 7, 2025 •
edited
Loading

Datadog Report

Branch report: nacho/DockerBuildKit
Commit report: aefcf0e
Test service: dd-trace-dotnet

✅ 0 Failed, 250569 Passed, 2295 Skipped, 17h 50m 12.46s Total Time

@andrewlock
Copy link
Member

andrewlock commented May 7, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6934) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6934) - mean (1,004ms)  : 976, 1032
     .   : milestone, 1004,
    master - mean (1,009ms)  : 983, 1035
     .   : milestone, 1009,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6934) - mean (103ms)  : 101, 105
     .   : milestone, 103,
    master - mean (103ms)  : 101, 105
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6934) - mean (691ms)  : 668, 714
     .   : milestone, 691,
    master - mean (698ms)  : 682, 713
     .   : milestone, 698,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6934) - mean (90ms)  : 87, 92
     .   : milestone, 90,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6934) - mean (649ms)  : 630, 668
     .   : milestone, 649,
    master - mean (656ms)  : 639, 672
     .   : milestone, 656,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6934) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6934) - mean (1,108ms)  : 1082, 1134
     .   : milestone, 1108,
    master - mean (1,110ms)  : 1079, 1140
     .   : milestone, 1110,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6934) - mean (270ms)  : 266, 274
     .   : milestone, 270,
    master - mean (270ms)  : 266, 274
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (6934) - mean (876ms)  : 843, 909
     .   : milestone, 876,
    master - mean (874ms)  : 843, 905
     .   : milestone, 874,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6934) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (261ms)  : 257, 266
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6934) - mean (868ms)  : 834, 902
     .   : milestone, 868,
    master - mean (870ms)  : 845, 896
     .   : milestone, 870,
Loading

@pr-commenter
Copy link

pr-commenter bot commented May 7, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for tracer 🐌

Benchmarks for #6934 compared to master:

  • All benchmarks have the same speed
  • 1 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6934

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.55 KB 5.59 KB 42 B 0.76%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.07 KB 6.1 KB 32 B 0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.8μs 58.2ns 324ns 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 13.6μs 72.2ns 353ns 0 0 0 5.76 KB
master StartStopWithChild net472 22.4μs 106ns 397ns 0.936 0.234 0 6.07 KB
#6934 StartStopWithChild net6.0 10.5μs 55.1ns 270ns 0 0 0 5.59 KB
#6934 StartStopWithChild netcoreapp3.1 14μs 64.8ns 259ns 0 0 0 5.74 KB
#6934 StartStopWithChild net472 22.1μs 107ns 477ns 1.06 0.317 0.106 6.1 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 935μs 74.9ns 270ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 45.1ns 163ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.23ms 40.9ns 153ns 0 0 0 3.31 KB
#6934 WriteAndFlushEnrichedTraces net6.0 949μs 64.9ns 234ns 0 0 0 2.71 KB
#6934 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 128ns 477ns 0 0 0 2.7 KB
#6934 WriteAndFlushEnrichedTraces net472 1.23ms 67.5ns 261ns 0 0 0 3.31 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 59.9μs 52.7ns 197ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 70.7μs 126ns 453ns 0 0 0 17.42 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#6934 SendRequest net6.0 60.3μs 62.5ns 217ns 0 0 0 14.53 KB
#6934 SendRequest netcoreapp3.1 71.5μs 374ns 1.83μs 0 0 0 17.42 KB
#6934 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6934

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.98 KB 56.4 KB 417 B 0.74%

Fewer allocations 🎉 in #6934

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.08 KB 41.83 KB -244 B -0.58%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 720μs 997ns 3.86μs 0 0 0 41.76 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 1.96μs 7.59μs 0 0 0 42.08 KB
master WriteAndFlushEnrichedTraces net472 929μs 3.72μs 14.4μs 8.33 0 0 55.98 KB
#6934 WriteAndFlushEnrichedTraces net6.0 722μs 849ns 3.29μs 0 0 0 41.76 KB
#6934 WriteAndFlushEnrichedTraces netcoreapp3.1 711μs 3.73μs 18.7μs 0 0 0 41.83 KB
#6934 WriteAndFlushEnrichedTraces net472 935μs 3.43μs 13.3μs 8.93 4.46 0 56.4 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 1.88ns 7.29ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.51μs 9.06ns 35.1ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.76μs 1.98ns 7.66ns 0.153 0.0139 0 995 B
#6934 ExecuteNonQuery net6.0 1.97μs 1.4ns 5.41ns 0 0 0 1.03 KB
#6934 ExecuteNonQuery netcoreapp3.1 2.4μs 8.84ns 34.2ns 0 0 0 1.02 KB
#6934 ExecuteNonQuery net472 2.79μs 4.5ns 16.8ns 0.151 0.0137 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.84μs 1.77ns 6.84ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.23μs 11.1ns 45.8ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.53μs 3.22ns 11.6ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.8μs 7.89ns 28.4ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.39μs 9.31ns 36ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.57μs 1.91ns 7.14ns 0.161 0 0 1.11 KB
#6934 CallElasticsearch net6.0 1.75μs 1.58ns 6.13ns 0 0 0 1.04 KB
#6934 CallElasticsearch netcoreapp3.1 2.29μs 6.77ns 26.2ns 0 0 0 1.04 KB
#6934 CallElasticsearch net472 3.54μs 4.24ns 15.9ns 0.16 0 0 1.05 KB
#6934 CallElasticsearchAsync net6.0 1.83μs 6.91ns 26.8ns 0 0 0 1.02 KB
#6934 CallElasticsearchAsync netcoreapp3.1 2.34μs 9.07ns 35.1ns 0 0 0 1.09 KB
#6934 CallElasticsearchAsync net472 3.59μs 2.42ns 9.39ns 0.161 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.76μs 6.88ns 24.8ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.27μs 1.02ns 3.53ns 0 0 0 960 B
master ExecuteAsync net472 2.56μs 2.66ns 10.3ns 0.141 0 0 923 B
#6934 ExecuteAsync net6.0 1.78μs 2.97ns 11.5ns 0 0 0 960 B
#6934 ExecuteAsync netcoreapp3.1 2.28μs 5.37ns 20.8ns 0 0 0 960 B
#6934 ExecuteAsync net472 2.65μs 1.24ns 4.79ns 0.145 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.66μs 11.6ns 41.7ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.36μs 15.8ns 61.2ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 9.97ns 38.6ns 0.498 0 0 3.19 KB
#6934 SendAsync net6.0 7.13μs 7.31ns 28.3ns 0 0 0 2.37 KB
#6934 SendAsync netcoreapp3.1 8.31μs 26.6ns 103ns 0 0 0 2.9 KB
#6934 SendAsync net472 12.3μs 12.1ns 46.9ns 0.492 0 0 3.19 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.54μs 12.9ns 62.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.41μs 17.2ns 75ns 0 0 0 1.76 KB
master EnrichedLog net472 3.93μs 3.26ns 12.6ns 0.254 0 0 1.69 KB
#6934 EnrichedLog net6.0 2.6μs 12.7ns 56.8ns 0 0 0 1.76 KB
#6934 EnrichedLog netcoreapp3.1 3.46μs 15ns 58.2ns 0 0 0 1.76 KB
#6934 EnrichedLog net472 3.85μs 2.73ns 10.2ns 0.251 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 64.1ns 248ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 128μs 474ns 1.77μs 0 0 0 4.37 KB
master EnrichedLog net472 169μs 176ns 681ns 0 0 0 4.57 KB
#6934 EnrichedLog net6.0 124μs 56.4ns 195ns 0 0 0 4.37 KB
#6934 EnrichedLog netcoreapp3.1 126μs 30.7ns 115ns 0 0 0 4.37 KB
#6934 EnrichedLog net472 167μs 138ns 536ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.1μs 24.9ns 106ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.62μs 25.4ns 98.5ns 0 0 0 2.32 KB
master EnrichedLog net472 7.33μs 9.88ns 38.3ns 0.327 0 0 2.14 KB
#6934 EnrichedLog net6.0 4.99μs 15.3ns 59.2ns 0 0 0 2.32 KB
#6934 EnrichedLog netcoreapp3.1 6.51μs 16.8ns 65.1ns 0 0 0 2.32 KB
#6934 EnrichedLog net472 7.49μs 6.16ns 22.2ns 0.337 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.03μs 2.36ns 9.15ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.65μs 9.67ns 37.4ns 0 0 0 1.21 KB
master SendReceive net472 3.12μs 4.19ns 15.7ns 0.186 0 0 1.21 KB
#6934 SendReceive net6.0 1.98μs 2.77ns 10.7ns 0 0 0 1.21 KB
#6934 SendReceive netcoreapp3.1 2.53μs 10.8ns 41.7ns 0 0 0 1.21 KB
#6934 SendReceive net472 3.12μs 5.27ns 20.4ns 0.186 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.16μs 14.7ns 57ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.79μs 22.8ns 88.2ns 0 0 0 1.69 KB
master EnrichedLog net472 6.73μs 7.46ns 28.9ns 0.301 0 0 2.08 KB
#6934 EnrichedLog net6.0 4.16μs 10.1ns 39ns 0 0 0 1.64 KB
#6934 EnrichedLog netcoreapp3.1 5.55μs 3.76ns 13.6ns 0 0 0 1.69 KB
#6934 EnrichedLog net472 6.66μs 8.58ns 33.2ns 0.33 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 767ns 0.309ns 1.16ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 943ns 0.75ns 2.9ns 0 0 0 584 B
master StartFinishSpan net472 921ns 0.4ns 1.55ns 0.0922 0 0 586 B
master StartFinishScope net6.0 898ns 4.48ns 20ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 5.5ns 21.3ns 0 0 0 704 B
master StartFinishScope net472 1.1μs 0.554ns 2.15ns 0.104 0 0 666 B
#6934 StartFinishSpan net6.0 765ns 4.04ns 19.8ns 0 0 0 584 B
#6934 StartFinishSpan netcoreapp3.1 932ns 4.96ns 24.3ns 0 0 0 584 B
#6934 StartFinishSpan net472 912ns 0.32ns 1.24ns 0.0909 0 0 586 B
#6934 StartFinishScope net6.0 894ns 4.91ns 27.4ns 0 0 0 704 B
#6934 StartFinishScope netcoreapp3.1 1.16μs 5.99ns 30ns 0 0 0 704 B
#6934 StartFinishScope net472 1.1μs 0.329ns 1.28ns 0.105 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.04μs 5.27ns 22.3ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.39μs 5.61ns 21ns 0 0 0 704 B
master RunOnMethodBegin net472 1.34μs 1.03ns 3.97ns 0.0994 0 0 666 B
#6934 RunOnMethodBegin net6.0 1.02μs 0.655ns 2.36ns 0 0 0 704 B
#6934 RunOnMethodBegin netcoreapp3.1 1.41μs 6.79ns 29.6ns 0 0 0 704 B
#6934 RunOnMethodBegin net472 1.39μs 1.37ns 5.3ns 0.103 0 0 666 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoEchevarria @andrewlock