-
Notifications
You must be signed in to change notification settings - Fork 9
k8 secrets RESTful support #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
s-alad
wants to merge
23
commits into
v1
Choose a base branch
from
saad/k8-secrets-rest
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds support for kubernetes secrets
Motivation
supporting container secrets
Additional Notes
RBAC: the customer using k8s secrets needs to have a proper RBAC authorization setup in order to allow the secret-backend to access the correct namespaces.
The ServiceAccount of the pod running the Agent/SGC must have automountServiceAccountToken: true (default) in order for our system to be able to interact with the k8 REST API.
The ServiceAccount must be granted permission to read secrets from each namespace where secrets are needed via RBAC:
Sources:
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Setup a test cluster and create a k8 secret to test on. This script allows for an easy setup and test:
touch test-k8.shchmod +x ./test-k8.sh{"datadog-sgc-test/dd-api-keys;api_key":{"value":"test-123","error":null},"datadog-sgc-test/dd-api-keys;app_key":{"value":"test-456","error":null}}