Move lambda tests into a folder #142
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| return { | ||
| CloudWatchLogs: jest.fn().mockImplementation((_) => { | ||
| return { | ||
| describeLogGroups: (params: DescribeLogGroupsRequest, callback?: any) => { |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected any. Specify a different type. (...read more)
Do not use the any type, as it is too broad and can lead to unexpected behavior.
| promise: jest.fn().mockImplementation(() => Promise.resolve([])), | ||
| }; | ||
| }, | ||
| putSubscriptionFilter: (params: PutSubscriptionFilterRequest, callback?: any) => { |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected any. Specify a different type. (...read more)
Do not use the any type, as it is too broad and can lead to unexpected behavior.
| @@ -129,7 +92,7 @@ function mockInputEvent( | |||
| } as InputEvent; | |||
| } | |||
|
|
|||
| function mockGovCloudInputEvent(params: any, mappings: any, logGroups?: LogGroupDefinition[]) { | |||
| export function mockGovCloudInputEvent(params: any, mappings: any, logGroups?: LogGroupDefinition[]) { | |||
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected any. Specify a different type. (...read more)
Do not use the any type, as it is too broad and can lead to unexpected behavior.
| putSubscriptionFilter: (params: PutSubscriptionFilterRequest, callback?: any) => { | ||
| return { promise: () => Promise.resolve() }; | ||
| }, | ||
| createLogGroup: (params: CreateLogGroupRequest, callback?: any) => { |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected any. Specify a different type. (...read more)
Do not use the any type, as it is too broad and can lead to unexpected behavior.
| promise: jest.fn().mockImplementation(() => Promise.resolve(response)), | ||
| }; | ||
| }, | ||
| describeSubscriptionFilters: (params: DescribeSubscriptionFiltersRequest, callback?: any) => { |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected any. Specify a different type. (...read more)
Do not use the any type, as it is too broad and can lead to unexpected behavior.
lym953
force-pushed
the
yiming.luo/step-function-3
branch
from
c9fcce4 to
c1df317
Compare
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Context of this PR series
Right now the Datadog Serverless CloudFormation Macro only supports instrumenting Lambda functions. This series of PRs makes it also support instrumenting Step Functions.
Instead of merging every PR into main branch, I'm going to merge them into a feature branch
yiming.luo/step-functionto:What does this PR do?
Move tests node for Lambda to a
lambdafolder. Later I will create astep_functionfolder, so Lambda and Step Function code and tests will be separate and more clear.Motivation
Testing Guidelines
Run
npm testto run existing tests. They still pass.Additional Notes
Types of changes
Check all that apply