SQG test pr, please ignore by chouquette · Pull Request #48478 · DataDog/datadog-agent

chouquette · 2026-03-27T11:18:06Z

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

that should be enough to increase the size of the package on disk by more than 750kb

agent-platform-auto-pr · 2026-03-27T11:49:40Z

Files inventory check summary

File checks results against ancestor 37509467:

Results for datadog-agent_7.79.0~devel.git.193.13a1c05.pipeline.104733971-1_amd64.deb:

Detected file changes:

3 Changed files:

opt/datadog-agent/embedded/lib/libcrypto.so.3.5.5:
- Size changed: +17.38% (1.03 MiB) (5.91 MiB -> 6.94 MiB)
opt/datadog-agent/embedded/lib/libssl.so.3.5.5:
- Size changed: +35.28% (364.05 KiB) (1.01 MiB -> 1.36 MiB)
opt/datadog-agent/embedded/bin/openssl:
- Size changed: +19.26% (181.32 KiB) (941.45 KiB -> 1.1 MiB)

cit-pr-commenter-54b7da · 2026-03-27T12:11:43Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5fd7fe33-b698-4567-9f16-da43c1c2b1d2

Baseline: 3750946
Comparison: 13a1c05
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-1.30	[-4.29, +1.68]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	ddot_metrics	memory utilization	+0.61	[+0.43, +0.79]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.40	[+0.24, +0.56]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.05	[-0.39, +0.49]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.07, +0.12]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.18, +0.20]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.11, +0.12]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.21, +0.20]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.06	[-0.44, +0.33]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.06	[-0.55, +0.42]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.09	[-0.15, -0.03]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.10	[-0.24, +0.04]	1	Logs
➖	ddot_logs	memory utilization	-0.12	[-0.18, -0.07]	1	Logs
➖	quality_gate_idle	memory utilization	-0.16	[-0.21, -0.11]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.16	[-0.22, -0.11]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.18	[-0.21, -0.14]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.19	[-0.42, +0.03]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.23	[-0.39, -0.08]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.24	[-1.86, +1.38]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.29	[-0.36, -0.22]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.57	[-0.81, -0.33]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	-0.74	[-0.85, -0.64]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.21	[-1.33, -1.09]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-1.30	[-4.29, +1.68]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	733 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	272.86MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	729 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	174.11MiB ≤ 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	515.44MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	203.98MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	351.94 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	414.55MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2026-03-27T12:20:31Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3750946
📊 Static Quality Gates Dashboard
🔗 SQG Job
⚠️ Exception granted by @dd-ddamien: this PR exceeds the per-PR size threshold (750.0 KiB) but will not be blocked.

Error

	Quality gate	Change	Size (prev → curr → max)
⚠️	agent_deb_amd64 (per-PR threshold)	+1.56 MiB (0.21% increase)	752.541 → 754.102 → 754.380
⚠️	agent_deb_amd64_fips (per-PR threshold)	+1.6 MiB (0.23% increase)	709.559 → 711.159 → 714.900
⚠️	agent_heroku_amd64 (per-PR threshold)	+1.56 MiB (0.50% increase)	313.293 → 314.853 → 321.580
⚠️	agent_msi (per-PR threshold)	+1.69 MiB (0.28% increase)	604.784 → 606.470 → 652.440
⚠️	agent_rpm_amd64 (per-PR threshold)	+1.56 MiB (0.21% increase)	752.525 → 754.085 → 754.350
⚠️	agent_rpm_amd64_fips (per-PR threshold)	+1.6 MiB (0.23% increase)	709.543 → 711.142 → 714.880
⚠️	agent_rpm_arm64 (per-PR threshold)	+1.72 MiB (0.23% increase)	730.963 → 732.679 → 736.290
⚠️	agent_rpm_arm64_fips (per-PR threshold)	+1.78 MiB (0.26% increase)	690.994 → 692.772 → 697.840
⚠️	agent_suse_amd64 (per-PR threshold)	+1.56 MiB (0.21% increase)	752.525 → 754.085 → 754.350
⚠️	agent_suse_amd64_fips (per-PR threshold)	+1.6 MiB (0.23% increase)	709.543 → 711.142 → 714.880
⚠️	agent_suse_arm64 (per-PR threshold)	+1.72 MiB (0.23% increase)	730.963 → 732.679 → 736.290
⚠️	agent_suse_arm64_fips (per-PR threshold)	+1.78 MiB (0.26% increase)	690.994 → 692.772 → 697.840
⚠️	docker_agent_amd64 (per-PR threshold)	+1.56 MiB (0.19% increase)	812.844 → 814.404 → 816.700
⚠️	docker_agent_arm64 (per-PR threshold)	+1.72 MiB (0.21% increase)	816.052 → 817.768 → 822.970
⚠️	docker_agent_jmx_amd64 (per-PR threshold)	+1.56 MiB (0.16% increase)	1003.759 → 1005.320 → 1007.580
⚠️	docker_agent_jmx_arm64 (per-PR threshold)	+1.72 MiB (0.17% increase)	995.746 → 997.462 → 1002.570

Gate failure full details

Quality gate	Error type	Error message
agent_deb_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.56 MiB exceeds the per-PR threshold of 750.0 KiB
agent_deb_amd64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.6 MiB exceeds the per-PR threshold of 750.0 KiB
agent_heroku_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.56 MiB exceeds the per-PR threshold of 750.0 KiB
agent_msi	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.69 MiB exceeds the per-PR threshold of 750.0 KiB
agent_rpm_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.56 MiB exceeds the per-PR threshold of 750.0 KiB
agent_rpm_amd64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.6 MiB exceeds the per-PR threshold of 750.0 KiB
agent_rpm_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.72 MiB exceeds the per-PR threshold of 750.0 KiB
agent_rpm_arm64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.78 MiB exceeds the per-PR threshold of 750.0 KiB
agent_suse_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.56 MiB exceeds the per-PR threshold of 750.0 KiB
agent_suse_amd64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.6 MiB exceeds the per-PR threshold of 750.0 KiB
agent_suse_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.72 MiB exceeds the per-PR threshold of 750.0 KiB
agent_suse_arm64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.78 MiB exceeds the per-PR threshold of 750.0 KiB
docker_agent_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.56 MiB exceeds the per-PR threshold of 750.0 KiB
docker_agent_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.72 MiB exceeds the per-PR threshold of 750.0 KiB
docker_agent_jmx_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.56 MiB exceeds the per-PR threshold of 750.0 KiB
docker_agent_jmx_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @dd-ddamien)	On-disk size increase of 1.72 MiB exceeds the per-PR threshold of 750.0 KiB

Note: Some gates exceeded limits but are non-blocking because the size hasn't increased from the ancestor commit.

15 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	docker_cluster_agent_amd64	203.938 MiB
✅	docker_cluster_agent_arm64	218.420 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.238 MiB
✅	docker_dogstatsd_arm64	37.445 MiB
✅	dogstatsd_deb_amd64	29.881 MiB
✅	dogstatsd_deb_arm64	28.030 MiB
✅	dogstatsd_rpm_amd64	29.881 MiB
✅	dogstatsd_suse_amd64	29.881 MiB
✅	iot_agent_deb_amd64	43.270 MiB
✅	iot_agent_deb_arm64	40.320 MiB
✅	iot_agent_deb_armhf	41.068 MiB
✅	iot_agent_rpm_amd64	43.270 MiB
✅	iot_agent_suse_amd64	43.270 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
⚠️	agent_deb_amd64	-181.12 KiB (0.10% reduction)	174.715 → 174.538 → 179.360
⚠️	agent_deb_amd64_fips	-123.03 KiB (0.07% reduction)	165.345 → 165.225 → 173.790
⚠️	agent_heroku_amd64	-153.54 KiB (0.20% reduction)	75.001 → 74.851 → 80.970
⚠️	agent_msi	-56.0 KiB (0.04% reduction)	138.352 → 138.297 → 147.220
⚠️	agent_rpm_amd64	-604.1 KiB (0.33% reduction)	177.501 → 176.911 → 182.830
⚠️	agent_rpm_amd64_fips	-196.76 KiB (0.11% reduction)	167.602 → 167.410 → 174.370
⚠️	agent_rpm_arm64	-172.68 KiB (0.11% reduction)	159.476 → 159.307 → 164.060
⚠️	agent_rpm_arm64_fips	-198.43 KiB (0.13% reduction)	151.355 → 151.162 → 157.170
⚠️	agent_suse_amd64	-604.1 KiB (0.33% reduction)	177.501 → 176.911 → 182.830
⚠️	agent_suse_amd64_fips	-196.76 KiB (0.11% reduction)	167.602 → 167.410 → 174.370
⚠️	agent_suse_arm64	-172.68 KiB (0.11% reduction)	159.476 → 159.307 → 164.060
⚠️	agent_suse_arm64_fips	-198.43 KiB (0.13% reduction)	151.355 → 151.162 → 157.170
⚠️	docker_agent_amd64	-9.66 KiB (0.00% reduction)	268.096 → 268.087 → 273.480
⚠️	docker_agent_arm64	-35.45 KiB (0.01% reduction)	255.303 → 255.268 → 262.060
⚠️	docker_agent_jmx_amd64	+2.13 KiB (0.00% increase)	336.739 → 336.741 → 342.100
⚠️	docker_agent_jmx_arm64	-21.05 KiB (0.01% reduction)	319.928 → 319.907 → 326.620
✅	docker_cluster_agent_amd64	neutral	71.367 MiB → 73.920
✅	docker_cluster_agent_arm64	neutral	67.014 MiB → 69.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 4.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 4.090
✅	docker_dogstatsd_amd64	neutral	15.173 MiB → 16.820
✅	docker_dogstatsd_arm64	neutral	14.488 MiB → 15.830
✅	dogstatsd_deb_amd64	neutral	7.891 MiB → 9.790
✅	dogstatsd_deb_arm64	-2.3 KiB (0.03% reduction)	6.779 → 6.777 → 8.710
✅	dogstatsd_rpm_amd64	neutral	7.904 MiB → 9.800
✅	dogstatsd_suse_amd64	neutral	7.904 MiB → 9.800
✅	iot_agent_deb_amd64	neutral	11.399 MiB → 13.040
✅	iot_agent_deb_arm64	neutral	9.701 MiB → 11.450
✅	iot_agent_deb_armhf	neutral	9.939 MiB → 11.620
✅	iot_agent_rpm_amd64	-3.55 KiB (0.03% reduction)	11.421 → 11.417 → 13.060
✅	iot_agent_suse_amd64	-3.55 KiB (0.03% reduction)	11.421 → 11.417 → 13.060

dd-ddamien

approved - test

chouquette · 2026-03-27T13:23:10Z

approved - test

Thanks, ~~merging~~ re-running the SQG job to confirm that it now succeeds

chouquette · 2026-03-27T13:28:31Z

The SQG is now passing due to the exception, closing the test PR
https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1545216576#L449

chouquette added 6 commits March 27, 2026 11:44

sqg: add a helper to lazily fetch for exceptions

c1197f7

sqg: check for per-PR threshold increase and block above 750KiB

ceb19d0

sqg: check for granted exception on gates failure

fc6818b

add unit tests for the new PR threshold gates

d9d849e

TMP: increase the theshold by 1MiB for a test

a413389

disable openssl optimizations

13a1c05

that should be enough to increase the size of the package on disk by more than 750kb

dd-octo-sts bot added the internal Identify a non-fork PR label Mar 27, 2026

github-actions bot added the medium review PR review might take time label Mar 27, 2026

dd-octo-sts bot added team/agent-build team/container-platform The Container Platform Team labels Mar 27, 2026

chouquette mentioned this pull request Mar 27, 2026

SQG: Add a per-PR 750KiB threshold and handle exceptions #48477

Open

dd-ddamien marked this pull request as ready for review March 27, 2026 13:22

dd-ddamien requested review from a team, cmourot and dd-ddamien as code owners March 27, 2026 13:22

dd-ddamien approved these changes Mar 27, 2026

View reviewed changes

chouquette closed this Mar 27, 2026

chouquette deleted the chouquette/sqg/test branch March 27, 2026 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SQG test pr, please ignore#48478

SQG test pr, please ignore#48478
chouquette wants to merge 6 commits intomainfrom
chouquette/sqg/test

chouquette commented Mar 27, 2026

Uh oh!

agent-platform-auto-pr bot commented Mar 27, 2026

3 Changed files:

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 27, 2026

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

dd-ddamien left a comment

Uh oh!

chouquette commented Mar 27, 2026

Uh oh!

chouquette commented Mar 27, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chouquette commented Mar 27, 2026

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented Mar 27, 2026

Files inventory check summary

Results for datadog-agent_7.79.0~devel.git.193.13a1c05.pipeline.104733971-1_amd64.deb:

Detected file changes:

3 Changed files:

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 27, 2026

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Error

Uh oh!

dd-ddamien left a comment

Choose a reason for hiding this comment

Uh oh!

chouquette commented Mar 27, 2026

Uh oh!

chouquette commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agent-platform-auto-pr bot commented Mar 27, 2026 •

edited

Loading

chouquette commented Mar 27, 2026 •

edited

Loading