Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unused replace directive #32547

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

pgimalac
Copy link
Member

What does this PR do?

Remove an unused replace directive.

Motivation

It's useless as we're actually not using the module.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac added changelog/no-changelog team/agent-shared-components qa/no-code-change No code change in Agent code requiring validation labels Dec 30, 2024
@pgimalac pgimalac requested a review from a team as a code owner December 30, 2024 12:41
@github-actions github-actions bot added the medium review PR review might take time label Dec 30, 2024
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor c83838f0eb1cfbea4afb3d4426e985e51d3661e8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1191.04MB 1191.04MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1200.36MB 1200.36MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1200.36MB 1200.36MB 140.00MB
datadog-agent-arm64-deb 0.00MB 935.36MB 935.36MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 944.66MB 944.66MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.53MB 78.53MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.61MB 78.61MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.61MB 78.61MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.75MB 55.75MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.25MB 505.25MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.33MB 113.33MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.80MB 108.80MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.87MB 108.87MB 10.00MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: bd751333-a37b-48ce-b7b6-76253e0d34e6

Baseline: c83838f
Comparison: c214e52
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +0.85 [+0.06, +1.65] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.44 [-0.24, +1.13] 1 Logs
file_tree memory utilization +0.15 [+0.03, +0.28] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.15 [-0.31, +0.62] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.12 [-0.77, +1.02] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.08 [-0.76, +0.91] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.07 [-0.56, +0.71] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.70, +0.83] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.68, +0.75] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
quality_gate_idle memory utilization -0.09 [-0.12, -0.05] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.11 [-0.19, -0.03] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput -0.12 [-1.01, +0.76] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.49 [-0.57, -0.41] 1 Logs
quality_gate_logs % cpu utilization -2.38 [-5.53, +0.76] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@pgimalac
Copy link
Member Author

pgimalac commented Jan 2, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 2, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-02 09:52:05 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-02 10:29:18 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5d09f2c into main Jan 2, 2025
266 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/remove-unused-replace branch January 2, 2025 10:29
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants