Skip to content

Update dependency foodcritic to v16#1242

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/foodcritic-16.x
Open

Update dependency foodcritic to v16#1242
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/foodcritic-16.x

Conversation

@renovate

@renovate renovate Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
foodcritic (source) '~> 15.1.0''~> 16.3.0' age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

acrmp/foodcritic (foodcritic)

v16.3.0

Compare Source

Please keep in mind that Foodcritic is considered EOL. This release is being made to reduce the side of dependencies in Chef Workstation. Users of Foodcritic should migrate to Cookstyle which ships with nearly 200 Chef cookbook cops and autocorrects code.

  • Removed the dependency on cucumber-core and its many dependencies by vendoring the gherkin tag processing logic from cucumber-core 3.x
  • Fix FC123 to properly look for files in subdirectories within the /files directory

v16.2.0

Compare Source

  • Updated Chef Infra metadata to 15.4 and 14.14 to add new resource properties and actions
  • Fixed the detection of :'symbol' action in notifications on Ruby 2.6+

v16.1.1

Compare Source

  • Resolved failure in FC123 when a cookbook does not include a files directory

v16.1.0

Compare Source

  • Updated Chef Infra Client metadata for 15.1 to include the new chocolatey_feature resources as well as new properties in the launchd and chocolatey_source resources
  • Added new rule to detect large files shipped in a cookbook: FC123: Content of a cookbook file is larger than 1MB. Thanks @​mattray
  • Allow configuring the size of the AST cache with a new --ast-cache-size command line option. Thanks @​Babar
  • Fix false positives in FC019 by chaning the Chef internal methods we check against. Thanks @​TravisWhitehead

v16.0.0

Compare Source

  • Removed Chef 13 metadata
  • Added metadata for Chef 14.12.9 and 15.0.293
  • Reenabled FC121 which detects the usage of cookbooks made obsolete by Chef 14

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot requested a review from a team as a code owner July 7, 2026 21:42
@renovate renovate Bot added the dependencies label Jul 7, 2026
@renovate

renovate Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: dd-agent-testing/Gemfile.lock

/opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:272:in 'Bundler::SharedHelpers#search_up': undefined method 'untaint' for an instance of String (NoMethodError)

      current  = File.expand_path(SharedHelpers.pwd).untaint
                                                    ^^^^^^^^
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:259:in 'Bundler::SharedHelpers#find_file'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:251:in 'Bundler::SharedHelpers#find_gemfile'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:27:in 'Bundler::SharedHelpers#root'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler.rb:234:in 'Bundler.root'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler.rb:246:in 'Bundler.app_config_path'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler.rb:273:in 'Bundler.settings'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/feature_flag.rb:21:in 'block in Bundler::FeatureFlag#settings_method'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/cli.rb:97:in '<class:CLI>'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/cli.rb:7:in '<module:Bundler>'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/cli.rb:6:in '<top (required)>'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/exe/bundle:23:in 'Kernel#require'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/exe/bundle:23:in 'block in <top (required)>'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/lib/bundler/friendly_errors.rb:124:in 'Bundler.with_friendly_errors'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/exe/bundle:22:in '<top (required)>'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/exe/bundler:4:in 'Kernel#load'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/gems/bundler-1.17.3/exe/bundler:4:in '<top (required)>'
	from /opt/containerbase/tools/ruby/4.0.5/lib/ruby/4.0.0/rubygems.rb:305:in 'Kernel#load'
	from /opt/containerbase/tools/ruby/4.0.5/lib/ruby/4.0.0/rubygems.rb:305:in 'Gem.activate_and_load_bin_path'
	from /opt/containerbase/tools/bundler/1.17.3/4.0.5/bin/bundler:25:in '<main>'

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 7, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-agent-buildimages | build_dd_agent_testing   View in Datadog   GitLab

ℹ️ Info

🔄 Datadog auto-retried 1 job - 1 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d81cd4f | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d81cd4f2de

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread dd-agent-testing/Gemfile
group :test do
gem "tailor", '~> 1.4.1' # Ruby style
gem "foodcritic", '~> 15.1.0' # Lint testing
gem "foodcritic", '~> 16.3.0' # Lint testing

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the bundled lockfile with foodcritic

This changes the Gemfile to require foodcritic 16.3, but dd-agent-testing/Gemfile.lock is still checked in with foodcritic (15.1.0) and foodcritic (~> 15.1.0) in DEPENDENCIES. The dd-agent-testing image copies both files before bundle install (dd-agent-testing/Dockerfile:50-51), so frozen/deployment installs will reject the bundle and non-frozen Docker builds will resolve an uncommitted lockfile instead of using the reviewed dependency set; please commit the regenerated lockfile with the 16.3.0 resolution.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants