Adding Proxmox Storage Plugin for SANsymphony #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datacore-chiranthjs
requested review from
lblanc,
datacore-rrajamanickam,
Alex130469,
gaetanmarais,
RainerBr and
arun-kv
arun-kv
reviewed
Aug 5, 2025
|
|
||
| multipath -r | ||
| sleep 2 | ||
| multipath -ll 1>/tmp/multipath.ll.$$ |
There was a problem hiding this comment.
Better to use mktemp for creating temporary files, this way we will not have any conflict in the future.
| multipath -r | ||
| sleep 2 | ||
| multipath -ll 1>/tmp/multipath.ll.$$ | ||
| multipath -v3 &>/tmp/multipath.v3.$$ |
There was a problem hiding this comment.
Is there any specific reason for using & (background execution)? On a busy system, this could be delayed, which might cause the logic below to break.
There was a problem hiding this comment.
&> is used to Redirect both stdout and stderr to a file and its not a backgroup execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Proxmox Storage Plugin for SANsymphony
A Proxmox VE storage plugin to integrate SANsymphony storage using iSCSI, with native multipath support and custom CLI management.
This plugin leverages the SANsymphony REST API for all provisioning and management operations.
can refer README.md for usage, config, and troubleshooting.
NOTE: I will be updating the README file once the Public Documentaion is ready.