fix(migration): swap obsolete --primary/--fallback for --backend in L3 scripts#34
Merged
Merged
Conversation
…3 scripts ruflo >=3.7.0-alpha.67 collapsed the dual flag pair into a single --backend flag (memory configure --help). Migration and rollback scripts were calling --primary/--fallback, which the new CLI silently ignores, leaving steps 7 (cutover) and step 2 (rollback) as no-ops. The migration would report SUCCESS while the repo remained on the prior backend. Updates: - scripts/migrate-l2-to-l3.sh step 7: --backend ruvector - scripts/rollback-l3.sh step 2: --backend sqljs - docs/arquetipo/deliverables/memory/MIGRATION-PG.md §7: same swap Out of scope (historical research docs in sprint5/, not actionable runbooks): docs/arquetipo/research/b10-memory-strategy.md:362, sprint5/architecture-design.md:310,334, sprint5/research-findings.md:464,491. Verified: bash -n on both scripts, dry-run shows correct flag. Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruflo >=3.7.0-alpha.67collapsed the old--primary <backend> --fallback <backend>flag pair into a single--backend <backend>flag (verify withruflo memory configure --help). The L3 migration and rollback scripts still called the old form, which the new CLI silently ignores — so step 7 (cutover) and rollback step 2 became no-ops while the scripts reportedSUCCESS.Why this matters
Per the L3 runbook (
MIGRATION-PG.mdstep 7), cutover is what actually flips the repo from sql.js to RuVector. With the stale flag, the migration would complete, the new schema would be populated, butruflo memory store/searchwould keep hitting.swarm/memory.db. The rollback path had the symmetric bug.Discovered during a real migration attempt this turn:
ruflo memory configure --primary ruvector --fallback sqljsreturned no error but did nothing.Changes
scripts/migrate-l2-to-l3.sh--primary ruvector --fallback sqljs--backend ruvectorscripts/rollback-l3.sh--primary sqljs --fallback none--backend sqljsdocs/arquetipo/deliverables/memory/MIGRATION-PG.mdA short comment near each call explains the flag collapse so future readers don't reintroduce the old form.
Out of scope
Five additional references to the obsolete flags live in historical research/design docs under
docs/arquetipo/sprint5/anddocs/arquetipo/research/. Per surgical-changes rule, those are point-in-time records from sprint 5 and were not touched:docs/arquetipo/research/b10-memory-strategy.md:362docs/arquetipo/sprint5/architecture-design.md:310, 334docs/arquetipo/sprint5/research-findings.md:464, 491If we want a clean sweep, that's a separate doc-archive PR.
Behavior change to acknowledge
The new
--backendflag has no "fallback" concept; fallback selection is now runtime-implicit. The runbook line was updated to reflect this. If a teammate relied on the explicit dual-backend chain, this is the moment to surface that.Test plan
bash -n scripts/migrate-l2-to-l3.shpasses.bash -n scripts/rollback-l3.shpasses.bash scripts/migrate-l2-to-l3.sh --dry-runshows the new command:[dry-run] ruflo memory configure --backend ruvector..swarm/memory.dband a healthyruvector-postgrescontainer (deferred to follow-up turn; container is up and healthy, schemaclaude_flow.embeddingsstill pending creation).Co-Authored-By: claude-flow ruv@ruv.net