Fix TriangleVertexArray.cpp
compilation warning
#427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to compile with
-Wreturn-type
and-Werror
flags we get the following error:This is because the end of the
TriangleVertexArray::getVertex
function doesn't have a return statement outside of the else block (which realistically will never get reached, but the compiler still complains). Adding thereturn Vector3::zero()
line fixes the issue:This change makes the
TriangleVertexArray::getVertex
function follow the same return flow as theTriangleVertexArray::getVertex
function: