Connection params #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
execution engine 2 is being rolled out in us-east-1 (and a few other regions) currently. soon, it will become the default engine athena uses worldwide. there are some sql-parsing incompatibilities between the two versions when tables are joined like this ``` form table1 join table2 using (col1, col2) ``` in version 1, it was necessary to specify `col1` as either `table1.col1` or `table2.col1` in the where clause or select clause. however in version 2, that generates an error to ensure compatibility across both versions, the simplest thing to do is to avoid specifying the join as `using (col1, col2)` this pattern is currently used in fetching the database metadata when executing `dbt docs generate`, so I was not able to build docs against athena running on execution engine version 2. with the change, `dbt docs generate` works successfully across both engine versions.
fix `dbt docs generate` for athena execution engines 1 & 2.
fix typo in join column
fix issue resolving tables from views
added ability to specify athena ctas options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.