Run dbt integration tests #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 2, 2020 16:34
Dandandan
reviewed
Jul 2, 2020
README.md
Outdated
|
|
||
| 2. Run the tests: | ||
|
|
||
| _Additionally, you might need to set the `AWS_PROFILE` environment variable_ |
There was a problem hiding this comment.
This is only when the profile is not the default, right? Might make that more clear.
There was a problem hiding this comment.
just added some notes now :)
Dandandan
approved these changes
Aug 8, 2020
|
Thanks a lot @dmateusp ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Support running the shared "behave" integration tests from
dbt-integration-testsagainst dbt-athena (not providing an AWS account / CI for now)Note: Right now the integration tests fail at
dbt seed(pretty early in the tests)Related
I have created an
athena-supportbranch on the EarnestResearch fork of thedbt-integration-testsrepo where I'm pinning thedbt-utilsversion and applying the commits from thepresto-supportbranch (I thought it would be a good starting point), this is the change: dbt-labs/dbt-integration-tests@master...EarnestResearch:athena-support^ The README instruction I'm adding actually use that fork, but we probably want to switch to the main repo before merging