add notes about issue #90
tests.yml
on: push
Internal Tests
58s
Matrix: Integration Tests
Annotations
12 warnings and 1 notice
Integration Tests (stable, 1.0.16)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Internal Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, emibcn/[email protected], andymckay/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
deref which would be done by auto-deref:
json/src/lib.rs#L30
warning: deref which would be done by auto-deref
--> json/src/lib.rs:30:25
|
30 | s.serialize_str(&*hex::encode(b))
| ^^^^^^^^^^^^^^^^ help: try: `&hex::encode(b)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
question mark operator is useless here:
json/src/lib.rs#L35
warning: question mark operator is useless here
--> json/src/lib.rs:35:9
|
35 | Ok(FromHex::from_hex(&hex_str).map_err(D::Error::custom)?)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `FromHex::from_hex(&hex_str).map_err(D::Error::custom)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `#[warn(clippy::needless_question_mark)]` on by default
|
the borrowed expression implements the required traits:
json/src/lib.rs#L35
warning: the borrowed expression implements the required traits
--> json/src/lib.rs:35:30
|
35 | Ok(FromHex::from_hex(&hex_str).map_err(D::Error::custom)?)
| ^^^^^^^^ help: change this to: `hex_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
deref which would be done by auto-deref:
json/src/lib.rs#L46
warning: deref which would be done by auto-deref
--> json/src/lib.rs:46:48
|
46 | Some(ref b) => s.serialize_str(&*hex::encode(b)),
| ^^^^^^^^^^^^^^^^ help: try: `&hex::encode(b)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
the borrowed expression implements the required traits:
json/src/lib.rs#L52
warning: the borrowed expression implements the required traits
--> json/src/lib.rs:52:39
|
52 | Ok(Some(FromHex::from_hex(&hex_str).map_err(D::Error::custom)?))
| ^^^^^^^^ help: change this to: `hex_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
this import is redundant:
client/src/client.rs#L9
warning: this import is redundant
--> client/src/client.rs:9:1
|
9 | use jsonrpc;
| ^^^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|
this import is redundant:
client/src/client.rs#L10
warning: this import is redundant
--> client/src/client.rs:10:1
|
10 | use serde;
| ^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
|
this import is redundant:
client/src/client.rs#L11
warning: this import is redundant
--> client/src/client.rs:11:1
|
11 | use serde_json;
| ^^^^^^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
|
the following explicit lifetimes could be elided: 'b:
client/src/client.rs#L73
warning: the following explicit lifetimes could be elided: 'b
--> client/src/client.rs:73:24
|
73 | fn handle_defaults<'a, 'b>(
| ^^
74 | args: &'a mut [serde_json::Value],
75 | defaults: &'b [serde_json::Value],
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
73 ~ fn handle_defaults<'a>(
74 | args: &'a mut [serde_json::Value],
75 ~ defaults: &[serde_json::Value],
|
|
the borrowed expression implements the required traits:
client/src/client.rs#L156
warning: the borrowed expression implements the required traits
--> client/src/client.rs:156:25
|
156 | &[into_json(&subnet)?, into_json("add")?, into_json(&bantime)?, into_json(&absolute)?],
| ^^^^^^^ help: change this to: `subnet`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
8 tests found
There are 8 tests, see "Raw output" for the full list of tests.
|