Skip to content

Fix pastel network #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DaFuqs merged 2 commits into from
Jul 7, 2025
Merged

Fix pastel network #749

DaFuqs merged 2 commits into from
Jul 7, 2025

Conversation

@EgrorBs
Copy link
Contributor

@EgrorBs EgrorBs commented Jul 7, 2025

  • Information about the pastel network graphs is not saved/loaded when saving the world/chunk
  • Nodes don't call initializeNode on loading
  • When painting a node, a pastel network may be created with an already existing UUID (with old color, and attached nodes), which leads to the node's malfunction after painting/repainting
  • Pastel node painting only works with slingshots, which I don't think was the intended design
  • Pastel node colors are not saved

Changes:

  • Graph information is now saved and loaded from spectrum_pastel_network_manager.dat (as intended, I believe)
  • Node calls initializeNode as soon as it ticks for the first time (I couldn't find a reliable onLoad() method)
  • Network UUID is now generated randomly
  • Pastel node painting now works with either paintbrushes or pigment bottles
  • Pastel node colors are now saved with the BlockEntity NBT data.
  • Paintbrush's tryColorBlock() now returns true when a ColorableBlock is successfully painted (as intended, I believe)

EgrorBs added 2 commits July 7, 2025 02:02
@EgrorBs
fix: Pastel network save/load
3caaa14 
- Save/load pastel network graphs to world save
- Initialize NodeBlockEntity on load (attach to network)
@EgrorBs
fix: Pastel network node coloring
10f781a 
- Save node color to BlockEntity NBT data
- Network UUID should be random, any node can create multiple networks of different colors
- Allow to color node with pignment
- Allow to color node with paintbrush
DaFuqs
DaFuqs approved these changes Jul 7, 2025
View reviewed changes
Copy link
Owner

@DaFuqs DaFuqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

I'll give it another round of tests just to make sure

@DaFuqs DaFuqs merged commit b17a5f8 into DaFuqs:1.21.1-aria-for-painters-mojmap Jul 7, 2025
2 checks passed
@EgrorBs EgrorBs deleted the fix/pastel_network branch July 7, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaFuqs DaFuqs DaFuqs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EgrorBs @DaFuqs