Fix kindling advancements #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sounds about right, ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the ability to turn memories into heads, it's possible to bypass the "hatch a kindling from a memory" check by turning your memory into a head and then a spawner, which prevents you from unlocking feathers or bloodstone until you hatch a kindling the "proper" way. This fixes that issue by allowing
spectrum:remember_kindlingto trigger when you interact with a kindling in-world, so long as you've already unlocked the memory recipe. It also makesspectrum:pluck_effulgent_featherhidden until you unlock it, both to prevent spoiling the RUN and to prevent it from appearing in the advancement tree with a shrouded item for an icon.The change to
spectrum:remember_kindlingdoes mean that it will trigger immediately upon unlocking the memory recipe if you've already interacted with a kindling somehow (ie someone else's kindling on a multiplayer server), but I think that's an OK price to pay in exchange for fixing the spawner bypass.