Bandaid fix for ink unlocking issue #558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #557 by making
spectrum:milestones/unlock_ink_usealso trigger from having an Ink Flask in your inventory.The flask recipe unlocks from the existing advancement
spectrum:unlocks/items/basic_ink_storage_itemsrather than the newspectrum:milestones/unlock_ink_use, so players should have access to flasks even while lackingspectrum:milestones/unlock_ink_usedue to the bug.This does not fix the larger issue behind this bug - namely, that newly added advancements using the
revelationary:advancement_gottentrigger will be unobtainable in worlds where the triggering advancement has already been obtained.