Split Raw and formatted output for metric values

src/Result/Group.php

@@ -45,7 +45,7 @@ public function toArray(): array
         foreach ($this->metrics as $metric) {
             $metricsAsArray[$metric->identifier] = [
                 'title' => $metric->title,
-                'value' => $metric->value->compute(),
+                'value' => $metric->value->format(),
             ];
         }
 

src/Result/Metric/IntegerValue.php

@@ -10,7 +10,12 @@ public function __construct(public int $value)
     {
     }
 
-    public function compute(): int
+    public function getRaw(): int
+    {
+        return $this->format();
+    }
+
+    public function format(): int
     {
         return $this->value;
     }

src/Result/Metric/Table.php

@@ -19,7 +19,13 @@ public function __construct(
     }
 
     /** @return list<list<mixed>> */
-    public function compute(): array
+    public function getRaw(): array
+    {
+        return $this->format();
+    }
+
+    /** @return list<list<mixed>> */
+    public function format(): array
     {
         return array_merge([$this->columns], $this->rows);
     }

src/Result/Metric/Value.php

@@ -6,5 +6,7 @@
 
 interface Value
 {
-    public function compute(): mixed;
+    public function getRaw(): mixed;
+
+    public function format(): mixed;
 }

tests/Collector/CollectorTest.php

@@ -11,6 +11,7 @@
 use Panaly\Result\Result;
 use Panaly\Test\Double\MemoryFileProvider;
 use PHPUnit\Framework\TestCase;
+use Throwable;
 
 class CollectorTest extends TestCase
 {
@@ -46,10 +47,58 @@ public function testCollectingMetricsWithResults(): void
         self::assertCount(2, $metrics);
 
         self::assertSame('I am a default title', $metrics[0]->title);
-        self::assertSame(12, $metrics[0]->value->compute());
+        self::assertSame(12, $metrics[0]->value->format());
 
         self::assertSame('I am a default title', $metrics[1]->title);
-        self::assertSame(12, $metrics[1]->value->compute());
+        self::assertSame(12, $metrics[1]->value->format());
+    }
+
+    public function testInvalidConfigurationFile(): void
+    {
+        $this->expectException(Throwable::class);
+
+        $fixtureFile        = __DIR__ . '/../Fixtures/invalid-config.yaml';
+        $memoryFileProvider = new MemoryFileProvider();
+        $memoryFileProvider->addFixture($fixtureFile);
+
+        $this->getResultFromConfigFile($memoryFileProvider, $fixtureFile);
+    }
+
+    public function testNoFixtures(): void
+    {
+        $memoryFileProvider = new MemoryFileProvider();
+
+        $this->expectException(Throwable::class);
+
+        $this->getResultFromConfigFile($memoryFileProvider, 'non-existent-file.yaml');
+    }
+
+    public function testMultipleGroups(): void
+    {
+        $fixtureFile        = __DIR__ . '/../Fixtures/valid-config-multiple-groups.yaml';
+        $memoryFileProvider = new MemoryFileProvider();
+        $memoryFileProvider->addFixture($fixtureFile);
+
+        $collectionResult = $this->getResultFromConfigFile($memoryFileProvider, $fixtureFile);
+
+        $groups = $collectionResult->getGroups();
+        self::assertCount(2, $groups);
+        self::assertSame('Group 1', $groups[0]->getTitle());
+        self::assertSame('Group 2', $groups[1]->getTitle());
+    }
+
+    public function testNoMetrics(): void
+    {
+        $fixtureFile        = __DIR__ . '/../Fixtures/valid-config-no-metrics.yaml';
+        $memoryFileProvider = new MemoryFileProvider();
+        $memoryFileProvider->addFixture($fixtureFile);
+
+        $collectionResult = $this->getResultFromConfigFile($memoryFileProvider, $fixtureFile);
+
+        $groups = $collectionResult->getGroups();
+        self::assertCount(1, $groups);
+        self::assertSame('Group with no metrics', $groups[0]->getTitle());
+        self::assertCount(0, $groups[0]->getMetrics());
     }
 
     private function getResultFromConfigFile(MemoryFileProvider $fileProvider, string $file): Result

tests/Fixtures/valid-config-multiple-groups.yaml

@@ -0,0 +1,19 @@
+plugins:
+  Panaly\Test\Fixtures\Plugin\TestPlugin: ~
+
+groups:
+  foo:
+    title: "Group 1"
+    metrics:
+      a_static_integer: ~
+  bar:
+    title: "Group 2"
+    metrics:
+      a_static_integer: ~
+
+storage:
+  json:
+    path: var/metric_storage
+
+reporting:
+  html_report: ~

tests/Fixtures/valid-config-no-metrics.yaml

@@ -0,0 +1,14 @@
+plugins:
+  Panaly\Test\Fixtures\Plugin\TestPlugin: ~
+
+groups:
+  empty_group:
+    title: "Group with no metrics"
+    metrics: []
+
+storage:
+  json:
+    path: var/metric_storage
+
+reporting:
+  html_report: ~

tests/Result/Metric/TableResultTest.php

@@ -6,6 +6,7 @@
 
 use Panaly\Result\Metric\Table;
 use PHPUnit\Framework\TestCase;
+use Throwable;
 
 class TableResultTest extends TestCase
 {
@@ -18,7 +19,39 @@ public function testTableResultLooksFine(): void
 
         self::assertSame(
             [['foo', 'bar'], ['bar', 12], ['baz', 13]],
-            $metric->compute(),
+            $metric->format(),
         );
     }
+
+    public function testEmptyColumnsAndRows(): void
+    {
+        $metric = new Table([], []);
+        self::assertSame([[]], $metric->format());
+    }
+
+    public function testSingleColumnAndRow(): void
+    {
+        $metric = new Table(['foo'], [['bar']]);
+        self::assertSame([['foo'], ['bar']], $metric->format());
+    }
+
+    public function testMixedDataTypes(): void
+    {
+        $metric = new Table(['foo', 'bar'], [['bar', 12], ['baz', 13.5], ['qux', true]]);
+        self::assertSame(
+            [['foo', 'bar'], ['bar', 12], ['baz', 13.5], ['qux', true]],
+            $metric->format(),
+        );
+    }
+
+    public function testImmutability(): void
+    {
+        $metric = new Table(['foo'], [['bar']]);
+        try {
+            $metric->columns = ['new']; // @phpstan-ignore-line because it is readonly
+            self::fail('Expected Error due to readonly property');
+        } catch (Throwable $e) {
+            self::assertSame('Cannot modify readonly property Panaly\Result\Metric\Table::$columns', $e->getMessage());
+        }
+    }
 }