Applying changes to display properly the input warnings and submit form button - #6169
Open
abelc-escire wants to merge 3 commits into
Open
Applying changes to display properly the input warnings and submit form button#6169abelc-escire wants to merge 3 commits into
abelc-escire wants to merge 3 commits into
Conversation
Contributor
|
Thank you for the fix @abelc-escire! Would you be able to include the "Description" section from the PR template with just a quick summary of the implementation? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #6166
Description
The validation for the process creation form has been corrected to prevent submission unless a script has been selected. Previously, it was possible to click "Submit" without selecting a script, which caused errors. Now, the button is automatically disabled until a script is selected and the form is valid. Additionally, validation errors in the script selector are displayed immediately upon attempting to submit, even if the field had not been interacted with previously.
Instructions for Reviewers
Applying changes to fix and display the input warnings on new process creation and the submit form button.
To reproduce
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.