Skip to content

Applying changes to display properly the input warnings and submit form button - #6169

Open
abelc-escire wants to merge 3 commits into
DSpace:mainfrom
abelc-escire:fix/issue-6166
Open

Applying changes to display properly the input warnings and submit form button#6169
abelc-escire wants to merge 3 commits into
DSpace:mainfrom
abelc-escire:fix/issue-6166

Conversation

@abelc-escire

@abelc-escire abelc-escire commented Aug 31, 2026

Copy link
Copy Markdown

References

Fixes #6166

Description

The validation for the process creation form has been corrected to prevent submission unless a script has been selected. Previously, it was possible to click "Submit" without selecting a script, which caused errors. Now, the button is automatically disabled until a script is selected and the form is valid. Additionally, validation errors in the script selector are displayed immediately upon attempting to submit, even if the field had not been interacted with previously.

Instructions for Reviewers

Applying changes to fix and display the input warnings on new process creation and the submit form button.

To reproduce

  1. Log in as admin
  2. Navigate to /processes/new
  3. Enter a process name that does not exist/not enter a value
  4. Click the 'Save' button won't be enabled until the form is valid.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug 1 APPROVAL pull request only requires a single approval to merge ux User Experience related works tools:processes Related to Scripts & Processes (new to DSpace 7) port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Sep 1, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Sep 1, 2026
@lgeggleston

Copy link
Copy Markdown
Contributor

Thank you for the fix @abelc-escire! Would you be able to include the "Description" section from the PR template with just a quick summary of the implementation? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release tools:processes Related to Scripts & Processes (new to DSpace 7) ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Create a new process: no feedback when invalid name is entered

2 participants