Skip to content

Handle pre-contest clarifications #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Handle pre-contest clarifications #3174

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0071234
Warn jury for clarifications before contest start
vmcj Oct 26, 2025
d54c96e
Prevent clarifications before the contest without explicit time
vmcj Oct 26, 2025
4706e75
Display pre-contest clarifications
vmcj Oct 26, 2025
1f77c9a
Allow teams to request clarifications before the contest
vmcj Oct 26, 2025
8342cf2
Don't display clarification time from before contest
vmcj Oct 26, 2025
c8c97ec
Don't reference undisclosed problems in clarifications before contest…
vmcj Oct 26, 2025
3a60f88
Don't display clarifications about non-disclosed problems yet
vmcj Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions webapp/templates/team/partials/index_content.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
<h2 id="contestnotstarted" class="text-center">
Contest {{ contest | printContestStart }}
</h2>
{% if clarifications is not empty %}
Copy link
Member

@meisterT meisterT Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking a little bit more: when do we send out "static events" in the event feed? Do we do that on state changes? Then hiding them in the API is perhaps not too much code complexity, but one would have to implement it to really see.

Copy link
Member Author

@vmcj vmcj Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand.

Copy link
Member

@meisterT meisterT Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best described in person - @nickygerritsen, is my understanding correct that static events are created on state changes?

Copy link
Member

@nickygerritsen nickygerritsen Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarifications are not static events. But we send them out here, so when a dependency is missing basically.

Copy link
Member

@meisterT meisterT Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, needs more thought

<h1 class="teamoverview">Clarifications</h1>
{% include 'team/partials/clarification_list.html.twig' with {clarifications: clarifications} %}
{% endif %}
{% else %}

<div id="teamscoresummary">
Expand Down