Version control javascript libraries with NPM

[vmcj]

NPM is another packagemanager for JS. So we use composer first and when we can't find the package there we check with npm.

This change does require more changes for maintainer-install & any checkout.

If we do this it makes introducing MathJax a lot easier and we can now also version control other javascript libraries.

[nickygerritsen]

If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies

[vmcj]

If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies

So also remove JS dependencies in composer and add them in npm? I'm fine with either of the 2 but for adaptation doing it in composer is an easier learningpath.

I somehow never used yarn but if that's the better of the 2 but I have no experience with that translation path.

I also think we should only do this in the next release so we have some time to discuss.

[nickygerritsen]

If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies

So also remove JS dependencies in composer and add them in npm? I'm fine with either of the 2 but for adaptation doing it in composer is an easier learningpath.

I somehow never used yarn but if that's the better of the 2 but I have no experience with that translation path.

I also think we should only do this in the next release so we have some time to discuss.

I think it doesn't make sense to have 2 package managers for frontend dependencies, that's why I suggest using npm (or yarn, which can read the same package.json file) for all.

[vmcj]

The other packages are harder to either find (dataTables) or don't work 1-on-1 (font-awesome). I'll look at those in another PR. Reviewing is easiest commit by commit and by just skipping the monaco one as that's the one touching most files.

[nickygerritsen]

We need to update the docs for yarn as well and later update the Docker images.

[vmcj]

We need to update the docs for yarn as well
I think I already mention yarn in the docs? So what is missing?

and later update the Docker images.
Yes, and ansible will also need it.

[nickygerritsen]

We need to update the docs for yarn as well
I think I already mention yarn in the docs? So what is missing?

and later update the Docker images.
Yes, and ansible will also need it.

sorry i missed it. it's missing for fedora though

[eldering]

These should (all, also composer-dependencies-dev below) be added as phony dependencies under .PHONY to make it clear that no actual target with this name gets created.

[eldering]

Hmmm, I see that composer-dependencies{,-dev} are actually recursive targets from the root Makefile, so that should then be renamed there too.

[vmcj]

I think I already renamed the composer-dependencies{,-dev} to dependencies{,-dev} in all files (so also the root one). I've now added the .PHONY targets in the webapp/Makefile. I think that's what you meant?

[eldering]

Adding the phony targets here is not strictly necessary, as recursive targets are already marked phony in https://github.com/DOMjudge/domjudge/blob/main/Makefile.global#L94, but this doesn't hurt.