Improve error message on inconsistent ZIP files. #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
approved these changes
May 4, 2024
|
We should also backport this. |
When using the graphical ZIP compress options on Mac OS or Ubuntu, the resulting ZIP archive will be inconsistent, tripping up `libzip`. With `ziptool` you could provoke the error to learn more about the inconsistency but that is unfortunately not available in PHP: ``` can't open zip archive 'a.zip': Zip archive inconsistent: entry 2: local and central headers do not match ``` `libzip` worked around this in nih-at/libzip@b3e3b19 which was released in https://github.com/nih-at/libzip/releases/tag/v1.10.1 but that version didn't make it into even unstable Debian/Ubuntu distributions yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the graphical ZIP compress options on Mac OS or Ubuntu, the resulting ZIP archive will be inconsistent, tripping up
libzip.With
ziptoolyou could provoke the error to learn more about the inconsistency but that is unfortunately not available in PHP:libzipworked around this innih-at/libzip@b3e3b19 which was released in
https://github.com/nih-at/libzip/releases/tag/v1.10.1 but that version didn't make it into even unstable Debian/Ubuntu distributions yet.