Skip to content

Catch errors when adding problems YAML. #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2024

Conversation

nickygerritsen
Copy link
Member

Fixes #2482.

@nickygerritsen
Copy link
Member Author

I somehow can't comment on your second remark, but yeah hasErrors is a more global scope. I will add a linebreak and maybe even a comment.

@vmcj
Copy link
Member

vmcj commented Apr 27, 2024

I somehow can't comment on your second remark, but yeah hasErrors is a more global scope. I will add a linebreak and maybe even a comment.

You can here: #2508 (comment) it's a response to your response on my message. GitHub displays that in a really ugly way.

@nickygerritsen nickygerritsen force-pushed the problem-import-errors branch from 6663724 to 4b3450e Compare May 1, 2024 09:04
Copy link
Member

@eldering eldering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickygerritsen nickygerritsen added this pull request to the merge queue May 3, 2024
Merged via the queue into DOMjudge:main with commit 2b19b81 May 3, 2024
21 checks passed
@nickygerritsen nickygerritsen deleted the problem-import-errors branch May 3, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle invalid RGB value in problemset
3 participants