CHORE: Update old Go module path in flattener.js#4262
Merged
TomOnTime merged 1 commit intoMay 14, 2026
Conversation
- Replace `github.com/StackExchange/dnscontrol/v4` with `github.com/DNSControl/dnscontrol/v4` in the compiled GopherJS output.
TomOnTime
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPF flattener web tool (
docs/flattener/) is compiled from Go to JavaScript using GopherJS. The compiled outputflattener.jsstill contains the old Go module pathgithub.com/StackExchange/dnscontrol/v4from before the repository migration. The source filejs.goalready uses the correctgithub.com/DNSControl/dnscontrol/v4path, but the compiled JavaScript was never regenerated.This replaces all 9 occurrences of the old path in the GopherJS package registry and type metadata with a single sed command:
sed -i 's|github.com/StackExchange/dnscontrol/v4|github.com/DNSControl/dnscontrol/v4|g' docs/flattener/flattener.jsThe source map (
flattener.js.map) contained no old paths and required no changes.Verified by opening
docs/flattener/index.htmlin a browser and performing a lookup.Closes #4219.