Skip to content
Merged
Show file tree
Hide file tree
Changes from 80 commits
Commits
Show all changes
113 commits
Select commit Hold shift + click to select a range
6f7ce4c
Updated app to rails 7
benjaminfaure Jun 13, 2024
bda5b6e
Made rubocop happy
benjaminfaure Jun 14, 2024
0e544e4
Edit "Setup Credentials" step within workflows
aaronskiba Jul 6, 2024
5801e7f
Edit copy of credentials file within `bin/setup`
aaronskiba Jul 6, 2024
727c2e8
Disable Spring during workflows/ db build
aaronskiba Jul 8, 2024
1fe50c4
Undo Rubocop `Style/SymbolProc`-related fixes
aaronskiba Jul 8, 2024
283e585
Make Rubocop happy
aaronskiba Jul 9, 2024
595e013
Fix breaking template.visibilty tests
aaronskiba Jul 10, 2024
15e4d4d
Refactor template.visibility w/ Rails enum method
aaronskiba Jul 10, 2024
4bd0e9a
Fix `template.visibilty` checkbox behaviour
aaronskiba Jul 10, 2024
d06f436
Fix handling of JSON payload in API auth tests
aaronskiba Jul 15, 2024
5d06d6b
Fix `@rails/ujs` init / use ES6 module syntax
aaronskiba Jul 18, 2024
bfa2ae3
Bullet fixes for `/super_admin/api_clients`
aaronskiba Jul 23, 2024
935433c
Bullet fixes for `/public_plans`
aaronskiba Jul 23, 2024
a079c57
Bullet fixes for `/org_admin/plans` (superuser)
aaronskiba Jul 23, 2024
a07d344
Make Rubocop happy
aaronskiba Jul 23, 2024
36e5b7d
Fix for bug in Plan duplication results in original plan identifier b…
Jul 29, 2024
20b5e14
Fix for bug in Plan duplication results in original plan identifier b…
Jul 30, 2024
76cbb2b
Fix for #3443 - bar chart click function broken in usage dashboard
gjacob24 Jul 31, 2024
8f18468
Added entry in CHANGELOG.md
gjacob24 Jul 31, 2024
d2a1eac
Merge pull request #3435 from DMPRoadmap/aaron/rails7-copy
aaronskiba Aug 19, 2024
a670f5e
Fix "pass class as a kwarg" deprecation warnings
aaronskiba Aug 20, 2024
68af924
Fix `action_dispatch` deprecation warning
aaronskiba Aug 20, 2024
10852d4
Removed eslint disable for no-underscore-dangle
gjacob24 Aug 21, 2024
ae27a0d
Fix flaky tests / optimize checking of page title
aaronskiba Aug 29, 2024
f25763c
Merge pull request #3449 from DMPRoadmap/aaron/rails7-copy
aaronskiba Sep 5, 2024
48b7c68
Pinned Rails JS dependencies to 7.1 & updated dependencies
benjaminfaure Sep 10, 2024
c24a776
Make Rubocop happy
aaronskiba Oct 31, 2024
1b34730
Merge pull request #3426 from DMPRoadmap/rails7
benjaminfaure Nov 18, 2024
03389e8
Merge branch 'development' into aaron/issues/3450
benjaminfaure Nov 18, 2024
0f263f7
Merge pull request #3451 from DMPRoadmap/aaron/issues/3450
benjaminfaure Nov 18, 2024
96a4f59
Merge pull request #3444 from DMPRoadmap/issue_3443_usage_dashboard_b…
benjaminfaure Nov 18, 2024
747acf2
Merge branch 'development' into plan-deep-copy-bug-copies-old-id-as-i…
benjaminfaure Nov 18, 2024
994bb60
Merge pull request #3441 from DMPRoadmap/plan-deep-copy-bug-copies-ol…
benjaminfaure Nov 18, 2024
4b25e4a
Refactor deep_copy: Remove redundant `plan.save!`
aaronskiba Dec 11, 2024
d8f8978
Refactor / use ActiveRecord association operator
aaronskiba Dec 11, 2024
521ba8e
Add test for plan identifier copying
aaronskiba Dec 11, 2024
d6687c8
Merge branch 'development' into aaron/bullet-fixes
aaronskiba Dec 11, 2024
a5f5b53
Merge pull request #3440 from DMPRoadmap/aaron/bullet-fixes
aaronskiba Dec 11, 2024
98ac61c
Merge branch 'development' into aaron/refactor-plan-deep-copy
johnpinto1 Dec 13, 2024
f0a3ecf
Update CHANGELOG.md
aaronskiba Dec 16, 2024
2d707d5
Merge pull request #3469 from DMPRoadmap/aaron/refactor-plan-deep-copy
aaronskiba Dec 16, 2024
90a4809
The V1 API docs link in Edit profile > API access tab was broken.
Dec 16, 2024
d9279dc
Merge pull request #3470 from DMPRoadmap/fix-for-broken-v1-api-doc-link
aaronskiba Jan 27, 2025
434074a
Add feature test for research_output associations
aaronskiba Feb 13, 2025
b417f28
Fix `hidden_field_tag` params for Rails 7 upgrade
aaronskiba Feb 13, 2025
527c347
Update CHANGELOG.md
aaronskiba Feb 13, 2025
8a7d832
Fix GH Action test: `data-bs-dismiss` modal close
aaronskiba Feb 13, 2025
a025258
Merge pull request #3479 from portagenetwork/aaron/upstream/issues/3478
aaronskiba Mar 12, 2025
8982664
Add pdf handling in render_respond_to_format_with_error_message
aaronskiba Apr 19, 2024
7bf3d29
Update CHANGELOG.md
aaronskiba Mar 14, 2025
b1d1e63
Update all workflows to `runs-on: ubuntu-22.04`
aaronskiba Mar 17, 2025
8481661
Update CHANGELOG.md
aaronskiba Mar 17, 2025
627a47f
Extract full semvers in Danger workflow
aaronskiba Mar 17, 2025
46389a1
Replace deprecated `setup-ruby` action
aaronskiba Mar 17, 2025
748a94f
TEMP: Lower Chrome Version for Postgres GH Action
aaronskiba Mar 20, 2025
fb2d871
Refactor `spec/features/modal_search_spec.rb`
aaronskiba Mar 20, 2025
383a2f0
Refactor to make rubocop happy
aaronskiba Mar 20, 2025
cd3f480
Update CHANGELOG.md
aaronskiba Mar 20, 2025
6a49bd6
Merge pull request #3491 from DMPRoadmap/aaron/issues/downgrade-chrome
aaronskiba Mar 24, 2025
65253e0
Merge branch 'development' into aaron/issues/3414
aaronskiba Mar 24, 2025
097372c
Merge pull request #3482 from DMPRoadmap/aaron/issues/3414
aaronskiba Mar 24, 2025
bdf3d6d
`bundle update && yarn upgrade`
aaronskiba Mar 14, 2025
cc7e00f
Migrate to RuboCop extensions using plugins
aaronskiba Mar 14, 2025
7169ea1
`rubocop -A`
aaronskiba Mar 14, 2025
d738fd9
Make rubocop happy
aaronskiba Mar 14, 2025
61171b3
yarn add --dev @babel/plugin-syntax-dynamic-import
aaronskiba Mar 14, 2025
b20e952
Refactor handling of ENV vars in postgres workflow
aaronskiba Mar 14, 2025
0e3df33
Update CHANGELOG.md
aaronskiba Mar 24, 2025
ebb34ef
Merge branch 'development' into aaron/issues/3484
aaronskiba Mar 24, 2025
c303871
Update all workflows to `runs-on: ubuntu-24.04`
aaronskiba Mar 24, 2025
027fa4a
Install `imagemagick` in Postgres Workflow
aaronskiba Mar 24, 2025
c7b9b48
Consolidate Capybara config
aaronskiba Mar 24, 2025
41b9169
Update CHANGELOG.md
aaronskiba Mar 24, 2025
141e7cf
Merge pull request #3487 from DMPRoadmap/aaron/issues/3484
aaronskiba Mar 25, 2025
d59ff79
Merge branch 'development' into aaron/bundler-update-yarn-upgrade
aaronskiba Mar 25, 2025
5ebffd6
Revert "yarn add --dev @babel/plugin-syntax-dynamic-import"
aaronskiba Mar 25, 2025
bcda450
Remove redundant plugin from `babel.config.js`
aaronskiba Mar 25, 2025
ad67842
Merge pull request #3483 from DMPRoadmap/aaron/bundler-update-yarn-up…
aaronskiba Mar 26, 2025
9c7bd73
Add missing CHANGELOG entries
aaronskiba Mar 26, 2025
d669ac5
Add `coder :YAML` to `serialize` for Rails 7.1
aaronskiba Mar 26, 2025
f26b54f
Match `config.load_defaults` to Rails (v7.1)
aaronskiba Mar 26, 2025
76cc7eb
Update CHANGELOG.md
aaronskiba Mar 26, 2025
c5fd8af
Fix issues with Conditional question serialization (offered by @briri
Mar 27, 2025
7ffc815
`bin/rails db:migrate`
aaronskiba Mar 27, 2025
da93d72
Fix for Conditional model bug for the webhook_data which was typed as a
Apr 2, 2025
dba3999
Updated the comment for param_conditions parameter for method
Apr 3, 2025
a58017c
Updated the check (!conditions.nil? && conditions.any?) in tag
Apr 3, 2025
1226803
Remove unused `serialize :prefs` from User model
aaronskiba Apr 3, 2025
06b0db5
Updated the tag in app/views/org_admin/conditions/_form.html.erb
Apr 4, 2025
739aad0
Refactor mapping of `remove_data` & `option_list`
aaronskiba Apr 4, 2025
f6a232b
Refactor webhook_data validation and construction
aaronskiba Apr 4, 2025
82984e2
Refactor handling of `c.option_list.empty?`
aaronskiba Apr 4, 2025
49b9f7d
Refactor option_list and remove_data handling
aaronskiba Apr 4, 2025
115ea70
Put back `# rubocop:disable Metrics/MethodLength`
aaronskiba Apr 4, 2025
0fde253
Update CHANGELOG.md
aaronskiba Apr 7, 2025
0c2e2d2
Document callers of conditions/form partial
aaronskiba Apr 7, 2025
c879520
Merge pull request #3501 from DMPRoadmap/aaron/refactor-question-save…
aaronskiba Apr 7, 2025
97677d4
Remove commented-out code
aaronskiba Apr 7, 2025
c7abc11
Remove unused variable from conditions/form
aaronskiba Apr 7, 2025
b2eaac4
Replace `condition_exists` w/ `condition.present?`
aaronskiba Apr 7, 2025
e651186
Remove redundant `type_default` variable
aaronskiba Apr 7, 2025
dc04625
Remove redundant conditional check
aaronskiba Apr 7, 2025
5d0ec1e
Remove redundant conditional check
aaronskiba Apr 8, 2025
3a11067
Refactor: Split conditions/_form into two
aaronskiba Apr 8, 2025
4724bc7
Cleanup after `condtions/_form` refactor
aaronskiba Apr 8, 2025
8f952be
Update CHANGELOG.md
aaronskiba Apr 9, 2025
ae5786e
Merge branch 'johnpinto1-updated-port-of-dmptool-conditional-question…
aaronskiba Apr 9, 2025
478fdad
Merge pull request #3502 from DMPRoadmap/aaron/refactor-conditions-form
aaronskiba Apr 9, 2025
c0f6981
Enable translations with gettext method
aaronskiba Apr 9, 2025
9572e01
Merge pull request #3497 from DMPRoadmap/johnpinto1-updated-port-of-d…
aaronskiba Apr 9, 2025
325b49f
Merge branch 'development' into aaron/config.load_defaults-7.1
aaronskiba Apr 9, 2025
3506e05
Merge pull request #3496 from DMPRoadmap/aaron/config.load_defaults-7.1
aaronskiba Apr 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/brakeman.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
brakeman:

runs-on: ubuntu-20.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v2
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/danger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@ on: [push, pull_request]

jobs:
danger:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v3

- name: 'Determine Ruby and Bundler Versions from Gemfile.lock'
run: |
echo "RUBY_VERSION=`cat ./Gemfile.lock | grep -A 1 'RUBY VERSION' | grep 'ruby' | grep -oE '[0-9]\.[0-9]'`" >> $GITHUB_ENV
echo "BUNDLER_VERSION=`cat ./Gemfile.lock | grep -A 1 'BUNDLED WITH' | grep -oE '[0-9]\.[0-9]'`" >> $GITHUB_ENV
echo "RUBY_VERSION=`cat ./Gemfile.lock | grep -A 1 'RUBY VERSION' | grep 'ruby' | grep -oE '[0-9]+\.[0-9]+\.[0-9]+'`" >> $GITHUB_ENV
echo "BUNDLER_VERSION=`cat ./Gemfile.lock | grep -A 1 'BUNDLED WITH' | grep -oE '[0-9]+\.[0-9]+\.[0-9]+'`" >> $GITHUB_ENV

# Install Ruby - using the version found in the Gemfile.lock
- name: 'Install Ruby'
uses: actions/setup-ruby@v1
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ env.RUBY_VERSION }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/eslint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on: [push, pull_request]
jobs:
eslint:

runs-on: ubuntu-20.04
runs-on: ubuntu-24.04

steps:
# Checkout the repo
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/mysql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [pull_request]

jobs:
mysql:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04

# Define environment variables for MySQL and Rails
env:
Expand Down Expand Up @@ -38,7 +38,7 @@ jobs:

# Stub out the Rails credentials file so that we can start the Rails app
- name: 'Setup Credentials'
run: EDITOR='echo "$(cat config/credentials.yml.mysql2)" >' bundle exec rails credentials:edit
run: EDITOR="sh -c 'echo \"$(cat config/credentials.yml.mysql2)\" > \$1' --" bundle exec rails credentials:edit

# Set the path to the wkhtmltopdf executable
- name: 'Determine wkhtmltopdf location'
Expand All @@ -54,8 +54,8 @@ jobs:

- name: 'Build out the test database'
run: |
bundle exec rails db:create RAILS_ENV=test
bundle exec rails db:schema:load RAILS_ENV=test
DISABLE_SPRING=1 bundle exec rails db:create RAILS_ENV=test
DISABLE_SPRING=1 bundle exec rails db:schema:load RAILS_ENV=test

- name: 'Run any pending database migrations'
run: bin/rails db:migrate RAILS_ENV=test
Expand Down
26 changes: 22 additions & 4 deletions .github/workflows/postgres.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [pull_request]

jobs:
postgresql:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04

services:
# Postgres installation
Expand All @@ -27,6 +27,7 @@ jobs:
env:
RAILS_ENV: test
DATABASE_URL: postgres://postgres:@localhost:5432/roadmap_test
DISABLE_SPRING: 1

steps:
# Checkout the repo
Expand All @@ -52,6 +53,11 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install libpq-dev

# Install ImageMagick (for `identify` command)
- name: 'Install ImageMagick'
run: |
sudo apt-get install -y imagemagick

# Copy all of the example configs over
- name: 'Setup Default Configuration'
Expand All @@ -65,7 +71,7 @@ jobs:
- name: 'Setup Credentials'
run: |
# generate a default credential file and key
EDITOR='echo "$(cat config/credentials.yml.postgresql)" >' bundle exec rails credentials:edit
EDITOR="sh -c 'echo \"$(cat config/credentials.yml.postgresql)\" > \$1' --" bundle exec rails credentials:edit

# Set the path to the wkhtmltopdf executable
- name: 'Determine wkhtmltopdf location'
Expand All @@ -75,12 +81,24 @@ jobs:
- name: 'Yarn Install'
run: |
yarn install

# TEMPORARY WORKAROUND FOR THE FOLLOWING ISSUE: https://github.com/DMPRoadmap/roadmap/issues/3485
# Remove this once our tests are compatible with the new version of Chrome
# Source: https://github.com/teamcapybara/capybara/issues/2800#issuecomment-2731100953
- name: Remove image-bundled Chrome
run: sudo apt-get purge google-chrome-stable
- name: Setup stable Chrome
uses: browser-actions/setup-chrome@v1
with:
chrome-version: 128
install-chromedriver: true
install-dependencies: true

# Initialize the DB
- name: 'Setup Test DB'
run: |
bundle exec rails db:setup RAILS_ENV=test
bundle exec rails db:migrate RAILS_ENV=test
bundle exec rails db:setup
bundle exec rails db:migrate

# Prebuild the CSS, JS and image assets
- name: 'Compile Assets'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]

jobs:
rubocop:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04

steps:
# Checkout the repo
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#
# Try to place any new Cops under their relevant section and in alphabetical order

require:
plugins:
# - rubocop-rails
# - rubocop-rspec
- rubocop-performance
Expand Down
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Changelog

- Updated app to Rails 7 [#3426](https://github.com/DMPRoadmap/roadmap/pull/3426)
- Address Some Bullet Warnings / Optimise Mean Request Times [#3440](https://github.com/DMPRoadmap/roadmap/pull/3440)
- Fix Flaky Tests / Optimize Checking of `plan.title` Within `spec/features/plans/exports_spec.rb` [#3451](https://github.com/DMPRoadmap/roadmap/pull/3451)
- Refactor Plan.deep_copy(plan) [#3469](https://github.com/DMPRoadmap/roadmap/pull/3469)
- Fixed a bug in the deep copy of plans where the old identifier was being copied into the new plan. We now copy the generated id of the new plan to the identifier field.
- Fixed bar chart click function in the Usage dashboard (GitHub issue #3443)
- Fixed broken link for the V1 API documentation.
- Fix `hidden_field_tag` Nested Attributes Format For Rails 7 Upgrade and Add Test Coverage [#3479](https://github.com/DMPRoadmap/roadmap/pull/3479)
- Update all workflows to `runs-on: ubuntu-24.04` and Consolidate Capybara Config [#3487](https://github.com/DMPRoadmap/roadmap/pull/3487)
- Add pdf handling in `render_respond_to_format_with_error_message` [#3482](https://github.com/DMPRoadmap/roadmap/pull/3482)
- Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and `/features` Tests [#3491](https://github.com/DMPRoadmap/roadmap/pull/3491)
- Bumped dependencies via `bundle update && yarn upgrade` [#3483](https://github.com/DMPRoadmap/roadmap/pull/3483)

## v4.2.0

**Note this upgrade is mainly a migration from Bootstrap 3 to Bootstrap 5.**
Expand Down
10 changes: 9 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ruby '>= 3.0'
# ===========#

# Full-stack web application framework. (http://rubyonrails.org)
gem 'rails', '~> 6.1'
gem 'rails', '~> 7.1'

# TODO: Remove this once Rails addresses the issue with its dependency on mimemagic. Mimemagic had
# an MIT license but was using some incompatible GPL license code.
Expand Down Expand Up @@ -47,6 +47,14 @@ gem 'jbuilder'
# Reduces boot times through caching; required in config/boot.rb
gem 'bootsnap', require: false

# The ultimate text progress bar library for Ruby!
# (https://github.com/jfelchner/ruby-progressbar)
gem 'ruby-progressbar'

# Provides Sprockets implementation for Rails 4.x (and beyond) Asset Pipeline.
# https://github.com/rails/sprockets-rails
gem 'sprockets-rails'

# ============== #
# ERROR HANDLING #
# ============== #
Expand Down
Loading
Loading