Fix #2276 - #2277
Open
kevyang08 wants to merge 1 commit into
Open
Conversation
| @registry.function | ||
| def relative_time(time, **kwargs): | ||
| abs_time = date(time, kwargs.get('format', _('N j, Y, g:i a'))) | ||
| abs_time = date(time.astimezone(timezone.get_current_timezone()), kwargs.get('format', _('N j, Y, g:i a'))) |
Member
There was a problem hiding this comment.
Does this work when the user is logged out? Ideally, we should use the browser's timezone when they are logged out.
Author
There was a problem hiding this comment.
Yeah, seems to work when I run it locally.
Edit: Nvm, seems to use DEFAULT_USER_TIME_ZONE in settings.py
Author
There was a problem hiding this comment.
I think that might have to be fixed separately in timezone.py
Author
There was a problem hiding this comment.
Is there a way for timezone.py to access the value of Intl.DateTimeFormat().resolvedOptions().timeZone? I've tried making a few changes other in timezone.py, but nothing worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts time to local time zone before assigning abs_time so that submissions display in user's selected time zone.