Repository navigation
Fix TiGLConsole startup bug when built under Linux - #1461
Open
svengoldberg wants to merge 2 commits into
Open
svengoldberg wants to merge 2 commits into
svengoldberg wants to merge 2 commits into
Conversation
Contributor
PR RemindersThis PR has changes in
This is an automated reminder from CI |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
=======================================
Coverage 73.74% 73.74%
=======================================
Files 324 324
Lines 28665 28665
=======================================
Hits 21140 21140
Misses 7525 7525
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Console showed warning that spoiles console. Hence, it needed a fresh prompt for users to enter commands.
The warning was printed right after
>>which spoiled the "currently entered" command.output()now detects output arriving while idle at the prompt: It removes the prompt line, prints the output in its place, re-inserts a fresh prompt below, and restores any text the user had already typed.showHistory()gets a_isDirty = trueso history entries keep the original append-below layout.Fix #1460
This fix was co-authored by an AI coding assistant and reviewed/verified by me before submission.
How Has This Been Tested?
The console in Linux is now directly usable from the start on. There is no different behaviour compared to the current main branch after the first prompt.
Also tested in Windows: As expected, there is no change at all (the issue did not occur here in the first place).
Screenshots, that help to understand the changes(if applicable):
Old behaviour: A fresh prompt (->
enter) was neededNow, the warning does no longer spoil the console and the users can directly enter commands
Checklist for PR Author:
Unit or integration test added (if applicable)Python interface updated (if applicable)Python test added (if Python interface updated)Doxygen docstrings addedChangeLog.mdupdated