Skip to content

Fix TiGLConsole startup bug when built under Linux - #1461

Open
svengoldberg wants to merge 2 commits into
mainfrom
1460-linux_fix_spoiled_console_at_start
Open

svengoldberg wants to merge 2 commits into
mainfrom
1460-linux_fix_spoiled_console_at_start

Conversation

@svengoldberg

Copy link
Copy Markdown
Contributor

Description

Console showed warning that spoiles console. Hence, it needed a fresh prompt for users to enter commands.

The warning was printed right after >> which spoiled the "currently entered" command. output() now detects output arriving while idle at the prompt: It removes the prompt line, prints the output in its place, re-inserts a fresh prompt below, and restores any text the user had already typed. showHistory() gets a _isDirty = true so history entries keep the original append-below layout.

Fix #1460


This fix was co-authored by an AI coding assistant and reviewed/verified by me before submission.


How Has This Been Tested?

The console in Linux is now directly usable from the start on. There is no different behaviour compared to the current main branch after the first prompt.
Also tested in Windows: As expected, there is no change at all (the issue did not occur here in the first place).

Screenshots, that help to understand the changes(if applicable):

image

Old behaviour: A fresh prompt (-> enter) was needed

image

Now, the warning does no longer spoil the console and the users can directly enter commands

Checklist for PR Author:

  • Unit or integration test added (if applicable)
  • Python interface updated (if applicable)
  • Python test added (if Python interface updated)
  • Doxygen docstrings added
  • ChangeLog.md updated

Startup bug in TiGLConsole when built under Linux: Console showed warning that spoiles console . Hence, it needed a fresh prompt for users to enter commands
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

PR Reminders

This PR has changes in TIGLCreator/ but not in src/, tests/unittests/, tests/integrationtests/, tests/python/, or bindings/python_internal/. ChangeLog.md has changes.

  • ✅ ChangeLog.md updated

This is an automated reminder from CI

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.74%. Comparing base (9c884ed) to head (685f4a4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   73.74%   73.74%           
=======================================
  Files         324      324           
  Lines       28665    28665           
=======================================
  Hits        21140    21140           
  Misses       7525     7525           
Flag Coverage Δ
unittests 73.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux: TiGL console cannot be used directly after start

2 participants