Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 114 114
Lines 19117 19117
=======================================
Hits 14969 14969
Misses 4148 4148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandro-elsweijer
requested changes
Mar 17, 2026
| @@ -0,0 +1,121 @@ | |||
| #include <fstream> | |||
Member
There was a problem hiding this comment.
Please include the license statement and file documentation
| #include <mpi.h> | ||
| #include <unordered_set> | ||
| #include <sc_options.h> | ||
|
|
Member
There was a problem hiding this comment.
can you remove the redundant example in the file name?
Comment on lines
+1
to
+17
| #include <fstream> | ||
| #include <iostream> | ||
| #include <string> | ||
| #include <algorithm> | ||
| #include <t8_cmesh/t8_cmesh.h> | ||
| #include <t8_cmesh/t8_cmesh.hxx> | ||
| #include <t8_cmesh/t8_cmesh_vertex_connectivity/t8_cmesh_vertex_connectivity.hxx> | ||
| #include <t8_cmesh/t8_cmesh_mesh_deformation/t8_cmesh_mesh_deformation.hxx> | ||
| #include <t8_schemes/t8_default/t8_default.hxx> | ||
| #include <t8_cmesh/t8_cmesh_io/t8_cmesh_readmshfile.h> | ||
| #include <t8_cad/t8_cad_handle.hxx> | ||
| #include <t8_vtk/t8_vtk_writer.h> | ||
| #include <vector> | ||
| #include <array> | ||
| #include <mpi.h> | ||
| #include <unordered_set> | ||
| #include <sc_options.h> |
Member
There was a problem hiding this comment.
Do you really need all those includes?
Can you also split them between t8code and std includes?
| SC_CHECK_MPI (mpiret); | ||
|
|
||
| /* Initialize the sc library, has to happen before we initialize t8code. */ | ||
| sc_init (sc_MPI_COMM_WORLD, 1, 1, NULL, SC_LP_PRODUCTION); |
Member
There was a problem hiding this comment.
Suggested change
| sc_init (sc_MPI_COMM_WORLD, 1, 1, NULL, SC_LP_PRODUCTION); | |
| sc_init (sc_MPI_COMM_WORLD, 1, 1, NULL, SC_LP_ESSENTIAL); |
Comment on lines
+59
to
+60
| const char *msh_file = NULL; | ||
| const char *brep_file = NULL; |
Member
There was a problem hiding this comment.
If you want, you can also use std containers like std::string for this
Comment on lines
+155
to
+157
| /** Update the CAD manager with a new one. | ||
| * \param[in] new_cad_handle The new CAD handle to be used. | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| /** Update the CAD manager with a new one. | |
| * \param[in] new_cad_handle The new CAD handle to be used. | |
| */ | |
| /** Update the CAD handle with a new one. | |
| * \param[in] new_cad_handle The new CAD handle to be used. | |
| */ |
Comment on lines
+276
to
+295
| /** | ||
| * Return an iterator to the beginning of the geometry handler. | ||
| * \return An iterator to the first geometry. | ||
| */ | ||
| auto | ||
| begin () | ||
| { | ||
| return registered_geometries.begin (); | ||
| } | ||
|
|
||
| /** | ||
| * Return an iterator to the end of the geometry handler. | ||
| * \return An iterator to the element following the last geometry. | ||
| */ | ||
| auto | ||
| end () | ||
| { | ||
| return registered_geometries.end (); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Is this code used?
Suggested change
| /** | |
| * Return an iterator to the beginning of the geometry handler. | |
| * \return An iterator to the first geometry. | |
| */ | |
| auto | |
| begin () | |
| { | |
| return registered_geometries.begin (); | |
| } | |
| /** | |
| * Return an iterator to the end of the geometry handler. | |
| * \return An iterator to the element following the last geometry. | |
| */ | |
| auto | |
| end () | |
| { | |
| return registered_geometries.end (); | |
| } |
| t8_forest/t8_forest_partition_for_coarsening.cxx | ||
| t8_forest/t8_forest_pfc_helper.cxx | ||
| t8_forest/t8_forest.cxx | ||
| t8_forest/t8_forest.cxx |
Member
There was a problem hiding this comment.
Suggested change
| t8_forest/t8_forest.cxx | |
| t8_forest/t8_forest.cxx |
| /* Moving plane loop */ | ||
| while (adapt_data.t < steps) { | ||
| /* Adapt and balance the forest. | ||
| /* Adapt and balance the forest. |
Member
There was a problem hiding this comment.
Suggested change
| /* Adapt and balance the forest. | |
| /* Adapt and balance the forest. |
Comment on lines
+48
to
+50
| #include <t8_geometry/t8_geometry_implementations/t8_geometry_cad.hxx> /* Curved geometry calculation of trees */ | ||
| #include <t8_cmesh/t8_cmesh_mesh_deformation/t8_cmesh_mesh_deformation.hxx> /* Mesh deformation struct */ | ||
| #include <t8_cad/t8_cad_handle.hxx> /* CAD data structure */ |
Member
There was a problem hiding this comment.
Suggested change
| #include <t8_geometry/t8_geometry_implementations/t8_geometry_cad.hxx> /* Curved geometry calculation of trees */ | |
| #include <t8_cmesh/t8_cmesh_mesh_deformation/t8_cmesh_mesh_deformation.hxx> /* Mesh deformation struct */ | |
| #include <t8_cad/t8_cad_handle.hxx> /* CAD data structure */ | |
| #include <t8_geometry/t8_geometry_implementations/t8_geometry_cad.hxx> /* Curved geometry calculation of trees */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2197
Describe your changes here:
Added mesh deformation support using the new t8_cmesh_mesh_deformation files. This allows moving mesh vertices to new positions defined by a CAD geometry.
The calculation is currently done by focusing on surface vertices and comparing their current locations with the target CAD shape. The displacement for internal vertices is not yet included. A new example, t8_cmesh_mesh_deformation_example.cxx, was added to show how the deformation works.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).