-
Notifications
You must be signed in to change notification settings - Fork 62
Feature benchmark search #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature benchmark search #1919
Conversation
fix variable name in endif statement Co-authored-by: Sandro Elsweijer <[email protected]>
…et for committed forest
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
==========================================
+ Coverage 75.77% 75.90% +0.12%
==========================================
Files 103 103
Lines 19230 19521 +291
==========================================
+ Hits 14572 14817 +245
- Misses 4658 4704 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Davknapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of the changes are based on development done in #1443. We should merge that one first, in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a file, that does not belong into t8code in my opinion. You can use it in t8data and cite t8data to make research-results reproducable.
Closes #1920
Describe your changes here:
Playground for search benchmark
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).