Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Finology): fixed Finology routes to new standards #18023

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

Rjnishant530
Copy link
Contributor

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/finology/bullets
/finology/category/success-stories
/finology/most-viewed
/finology/tag/airline-industry

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

Copy link
Contributor

github-actions bot commented Jan 1, 2025

Successfully generated as following:

http://localhost:1200/finology/bullets - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/bullets&quot;: 403 Forbidden
Route: /finology/bullets
Full Route: /finology/bullets
Node Version: v22.12.0
Git Hash: 86c3013e
http://localhost:1200/finology/category/success-stories - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/success-stories&quot;: 403 Forbidden
Route: /finology/category/:category
Full Route: /finology/category/success-stories
Node Version: v22.12.0
Git Hash: 86c3013e
http://localhost:1200/finology/most-viewed - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/most-viewed&quot;: 403 Forbidden
Route: /finology/most-viewed
Full Route: /finology/most-viewed
Node Version: v22.12.0
Git Hash: 86c3013e
http://localhost:1200/finology/tag/airline-industry - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/tag/airline-industry&quot;: 403 Forbidden
Route: /finology/tag/:topic
Full Route: /finology/tag/airline-industry
Node Version: v22.12.0
Git Hash: 86c3013e

@github-actions github-actions bot added the Auto: Route Test Complete Auto route test has finished on given PR label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Successfully generated as following:

http://localhost:1200/finology/bullets - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/bullets&quot;: 403 Forbidden
Route: /finology/bullets
Full Route: /finology/bullets
Node Version: v22.12.0
Git Hash: 1b9a9aae
http://localhost:1200/finology/category/success-stories - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/success-stories&quot;: 403 Forbidden
Route: /finology/category/:category
Full Route: /finology/category/success-stories
Node Version: v22.12.0
Git Hash: 1b9a9aae
http://localhost:1200/finology/most-viewed - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/most-viewed&quot;: 403 Forbidden
Route: /finology/most-viewed
Full Route: /finology/most-viewed
Node Version: v22.12.0
Git Hash: 1b9a9aae
http://localhost:1200/finology/tag/airline-industry - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/tag/airline-industry&quot;: 403 Forbidden
Route: /finology/tag/:topic
Full Route: /finology/tag/airline-industry
Node Version: v22.12.0
Git Hash: 1b9a9aae

@Rjnishant530
Copy link
Contributor Author

Successfully generated as following:

http://localhost:1200/finology/bullets - Failed ❌
http://localhost:1200/finology/category/success-stories - Failed ❌
http://localhost:1200/finology/most-viewed - Failed ❌
http://localhost:1200/finology/tag/airline-industry - Failed ❌

Maybe the access from foreign network is banned by origin website. It works well on localhost and in India

lib/routes/dlnews/category.ts Outdated Show resolved Hide resolved
lib/routes/dlnews/category.ts Outdated Show resolved Hide resolved
lib/routes/finology/utils.ts Outdated Show resolved Hide resolved
lib/types.ts Outdated Show resolved Hide resolved
@Rjnishant530 Rjnishant530 requested a review from TonyRL January 4, 2025 03:56
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Successfully generated as following:

http://localhost:1200/finology/bullets - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/bullets&quot;: 403 Forbidden
Route: /finology/bullets
Full Route: /finology/bullets
Node Version: v22.12.0
Git Hash: 09129723
http://localhost:1200/finology/category/success-stories - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/success-stories&quot;: 403 Forbidden
Route: /finology/category/:category
Full Route: /finology/category/success-stories
Node Version: v22.12.0
Git Hash: 09129723
http://localhost:1200/finology/most-viewed - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/most-viewed&quot;: 403 Forbidden
Route: /finology/most-viewed
Full Route: /finology/most-viewed
Node Version: v22.12.0
Git Hash: 09129723
http://localhost:1200/finology/tag/airline-industry - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/tag/airline-industry&quot;: 403 Forbidden
Route: /finology/tag/:topic
Full Route: /finology/tag/airline-industry
Node Version: v22.12.0
Git Hash: 09129723

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Successfully generated as following:

http://localhost:1200/finology/bullets - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/bullets&quot;: 403 Forbidden
Route: /finology/bullets
Full Route: /finology/bullets
Node Version: v22.12.0
Git Hash: 7a896feb
http://localhost:1200/finology/category/success-stories - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/success-stories&quot;: 403 Forbidden
Route: /finology/category/:category
Full Route: /finology/category/success-stories
Node Version: v22.12.0
Git Hash: 7a896feb
http://localhost:1200/finology/most-viewed - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/most-viewed&quot;: 403 Forbidden
Route: /finology/most-viewed
Full Route: /finology/most-viewed
Node Version: v22.12.0
Git Hash: 7a896feb
http://localhost:1200/finology/tag/airline-industry - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://insider.finology.in/tag/airline-industry&quot;: 403 Forbidden
Route: /finology/tag/:topic
Full Route: /finology/tag/airline-industry
Node Version: v22.12.0
Git Hash: 7a896feb

@TonyRL TonyRL requested a review from Copilot January 4, 2025 11:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • lib/routes/finology/utils.ts: Evaluated as low risk
@TonyRL TonyRL merged commit a1d8565 into DIYgod:master Jan 4, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR Route
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants