Numerous quality of life fixes #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C, returning an array returns a pointer to the first element, which will be on the stack in this case. As there's no guarantee that local data on the stack survives after returning from a function, this is dangerous. Making the variable static to make it survive past the function lifetime.
* Added support to compile on Windows + MSYS2 (WIP) * Modified BITMAP and RGBQUAD struct names to avoid conflict with wingdi.h struct on windows
* Convert codebase from CP850 charset to UTF8
…IVGAMES#15) When converting to UTF8, some characters now no longer fit in 1 byte. Use the actual original (CP850 charset) value of those characters instead
- [INSTALLER] fixed bug of buffer overflow in packager installer not allowing to save properly large file names on modern platforms - [INSTALLER] fixed bug not including some libraries needs to windows executable
We're not compiling with Watcom anymore, so this can be safely removed
Only formatting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges amiga_test back to master, with numerous fixes and enhancements.
Also likely breaks certain things...