Added GameLab under "Services" with pictures. Also added links to the GameLab and Conference under the CH-Ludens Project. #37
Conversation
… conference and the gamelab under CH-Ludens Project.
|
""" WalkthroughA new content page for the GameLab at the University of Bern was added, featuring detailed information and a tabbed layout. The "Confoederatio Ludens" project page was updated to resize the logo and include new internal links to the GameLab and a related conference. Additionally, a minor correction was made to an author's email address in the Historicizing G.A.M.E.S. 2025 page, along with added alt text for images. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ProjectPage
participant GameLabPage
participant ConferencePage
User->>ProjectPage: Visit "Confoederatio Ludens" page
ProjectPage-->>User: Display resized logo and links
User->>GameLabPage: Click "GameLab" link
GameLabPage-->>User: Show GameLab content (tabs: Home, Magazines)
User->>ConferencePage: Click "Historicizing G.A.M.E.S. 2025" link
ConferencePage-->>User: Show conference information
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (2)
content/services/gamelab/index.qmd (1)
56-57: Sentence ends abruptly
"...and we receive."appears to be an incomplete clause. Consider revising for clarity.content/projects/ch-ludens/index.qmd (1)
10-10:width=50%is not a valid Quarto attributeQuarto expects
width="50%"(quoted) orwidth=50(number). Unquoted percentages can be ignored by the renderer.-{fig-align="center" width=50%} +{fig-align="center" width="50%"}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
content/services/gamelab/Gamelab_Logo-03.pngis excluded by!**/*.pngcontent/services/gamelab/magazines.jpegis excluded by!**/*.jpeg
📒 Files selected for processing (2)
content/projects/ch-ludens/index.qmd(2 hunks)content/services/gamelab/index.qmd(1 hunks)
🔇 Additional comments (1)
content/services/gamelab/index.qmd (1)
70-74: Inline image already has alt text – greatThe magazine image includes both
altand basic styling; nothing to change here.
There was a problem hiding this comment.
@addrichmauch I left some comments. Please try to resolve them and tag me again if you are done for a second review. Reach out, if you have questions!
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
content/services/gamelab/index.qmd (1)
49-49: Consider improving the tab switching mechanism.The inline JavaScript for tab switching works but could be more maintainable. Consider using a more semantic approach or extracting the JavaScript.
-<a href="#" onclick="new bootstrap.Tab(document.getElementById('pills-magazines-tab')).show(); return false;"> Game Magazines </a> +<a href="#pills-magazines" data-bs-toggle="pill" data-bs-target="#pills-magazines" role="tab">Game Magazines</a>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/services/gamelab/index.qmd(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build, Optimize, and Upload Artifacts
🔇 Additional comments (3)
content/services/gamelab/index.qmd (3)
1-15: YAML frontmatter is well-structured and complete.The metadata includes all necessary fields with proper formatting. The author information is comprehensive with ORCID and institutional affiliation.
17-42: Navigation structure is well-implemented.The Bootstrap nav-pills component is properly structured with correct ARIA attributes for accessibility. The logo includes appropriate alt text and styling.
70-84: Magazine collection content is comprehensive and well-structured.The detailed description of the video game magazine collection is informative and well-researched. The image includes proper alt text and styling.
|
Will add .lightbox to all pictures later, as well as all relative URLs. |
|
@vvvyyynet Added alternative text for pictures for accessability as requested. |
vvvyyynet
left a comment
vvvyyynet
left a comment
There was a problem hiding this comment.
Well done. I left one minor comment, but you can definitely also merge without further changes.
vvvyyynet
left a comment
vvvyyynet
left a comment
There was a problem hiding this comment.
After approving this two minutes ago, I realised that there are open merge conflicts, since two tests failed. One of them is due to a dead link to the non existent page
http://localhost:5528/content/projects/services/gamelab. It seems that you have to create this first (either in this PR, or more cleanly in another one) before this can be merged.
Sorry, I missed this earlier.
|
Alright, deleted GameLab Link for now :) |
vvvyyynet
left a comment
vvvyyynet
left a comment
There was a problem hiding this comment.
Approving. If merging does not work now, you should ask @flicksolutions since it may be the other test that is failing. And I have no idea what this could be (seems unrelated to your changes).
… conference and the gamelab under CH-Ludens Project.
Pull request
Proposed changes
Types of changes
Checklist
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes