Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inset text #1355

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Update inset text #1355

merged 2 commits into from
Feb 3, 2025

Conversation

Kizr
Copy link
Contributor

@Kizr Kizr commented Feb 3, 2025

Context

The inset text was use incorrectly under the design system guidelines, we have updated to the text be in more semantically correct containers.

Changes proposed in this pull request

  • Updates the inset text for the claims index page
  • Updates the inset text for the mentors page when adding a claim

Guidance to review

  • Log in as Anne
  • Review the guidance on the claims index page
  • Add a claim for a mentor with 20 hours
  • Add a second claim and review details text

Link to Trello card

Change inset text on claims homepage school user
Change inset text on Mentors page during add claim flow (school user)

Screenshots

image
image

@Kizr Kizr added the deploy A Review App will be created for PRs with this label label Feb 3, 2025
@Kizr Kizr self-assigned this Feb 3, 2025
@Kizr Kizr requested review from a team as code owners February 3, 2025 14:22
Copy link

github-actions bot commented Feb 3, 2025

Review app track and pay deployed to https://track-and-pay-1355.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1355.test.teacherservices.cloud was deleted

@Kizr Kizr merged commit 823b0b9 into main Feb 3, 2025
16 checks passed
@Kizr Kizr deleted the ba/update-inset-text branch February 3, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants