Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sampling provider response validation #1346

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Improve sampling provider response validation #1346

merged 8 commits into from
Jan 27, 2025

Conversation

JamieCleare2525
Copy link
Contributor

@JamieCleare2525 JamieCleare2525 commented Jan 27, 2025 •
edited
Loading

Context

  • Add/improve validation when uploading a sampling provider response

Changes proposed in this pull request

Guidance to review

  • Sign in as Colin (Support user)
  • Navigate to Claims -> Auditing
  • (Assuming you have claims with the sampling_in_progress status)
  • Click "Upload provider response"
  • Upload your provider response CSV
  • You should now see a re-designed table view of the CSV you uploaded (assuming there are no errors)
  • Change the CSV to introduce errors
  • Re-upload the CSV
  • You should now see a re-designed table view for errors within your CSV

Link to Trello card

https://trello.com/c/R50H68fS/374-build-at-risk-improve-validation-for-sampling-provider-response-wizard

Screenshots

Valid upload
screencapture-claims-localhost-3000-support-claims-sampling-claims-provider-response-new-986a3040-3892-4017-a24d-4f601bbc35c7-confirmation-2025-01-27-13_20_29

Invalid upload
screencapture-claims-localhost-3000-support-claims-sampling-claims-provider-response-new-986a3040-3892-4017-a24d-4f601bbc35c7-upload-errors-2025-01-27-13_22_34

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Jan 27, 2025
@JamieCleare2525 JamieCleare2525 self-assigned this Jan 27, 2025
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners January 27, 2025 13:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Review app track and pay deployed to https://track-and-pay-1346.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1346.test.teacherservices.cloud was deleted

@JamieCleare2525 JamieCleare2525 merged commit f86f3c1 into main Jan 27, 2025
10 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/improve_sampling_provider_response_validation branch January 27, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kizr Kizr Kizr approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieCleare2525 @Kizr