Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make database creation optional #1336

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Make database creation optional #1336

merged 1 commit into from
Jan 27, 2025

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Jan 21, 2025

Context

Allow db schema load on review apps instead of running all migrations

Changes proposed in this pull request

Do not create the database in review to force rails to create it and load schema via db:prepare

Guidance to review

Check review app

@saliceti saliceti added the deploy A Review App will be created for PRs with this label label Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

Review app track and pay deployed to https://track-and-pay-1336.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1336.test.teacherservices.cloud was deleted

@saliceti saliceti marked this pull request as ready for review January 27, 2025 11:57
@saliceti saliceti requested review from a team as code owners January 27, 2025 11:57
@saliceti saliceti merged commit 2878a11 into main Jan 27, 2025
12 checks passed
@saliceti saliceti deleted the optional-create-db branch January 27, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants