Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2151] Output terraform external urls #1335

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[2151] Output terraform external urls #1335

merged 1 commit into from
Jan 21, 2025

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Jan 21, 2025

Context

Use ittms deployments as smoke test for the AKS platform deployment.
Currently failing: https://github.com/DFE-Digital/teacher-services-cloud/actions/runs/12890121135/job/35938967409

Changes proposed in this pull request

Use the new URL output format defined in the template

Guidance to review

  • make review terraform-init PR_NUMBER=1335
  • terraform -chdir=terraform/application output external_urls

Link to Trello card

https://trello.com/c/F9hmE3if

This is the new format as defined in the template. Used by
teacher-services-cloud for their platform smoke tests.
@saliceti saliceti added the deploy A Review App will be created for PRs with this label label Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

Review app track and pay deployed to https://track-and-pay-1335.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1335.test.teacherservices.cloud was deleted

@saliceti saliceti marked this pull request as ready for review January 21, 2025 17:23
Copy link
Contributor

@shaheislamdfe shaheislamdfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will assume make output has been locally validated for external URLs

@saliceti saliceti merged commit 679d12b into main Jan 21, 2025
16 checks passed
@saliceti saliceti deleted the 2151-tf-ext-urls branch January 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants